zacharymorn commented on a change in pull request #2141:
URL: https://github.com/apache/lucene-solr/pull/2141#discussion_r552386265
##########
File path: lucene/core/src/java/org/apache/lucene/search/WANDScorer.java
##########
@@ -447,6 +461,23 @@ private int doNextCompetitiveCandidate() throws
IOException {
}
}
+ // nocommit Do we still need the following given
TwoPhaseIterator.matches already performs the check
+// minCompetitiveScore satisfied, now checks if the doc has enough
required number of matches
+// while (freq < minShouldMatch) {
+// if (freq + tailSize >= minShouldMatch) {
+// // a match on doc is still possible, try to
+// // advance scorers from the tail
+// advanceTail();
Review comment:
Makes sense. I've updated the code to include this check in the while
loop condition.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
