murblanc commented on a change in pull request #2179:
URL: https://github.com/apache/lucene-solr/pull/2179#discussion_r552208910
##########
File path:
solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementFactory.java
##########
@@ -193,6 +195,22 @@ public PlacementPlan computePlacement(Cluster cluster,
PlacementRequest request,
Set<Node> nodes = request.getTargetNodes();
SolrCollection solrCollection = request.getCollection();
+ final SolrCollection secondaryCollection;
+ String withCollection =
solrCollection.getCustomProperty(CollectionAdminParams.WITH_COLLECTION);
Review comment:
`withCollection` variable here will be the property configured on the
collection, it will not resolve the alias if there's one. I believe we need to
use params from the placement request to decide if we try to resolve?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
