murblanc commented on a change in pull request #2179:
URL: https://github.com/apache/lucene-solr/pull/2179#discussion_r552226534
##########
File path:
solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java
##########
@@ -116,6 +121,25 @@ public void call(ClusterState clusterState, ZkNodeProps
message, @SuppressWarnin
throw new SolrException(SolrException.ErrorCode.BAD_REQUEST, "collection
alias already exists: " + collectionName);
}
+ String withCollection = message.getStr(WITH_COLLECTION);
+ String withCollectionShard = null;
+ if (withCollection != null) {
+ String realWithCollection = aliases.resolveSimpleAlias(withCollection);
Review comment:
Or is the collection created with the `withCollection` property that is
assumed to be an actual collection?
Wouldn't this somehow defeats the purpose of an alias? What prevents having
the collection `withCollection` property follow aliases? Follow always? Or not
always? The current proposal follows always given it doesn't check
`followAliases`. In which case maybe resolving the alias each time replicas are
added to the collection makes sense? Let the placement plugin do the failure,
it's checking the `withCollection` collection is appropriate anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
