murblanc commented on a change in pull request #2179:
URL: https://github.com/apache/lucene-solr/pull/2179#discussion_r552210621



##########
File path: 
solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementFactory.java
##########
@@ -193,6 +195,22 @@ public PlacementPlan computePlacement(Cluster cluster, 
PlacementRequest request,
       Set<Node> nodes = request.getTargetNodes();
       SolrCollection solrCollection = request.getCollection();
 
+      final SolrCollection secondaryCollection;
+      String withCollection = 
solrCollection.getCustomProperty(CollectionAdminParams.WITH_COLLECTION);

Review comment:
       Taking this back, ignore previous comments. We resolved alias at 
collection creation time so expecting real collection name here.

##########
File path: 
solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementFactory.java
##########
@@ -193,6 +195,22 @@ public PlacementPlan computePlacement(Cluster cluster, 
PlacementRequest request,
       Set<Node> nodes = request.getTargetNodes();
       SolrCollection solrCollection = request.getCollection();
 
+      final SolrCollection secondaryCollection;
+      String withCollection = 
solrCollection.getCustomProperty(CollectionAdminParams.WITH_COLLECTION);

Review comment:
       Taking this back, ignore previous comment.
   We resolved alias at collection creation time so expecting real collection 
name here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to