dweiss commented on a change in pull request #1732:
URL: https://github.com/apache/lucene-solr/pull/1732#discussion_r468366809
##
File path: lucene/core/src/java/org/apache/lucene/analysis/Analyzer.java
##
@@ -94,7 +94,7 @@
* Create a new Analyzer, reusing the same set of c
dweiss commented on a change in pull request #1732:
URL: https://github.com/apache/lucene-solr/pull/1732#discussion_r468367148
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/blocktree/BlockTreeTermsWriter.java
##
@@ -709,7 +709,7 @@ private PendingBlock writeBlock
[
https://issues.apache.org/jira/browse/LUCENE-9453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175294#comment-17175294
]
Dawid Weiss commented on LUCENE-9453:
-
I believe it might have been left out intenti
dweiss commented on a change in pull request #1732:
URL: https://github.com/apache/lucene-solr/pull/1732#discussion_r468369400
##
File path: lucene/core/src/java/org/apache/lucene/index/SegmentInfos.java
##
@@ -440,7 +440,7 @@ public static final SegmentInfos readCommit(Directo
uschindler commented on a change in pull request #1732:
URL: https://github.com/apache/lucene-solr/pull/1732#discussion_r468374779
##
File path: lucene/core/src/java/org/apache/lucene/analysis/Analyzer.java
##
@@ -367,12 +367,12 @@ public void close() {
/**
* Origina
uschindler commented on a change in pull request #1732:
URL: https://github.com/apache/lucene-solr/pull/1732#discussion_r468376068
##
File path: lucene/core/src/java/org/apache/lucene/analysis/Analyzer.java
##
@@ -367,12 +367,12 @@ public void close() {
/**
* Origina
[
https://issues.apache.org/jira/browse/SOLR-13528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175298#comment-17175298
]
Atri Sharma commented on SOLR-13528:
Thanks for fixing this, [~ctargett] !
> Rate li
atris opened a new pull request #1736:
URL: https://github.com/apache/lucene-solr/pull/1736
This commit adds higher data size and load in the test path. Also improves
the asserts that are performed.
This is an automated me
s1monw commented on pull request #1734:
URL: https://github.com/apache/lucene-solr/pull/1734#issuecomment-671779004
this lock is left out intentionally to reduce the overhead of acquiring a
reentrant lock. We only call this method internally from a method that
guarantees the lock is held.
sigram commented on a change in pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r468379500
##
File path:
solr/core/src/java/org/apache/solr/cluster/placement/ReplicaPlacement.java
##
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software F
[
https://issues.apache.org/jira/browse/LUCENE-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maxim Glazkov updated LUCENE-9373:
--
Attachment: LUCENE-9373.patch
> Allow FunctionMatchQuery to customize matchCost of TwoPhaseIte
[
https://issues.apache.org/jira/browse/LUCENE-9448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-9448:
Attachment: LUCENE-9448.patch
> Make an equivalent to Ant's "run" target for Luke module
> ---
murblanc commented on a change in pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r468398576
##
File path:
solr/core/src/java/org/apache/solr/cluster/placement/PlacementPlugin.java
##
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/LUCENE-9448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175344#comment-17175344
]
Dawid Weiss commented on LUCENE-9448:
-
I attached a patch that demonstrates a couple
murblanc commented on a change in pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r468403391
##
File path:
solr/core/src/java/org/apache/solr/cluster/placement/PlacementPlanFactory.java
##
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Soft
murblanc commented on a change in pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r468405452
##
File path:
solr/core/src/java/org/apache/solr/cluster/placement/AddReplicasPlacementRequest.java
##
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apac
murblanc commented on a change in pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r468412029
##
File path:
solr/core/src/java/org/apache/solr/cluster/placement/plugins/SamplePluginMinimizeCores.java
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to t
murblanc commented on a change in pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r468415587
##
File path:
solr/core/src/java/org/apache/solr/cluster/placement/ReplicaPlacement.java
##
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software
murblanc commented on a change in pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r468418051
##
File path:
solr/core/src/java/org/apache/solr/cluster/placement/plugins/SamplePluginMinimizeCores.java
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to t
[
https://issues.apache.org/jira/browse/SOLR-14615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Atri Sharma reassigned SOLR-14615:
--
Assignee: Atri Sharma
> CPU Based Circuit Breaker
> -
>
>
atris opened a new pull request #1737:
URL: https://github.com/apache/lucene-solr/pull/1737
This commit introduces CPU based circuit breaker. This circuit breaker
tracks the average CPU load per minute and triggers if the value exceeds
a configurable value.
This commit also adds
noblepaul commented on pull request #1737:
URL: https://github.com/apache/lucene-solr/pull/1737#issuecomment-671830133
The configuration can be as simple as
``
This way you can just read all the attributes all at once from the
`PluginInfo` .
---
Dawid Weiss created LUCENE-9454:
---
Summary: Upgrade hamcrest to version 2.2
Key: LUCENE-9454
URL: https://issues.apache.org/jira/browse/LUCENE-9454
Project: Lucene - Core
Issue Type: Task
Af
noblepaul edited a comment on pull request #1737:
URL: https://github.com/apache/lucene-solr/pull/1737#issuecomment-671830133
The configuration can be as simple as
``
This way you can just read all the attributes all at once from the
`PluginInfo` .
CircuitBreaker should be a
noblepaul edited a comment on pull request #1737:
URL: https://github.com/apache/lucene-solr/pull/1737#issuecomment-671830133
The configuration can be as simple as
``
This way you can just read all the attributes all at once from the
`PluginInfo` .
CircuitBreaker should b
[
https://issues.apache.org/jira/browse/SOLR-14615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175398#comment-17175398
]
Noble Paul commented on SOLR-14615:
---
We need to drastically change the configuration.
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175399#comment-17175399
]
Noble Paul commented on SOLR-14588:
---
Let's revert this and fix the configuration
> Cir
dweiss opened a new pull request #1738:
URL: https://github.com/apache/lucene-solr/pull/1738
Precommit passes with ant and gradle. Running tests now.
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Noble Paul updated SOLR-14588:
--
Priority: Blocker (was: Major)
> Circuit Breakers Infrastructure and Real JVM Based Circuit Breaker
>
dweiss commented on a change in pull request #1738:
URL: https://github.com/apache/lucene-solr/pull/1738#discussion_r468451061
##
File path: lucene/test-framework/build.gradle
##
@@ -22,9 +22,13 @@ description = 'Framework for testing Lucene-based
applications'
dependencies {
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Noble Paul updated SOLR-14588:
--
Fix Version/s: 8.7
> Circuit Breakers Infrastructure and Real JVM Based Circuit Breaker
> -
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175402#comment-17175402
]
Noble Paul edited comment on SOLR-14588 at 8/11/20, 9:38 AM:
-
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175402#comment-17175402
]
Noble Paul commented on SOLR-14588:
---
The configuration can be as follows
{code:xml}
{
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175402#comment-17175402
]
Noble Paul edited comment on SOLR-14588 at 8/11/20, 9:38 AM:
-
dweiss merged pull request #1738:
URL: https://github.com/apache/lucene-solr/pull/1738
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/LUCENE-9454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved LUCENE-9454.
-
Resolution: Fixed
> Upgrade hamcrest to version 2.2
> ---
>
>
[
https://issues.apache.org/jira/browse/LUCENE-9454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175420#comment-17175420
]
ASF subversion and git services commented on LUCENE-9454:
-
Commi
atris commented on pull request #1737:
URL: https://github.com/apache/lucene-solr/pull/1737#issuecomment-671879842
> The configuration can be as simple as
>
> ``
>
> This way you can just read all the attributes all at once from the
`PluginInfo` .
> CircuitBreaker should be
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175453#comment-17175453
]
Atri Sharma commented on SOLR-14588:
As discussed offline, this can be done as a refa
atris edited a comment on pull request #1737:
URL: https://github.com/apache/lucene-solr/pull/1737#issuecomment-671879842
> The configuration can be as simple as
>
> ``
>
> This way you can just read all the attributes all at once from the
`PluginInfo` .
> CircuitBreaker sh
[
https://issues.apache.org/jira/browse/LUCENE-9439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175481#comment-17175481
]
Dawid Weiss commented on LUCENE-9439:
-
A cleaned up version in the PR. Running tests
gerlowskija commented on pull request #1707:
URL: https://github.com/apache/lucene-solr/pull/1707#issuecomment-671912624
Thanks for the review Munendra; I made the changes you suggested. Merging
now.
This is an automated me
[
https://issues.apache.org/jira/browse/SOLR-14692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175514#comment-17175514
]
ASF subversion and git services commented on SOLR-14692:
Commit 5
gerlowskija merged pull request #1707:
URL: https://github.com/apache/lucene-solr/pull/1707
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
[
https://issues.apache.org/jira/browse/SOLR-14630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175518#comment-17175518
]
Ivan Djurasevic commented on SOLR-14630:
{quote}When you say "batch update", do y
[
https://issues.apache.org/jira/browse/LUCENE-9439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175519#comment-17175519
]
Dawid Weiss commented on LUCENE-9439:
-
Seems to pass all tests and checks. Works for
madrob commented on a change in pull request #1736:
URL: https://github.com/apache/lucene-solr/pull/1736#discussion_r468542925
##
File path:
solr/core/src/test/org/apache/solr/servlet/TestRequestRateLimiter.java
##
@@ -66,15 +66,11 @@ public void testConcurrentQueries() throws
[
https://issues.apache.org/jira/browse/SOLR-13412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175528#comment-17175528
]
Dawid Weiss commented on SOLR-13412:
bq. My current thinking is that if the stand-alo
Erick Erickson created SOLR-14727:
-
Summary: Add gradle files to the 8x .gitignore file.
Key: SOLR-14727
URL: https://issues.apache.org/jira/browse/SOLR-14727
Project: Solr
Issue Type: Improv
[
https://issues.apache.org/jira/browse/SOLR-14692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175544#comment-17175544
]
ASF subversion and git services commented on SOLR-14692:
Commit d
Joel Bernstein created SOLR-14728:
-
Summary: Add self join optimization to the TopLevelJoinQuery
Key: SOLR-14728
URL: https://issues.apache.org/jira/browse/SOLR-14728
Project: Solr
Issue Type
[
https://issues.apache.org/jira/browse/SOLR-14728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Bernstein updated SOLR-14728:
--
Description: A simple strategy can be put in place to massively improve
join performance when t
[
https://issues.apache.org/jira/browse/SOLR-14728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Bernstein updated SOLR-14728:
--
Description: A simple optimization that can be put in place to massively
improve join performan
[
https://issues.apache.org/jira/browse/SOLR-14692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski resolved SOLR-14692.
Fix Version/s: 8.7
master (9.0)
Assignee: Jason Gerlowski
David Smiley created LUCENE-9455:
Summary: ExitableTermsEnum (in ExitableDirectoryReader) should
sample next()
Key: LUCENE-9455
URL: https://issues.apache.org/jira/browse/LUCENE-9455
Project: Lucene -
[
https://issues.apache.org/jira/browse/SOLR-14728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Bernstein updated SOLR-14728:
--
Description: A simple optimization can be put in place to massively improve
join performance wh
[
https://issues.apache.org/jira/browse/SOLR-14728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Bernstein updated SOLR-14728:
--
Description: A simple optimization can be put in place to massively improve
join performance wh
[
https://issues.apache.org/jira/browse/LUCENE-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175583#comment-17175583
]
Bruno Roustant commented on LUCENE-9379:
[~Raji] maybe a better approach would b
[
https://issues.apache.org/jira/browse/SOLR-14650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Houston Putman resolved SOLR-14650.
---
Fix Version/s: (was: 8.7)
Resolution: Abandoned
The default autoscaling policy has
[
https://issues.apache.org/jira/browse/SOLR-13412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175606#comment-17175606
]
David Eric Pugh commented on SOLR-13412:
I've been following this conversation, a
madrob commented on a change in pull request #1732:
URL: https://github.com/apache/lucene-solr/pull/1732#discussion_r468622877
##
File path: lucene/core/src/java/org/apache/lucene/analysis/Analyzer.java
##
@@ -367,12 +367,12 @@ public void close() {
/**
* Original so
[
https://issues.apache.org/jira/browse/SOLR-13412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175609#comment-17175609
]
Erick Erickson commented on SOLR-13412:
---
[~dweiss] Yes, I saw that. My take at this
madrob commented on a change in pull request #1732:
URL: https://github.com/apache/lucene-solr/pull/1732#discussion_r468631394
##
File path: lucene/core/src/java/org/apache/lucene/index/SegmentInfos.java
##
@@ -440,7 +440,7 @@ public static final SegmentInfos readCommit(Directo
[
https://issues.apache.org/jira/browse/SOLR-14727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson updated SOLR-14727:
--
Description:
This is a little different than I thought. Apparently it's an interaction with
In
[
https://issues.apache.org/jira/browse/SOLR-14727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson updated SOLR-14727:
--
Attachment: SOLR-14727.patch
> Add gradle files to the 8x .gitignore file.
> --
[
https://issues.apache.org/jira/browse/SOLR-14727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson updated SOLR-14727:
--
Description:
This is a little different than I thought. Apparently it's an interaction with
In
[
https://issues.apache.org/jira/browse/SOLR-14727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson updated SOLR-14727:
--
Attachment: (was: SOLR-14727.patch)
> Add gradle files to the 8x .gitignore file.
> ---
[
https://issues.apache.org/jira/browse/SOLR-14727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson updated SOLR-14727:
--
Attachment: SOLR-14727.patch
> Add gradle files to the 8x .gitignore file.
> --
[
https://issues.apache.org/jira/browse/SOLR-14727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175633#comment-17175633
]
ASF subversion and git services commented on SOLR-14727:
Commit 7
[
https://issues.apache.org/jira/browse/SOLR-14727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson resolved SOLR-14727.
---
Fix Version/s: 8.7
Resolution: Fixed
> Add gradle files to the 8x .gitignore file.
> -
gautamworah96 commented on pull request #1733:
URL: https://github.com/apache/lucene-solr/pull/1733#issuecomment-672021513
Changes in this revision (incorporated from feedback on JIRA):
* Added a call to `advanceExact()` before calling `.binaryValue()` and an
`assert` to check that t
madrob merged pull request #1734:
URL: https://github.com/apache/lucene-solr/pull/1734
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/LUCENE-9453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175651#comment-17175651
]
ASF subversion and git services commented on LUCENE-9453:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob resolved LUCENE-9453.
---
Fix Version/s: master (9.0)
Lucene Fields: (was: New)
Assignee: Mike Drob
Resol
atris commented on a change in pull request #1736:
URL: https://github.com/apache/lucene-solr/pull/1736#discussion_r468681532
##
File path:
solr/core/src/test/org/apache/solr/servlet/TestRequestRateLimiter.java
##
@@ -66,15 +66,11 @@ public void testConcurrentQueries() throws
Adrien Grand created LUCENE-9456:
Summary: Stored fields should store the number of chunks in the
meta file
Key: LUCENE-9456
URL: https://issues.apache.org/jira/browse/LUCENE-9456
Project: Lucene - Co
[
https://issues.apache.org/jira/browse/LUCENE-9448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175661#comment-17175661
]
Tomoko Uchida commented on LUCENE-9448:
---
Thank you [~dweiss] for your help.
{quot
dsmiley commented on a change in pull request #1726:
URL: https://github.com/apache/lucene-solr/pull/1726#discussion_r468709003
##
File path: solr/core/src/java/org/apache/solr/search/SolrQueryTimeoutImpl.java
##
@@ -67,8 +69,21 @@ public boolean shouldExit() {
}
/**
-
madrob commented on a change in pull request #1736:
URL: https://github.com/apache/lucene-solr/pull/1736#discussion_r468709509
##
File path:
solr/core/src/test/org/apache/solr/servlet/TestRequestRateLimiter.java
##
@@ -66,20 +65,19 @@ public void testConcurrentQueries() throws
atris commented on a change in pull request #1726:
URL: https://github.com/apache/lucene-solr/pull/1726#discussion_r468709958
##
File path: solr/core/src/java/org/apache/solr/search/SolrQueryTimeoutImpl.java
##
@@ -67,8 +69,21 @@ public boolean shouldExit() {
}
/**
-
dsmiley commented on a change in pull request #1726:
URL: https://github.com/apache/lucene-solr/pull/1726#discussion_r468710559
##
File path: solr/core/src/java/org/apache/solr/search/SolrQueryTimeoutImpl.java
##
@@ -67,8 +69,21 @@ public boolean shouldExit() {
}
/**
-
atris commented on a change in pull request #1736:
URL: https://github.com/apache/lucene-solr/pull/1736#discussion_r468713194
##
File path:
solr/core/src/test/org/apache/solr/servlet/TestRequestRateLimiter.java
##
@@ -66,20 +65,19 @@ public void testConcurrentQueries() throws
madrob commented on a change in pull request #1737:
URL: https://github.com/apache/lucene-solr/pull/1737#discussion_r468711266
##
File path:
solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java
##
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Softwa
madrob commented on a change in pull request #1728:
URL: https://github.com/apache/lucene-solr/pull/1728#discussion_r468716670
##
File path: solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java
##
@@ -244,6 +247,8 @@ public String getBasePath() {
public void add
dsmiley merged pull request #1735:
URL: https://github.com/apache/lucene-solr/pull/1735
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
madrob commented on a change in pull request #1736:
URL: https://github.com/apache/lucene-solr/pull/1736#discussion_r468721648
##
File path:
solr/core/src/test/org/apache/solr/servlet/TestRequestRateLimiter.java
##
@@ -48,7 +47,7 @@ public static void setupCluster() throws Exc
madrob commented on a change in pull request #1736:
URL: https://github.com/apache/lucene-solr/pull/1736#discussion_r468724755
##
File path:
solr/core/src/test/org/apache/solr/servlet/TestRequestRateLimiter.java
##
@@ -66,20 +65,19 @@ public void testConcurrentQueries() throws
[
https://issues.apache.org/jira/browse/LUCENE-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175699#comment-17175699
]
Rajeswari Natarajan commented on LUCENE-9379:
-
[~bruno.roustant] and [~dsmil
atris commented on a change in pull request #1736:
URL: https://github.com/apache/lucene-solr/pull/1736#discussion_r468727485
##
File path:
solr/core/src/test/org/apache/solr/servlet/TestRequestRateLimiter.java
##
@@ -48,7 +47,7 @@ public static void setupCluster() throws Exce
atris commented on a change in pull request #1737:
URL: https://github.com/apache/lucene-solr/pull/1737#discussion_r468728850
##
File path:
solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java
##
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Softwar
[
https://issues.apache.org/jira/browse/LUCENE-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175699#comment-17175699
]
Rajeswari Natarajan edited comment on LUCENE-9379 at 8/11/20, 4:59 PM:
---
jpountz commented on pull request #1593:
URL: https://github.com/apache/lucene-solr/pull/1593#issuecomment-672097226
I repurposed this PR to instead make the test expect out-of-bounds
exceptions. Does it look better to you @rmuir @uschindler ?
-
atris merged pull request #1736:
URL: https://github.com/apache/lucene-solr/pull/1736
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
uschindler commented on pull request #1593:
URL: https://github.com/apache/lucene-solr/pull/1593#issuecomment-672106735
I am fine to fix the test. Sure you have to first figure out why the index
is out of bounds, and the exact exception may be misleading, but that's
actually what's happeni
atris commented on a change in pull request #1737:
URL: https://github.com/apache/lucene-solr/pull/1737#discussion_r468756781
##
File path: solr/core/src/java/org/apache/solr/core/SolrConfig.java
##
@@ -811,10 +818,18 @@ private void initLibs(SolrResourceLoader loader, boolean
madrob commented on a change in pull request #1726:
URL: https://github.com/apache/lucene-solr/pull/1726#discussion_r468762245
##
File path: solr/core/src/java/org/apache/solr/search/SolrQueryTimeoutImpl.java
##
@@ -67,8 +69,21 @@ public boolean shouldExit() {
}
/**
-
[
https://issues.apache.org/jira/browse/SOLR-13412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175750#comment-17175750
]
Tomoko Uchida commented on SOLR-13412:
--
[~epugh] :
{quote}I think that the real issu
jimczi commented on a change in pull request #1725:
URL: https://github.com/apache/lucene-solr/pull/1725#discussion_r468774381
##
File path: lucene/core/src/java/org/apache/lucene/search/FieldValueHitQueue.java
##
@@ -160,18 +160,20 @@ private FieldValueHitQueue(SortField[] fie
HoustonPutman opened a new pull request #1739:
URL: https://github.com/apache/lucene-solr/pull/1739
forward-porting #1716 for https://issues.apache.org/jira/browse/SOLR-14706
This is an automated message from the Apache Git S
[
https://issues.apache.org/jira/browse/SOLR-13972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17175803#comment-17175803
]
Jason Gerlowski commented on SOLR-13972:
Reopening based on the mailing list thre
1 - 100 of 132 matches
Mail list logo
