uschindler commented on a change in pull request #1732: URL: https://github.com/apache/lucene-solr/pull/1732#discussion_r468376068
########## File path: lucene/core/src/java/org/apache/lucene/analysis/Analyzer.java ########## @@ -367,12 +367,12 @@ public void close() { /** * Original source of the tokens. */ - protected final Consumer<Reader> source; Review comment: There's also no risk somebody could do anything wrong. It's both (also next one) final field and the it's for consuming only. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org