[GitHub] [lucene-solr] jimczi commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-05-14 Thread GitBox
jimczi commented on a change in pull request #1351: URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r424930005 ## File path: lucene/core/src/java/org/apache/lucene/search/FieldComparator.java ## @@ -159,14 +159,15 @@ protected void doSetNextReader(LeafReaderCont

[jira] [Created] (SOLR-14483) AdminUI - Create replica - empty drop-down

2020-05-14 Thread Jira
Morten Bøgeskov created SOLR-14483: -- Summary: AdminUI - Create replica - empty drop-down Key: SOLR-14483 URL: https://issues.apache.org/jira/browse/SOLR-14483 Project: Solr Issue Type: Bug

[jira] [Created] (SOLR-14484) NPE in ConcurrentUpdateHttp2SolrClient MDC logging

2020-05-14 Thread Andras Salamon (Jira)
Andras Salamon created SOLR-14484: - Summary: NPE in ConcurrentUpdateHttp2SolrClient MDC logging Key: SOLR-14484 URL: https://issues.apache.org/jira/browse/SOLR-14484 Project: Solr Issue Type:

[jira] [Updated] (SOLR-14484) NPE in ConcurrentUpdateHttp2SolrClient MDC logging

2020-05-14 Thread Andras Salamon (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andras Salamon updated SOLR-14484: -- Attachment: SOLR-14484-01.patch > NPE in ConcurrentUpdateHttp2SolrClient MDC logging >

[jira] [Updated] (SOLR-14484) NPE in ConcurrentUpdateHttp2SolrClient MDC logging

2020-05-14 Thread Andras Salamon (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andras Salamon updated SOLR-14484: -- Status: Patch Available (was: Open) > NPE in ConcurrentUpdateHttp2SolrClient MDC logging > ---

[GitHub] [lucene-solr] uschindler commented on pull request #1488: LUCENE-9321: Refactor renderJavadoc to allow relative links with multiple Gradle tasks

2020-05-14 Thread GitBox
uschindler commented on pull request #1488: URL: https://github.com/apache/lucene-solr/pull/1488#issuecomment-628494121 Hi, I did a small change: The tasks returned by resolving dependencies are *unsorted*. In case of split packages, the results of javadoc execution are therefore not re

[GitHub] [lucene-solr] uschindler edited a comment on pull request #1488: LUCENE-9321: Refactor renderJavadoc to allow relative links with multiple Gradle tasks

2020-05-14 Thread GitBox
uschindler edited a comment on pull request #1488: URL: https://github.com/apache/lucene-solr/pull/1488#issuecomment-628494121 Hi, I did a small change: The tasks returned by resolving dependencies are *unsorted*. In case of split packages, the results of javadoc execution are therefore

[GitHub] [lucene-solr] dweiss commented on pull request #1488: LUCENE-9321: Refactor renderJavadoc to allow relative links with multiple Gradle tasks

2020-05-14 Thread GitBox
dweiss commented on pull request #1488: URL: https://github.com/apache/lucene-solr/pull/1488#issuecomment-628495567 +1. This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [lucene-solr] markharwood merged pull request #1489: RegEx querying - add support for Java’s predefined character classes like \d for digits

2020-05-14 Thread GitBox
markharwood merged pull request #1489: URL: https://github.com/apache/lucene-solr/pull/1489 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [lucene-solr] markharwood opened a new pull request #1515: Lucene-9336: Changes.txt addition for RegExp enhancements

2020-05-14 Thread GitBox
markharwood opened a new pull request #1515: URL: https://github.com/apache/lucene-solr/pull/1515 9.0 enhancement added to changes This is an automated message from the Apache Git Service. To respond to the message, please lo

[jira] [Commented] (LUCENE-9336) RegExp.java - add support for character classes like \w

2020-05-14 Thread Mark Harwood (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107142#comment-17107142 ] Mark Harwood commented on LUCENE-9336: -- Fixed in https://github.com/apache/lucene-

[jira] [Resolved] (LUCENE-9336) RegExp.java - add support for character classes like \w

2020-05-14 Thread Mark Harwood (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Harwood resolved LUCENE-9336. -- Fix Version/s: master (9.0) Resolution: Fixed Fixed in https://github.com/apache/lucen

[jira] [Created] (LUCENE-9370) RegExpQuery should error for inappropriate use of \ character in input

2020-05-14 Thread Mark Harwood (Jira)
Mark Harwood created LUCENE-9370: Summary: RegExpQuery should error for inappropriate use of \ character in input Key: LUCENE-9370 URL: https://issues.apache.org/jira/browse/LUCENE-9370 Project: Lucen

[jira] [Commented] (LUCENE-9370) RegExpQuery should error for inappropriate use of \ character in input

2020-05-14 Thread Jim Ferenczi (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107169#comment-17107169 ] Jim Ferenczi commented on LUCENE-9370: -- +1 > RegExpQuery should error for inapprop

[GitHub] [lucene-solr] uschindler commented on pull request #1488: LUCENE-9321: Refactor renderJavadoc to allow relative links with multiple Gradle tasks

2020-05-14 Thread GitBox
uschindler commented on pull request #1488: URL: https://github.com/apache/lucene-solr/pull/1488#issuecomment-628550661 After comparing outputs I found out that the whole thing only worked with direct dependencies. Of course we rely only on render tasks of directly referenced projects. So

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1488: LUCENE-9321: Refactor renderJavadoc to allow relative links with multiple Gradle tasks

2020-05-14 Thread GitBox
dweiss commented on a change in pull request #1488: URL: https://github.com/apache/lucene-solr/pull/1488#discussion_r425045061 ## File path: gradle/render-javadoc.gradle ## @@ -151,6 +151,18 @@ class RenderJavadocTask extends DefaultTask { @Input def solrDocUrl = projec

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1488: LUCENE-9321: Refactor renderJavadoc to allow relative links with multiple Gradle tasks

2020-05-14 Thread GitBox
uschindler commented on a change in pull request #1488: URL: https://github.com/apache/lucene-solr/pull/1488#discussion_r425046908 ## File path: gradle/render-javadoc.gradle ## @@ -151,6 +151,18 @@ class RenderJavadocTask extends DefaultTask { @Input def solrDocUrl = pr

[GitHub] [lucene-solr] markharwood merged pull request #1515: Lucene-9336: Changes.txt addition for RegExp enhancements

2020-05-14 Thread GitBox
markharwood merged pull request #1515: URL: https://github.com/apache/lucene-solr/pull/1515 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [lucene-solr] uschindler commented on pull request #1488: LUCENE-9321: Refactor renderJavadoc to allow relative links with multiple Gradle tasks

2020-05-14 Thread GitBox
uschindler commented on pull request #1488: URL: https://github.com/apache/lucene-solr/pull/1488#issuecomment-628558810 I just noticed we have no CHANGES entry for Gradle at all. We should maybe add one for all. So I will merge this without adding a new changes entry. -

[jira] [Commented] (LUCENE-9370) RegExpQuery should error for inappropriate use of \ character in input

2020-05-14 Thread Mark Harwood (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107204#comment-17107204 ] Mark Harwood commented on LUCENE-9370: -- The [Java rules|https://docs.oracle.com/ja

[GitHub] [lucene-solr] uschindler merged pull request #1488: LUCENE-9321: Refactor renderJavadoc to allow relative links with multiple Gradle tasks

2020-05-14 Thread GitBox
uschindler merged pull request #1488: URL: https://github.com/apache/lucene-solr/pull/1488 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (LUCENE-9278) Make javadoc folder structure follow Gradle project path

2020-05-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107215#comment-17107215 ] ASF subversion and git services commented on LUCENE-9278: - Commi

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-05-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107214#comment-17107214 ] ASF subversion and git services commented on LUCENE-9321: - Commi

[GitHub] [lucene-solr] uschindler commented on pull request #1477: LUCENE-9321: Port markdown task to Gradle

2020-05-14 Thread GitBox
uschindler commented on pull request #1477: URL: https://github.com/apache/lucene-solr/pull/1477#issuecomment-628571533 I can now proceed with this one as #1488 is done. This is an automated message from the Apache Git Servic

[jira] [Commented] (SOLR-14484) NPE in ConcurrentUpdateHttp2SolrClient MDC logging

2020-05-14 Thread Lucene/Solr QA (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107235#comment-17107235 ] Lucene/Solr QA commented on SOLR-14484: --- | (x) *{color:red}-1 overall{color}* | \\

[GitHub] [lucene-solr] magibney commented on a change in pull request #1507: SOLR-14471: properly apply base replica ordering to last-place shards…

2020-05-14 Thread GitBox
magibney commented on a change in pull request #1507: URL: https://github.com/apache/lucene-solr/pull/1507#discussion_r425099741 ## File path: solr/solrj/src/test/org/apache/solr/client/solrj/routing/RequestReplicaListTransformerGeneratorTest.java ## @@ -88,6 +88,19 @@ public

[jira] [Created] (SOLR-14485) Fix or suppress 11 resource leak warnings in apache/solr/cloud

2020-05-14 Thread Andras Salamon (Jira)
Andras Salamon created SOLR-14485: - Summary: Fix or suppress 11 resource leak warnings in apache/solr/cloud Key: SOLR-14485 URL: https://issues.apache.org/jira/browse/SOLR-14485 Project: Solr

[jira] [Updated] (SOLR-14485) Fix or suppress 11 resource leak warnings in apache/solr/cloud

2020-05-14 Thread Andras Salamon (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andras Salamon updated SOLR-14485: -- Status: Patch Available (was: Open) > Fix or suppress 11 resource leak warnings in apache/solr

[jira] [Updated] (SOLR-14485) Fix or suppress 11 resource leak warnings in apache/solr/cloud

2020-05-14 Thread Andras Salamon (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andras Salamon updated SOLR-14485: -- Attachment: SOLR-14485-01.patch > Fix or suppress 11 resource leak warnings in apache/solr/clou

[jira] [Assigned] (SOLR-14485) Fix or suppress 11 resource leak warnings in apache/solr/cloud

2020-05-14 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson reassigned SOLR-14485: - Assignee: Erick Erickson > Fix or suppress 11 resource leak warnings in apache/solr/clou

[jira] [Updated] (SOLR-14478) Allow the diff Stream Evaluator to operate on the rows of a matrix

2020-05-14 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-14478: -- Attachment: Screen Shot 2020-05-14 at 8.54.07 AM.png > Allow the diff Stream Evaluator to opera

[jira] [Commented] (SOLR-14485) Fix or suppress 11 resource leak warnings in apache/solr/cloud

2020-05-14 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107273#comment-17107273 ] Erick Erickson commented on SOLR-14485: --- I'll take a look today/tomorrow. A very m

[jira] [Updated] (SOLR-14478) Allow the diff Stream Evaluator to operate on the rows of a matrix

2020-05-14 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-14478: -- Description: Currently the *diff* function performs *serial differencing* on a numeric vector.

[jira] [Updated] (SOLR-14478) Allow the diff Stream Evaluator to operate on the rows of a matrix

2020-05-14 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-14478: -- Description: Currently the *diff* function performs *serial differencing* on a numeric vector.

[GitHub] [lucene-solr] mocobeta commented on pull request #1488: LUCENE-9321: Refactor renderJavadoc to allow relative links with multiple Gradle tasks

2020-05-14 Thread GitBox
mocobeta commented on pull request #1488: URL: https://github.com/apache/lucene-solr/pull/1488#issuecomment-628629711 > Also, thanks for eyeballing the outputs with your keen eye, Tomoko. If I correctly understand the meaning of the phrase, my fellows occasionally say similar things

[jira] [Commented] (SOLR-14485) Fix or suppress 11 resource leak warnings in apache/solr/cloud

2020-05-14 Thread Andras Salamon (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107297#comment-17107297 ] Andras Salamon commented on SOLR-14485: --- Sure thing. I was following the Oozie nami

[jira] [Commented] (SOLR-14462) Autoscaling placement wrong with concurrent collection creations

2020-05-14 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107302#comment-17107302 ] Ilan Ginzburg commented on SOLR-14462: -- In existing (9.0 master) code as well as in

[jira] [Commented] (SOLR-14467) inconsistent server errors combining relatedness() with allBuckets:true

2020-05-14 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107321#comment-17107321 ] Michael Gibney commented on SOLR-14467: --- Hi Hoss, I've been looking into this (over

[jira] [Commented] (SOLR-14407) Handle shards.purpose in the postlogs tool

2020-05-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107324#comment-17107324 ] ASF subversion and git services commented on SOLR-14407: Commit f

[jira] [Commented] (SOLR-14478) Allow the diff Stream Evaluator to operate on the rows of a matrix

2020-05-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107325#comment-17107325 ] ASF subversion and git services commented on SOLR-14478: Commit f

[jira] [Commented] (SOLR-14485) Fix or suppress 11 resource leak warnings in apache/solr/cloud

2020-05-14 Thread Erick Erickson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107339#comment-17107339 ] Erick Erickson commented on SOLR-14485: --- Actually, I had time today and did a quick

[jira] [Commented] (SOLR-14329) Add support to choose field for expand component from multiple collapse groups

2020-05-14 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107348#comment-17107348 ] Cassandra Targett commented on SOLR-14329: -- [~munendrasn], this issue changed th

[GitHub] [lucene-solr] markharwood opened a new pull request #1516: Lucene 9370: Remove leniency on illegal backslashes in RegExp query

2020-05-14 Thread GitBox
markharwood opened a new pull request #1516: URL: https://github.com/apache/lucene-solr/pull/1516 This prevents illegal backslash syntax from user searches being accepted now and throws an error instead. This echoes the [Java Pattern policy](https://docs.oracle.com/javase/8/docs/api/jav

[jira] [Commented] (LUCENE-9370) RegExpQuery should error for inappropriate use of \ character in input

2020-05-14 Thread Mark Harwood (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107356#comment-17107356 ] Mark Harwood commented on LUCENE-9370: -- PR [here|https://github.com/apache/lucene-s

[jira] [Commented] (SOLR-14407) Handle shards.purpose in the postlogs tool

2020-05-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107358#comment-17107358 ] ASF subversion and git services commented on SOLR-14407: Commit 8

[jira] [Commented] (SOLR-14478) Allow the diff Stream Evaluator to operate on the rows of a matrix

2020-05-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107359#comment-17107359 ] ASF subversion and git services commented on SOLR-14478: Commit 0

[jira] [Updated] (SOLR-14407) Handle shards.purpose in the postlogs tool

2020-05-14 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-14407: -- Fix Version/s: 8.6 > Handle shards.purpose in the postlogs tool >

[jira] [Updated] (SOLR-14478) Allow the diff Stream Evaluator to operate on the rows of a matrix

2020-05-14 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-14478: -- Fix Version/s: 8.6 > Allow the diff Stream Evaluator to operate on the rows of a matrix > -

[jira] [Commented] (SOLR-14485) Fix or suppress 11 resource leak warnings in apache/solr/cloud

2020-05-14 Thread Andras Salamon (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107369#comment-17107369 ] Andras Salamon commented on SOLR-14485: --- I also prefer try-with-resources, on the o

[jira] [Commented] (SOLR-14407) Handle shards.purpose in the postlogs tool

2020-05-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107380#comment-17107380 ] ASF subversion and git services commented on SOLR-14407: Commit 0

[jira] [Commented] (SOLR-14478) Allow the diff Stream Evaluator to operate on the rows of a matrix

2020-05-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107381#comment-17107381 ] ASF subversion and git services commented on SOLR-14478: Commit 0

[jira] [Commented] (SOLR-14407) Handle shards.purpose in the postlogs tool

2020-05-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107383#comment-17107383 ] ASF subversion and git services commented on SOLR-14407: Commit a

[jira] [Commented] (SOLR-14478) Allow the diff Stream Evaluator to operate on the rows of a matrix

2020-05-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107384#comment-17107384 ] ASF subversion and git services commented on SOLR-14478: Commit a

[jira] [Updated] (SOLR-14485) Fix or suppress 11 resource leak warnings in apache/solr/cloud

2020-05-14 Thread Andras Salamon (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andras Salamon updated SOLR-14485: -- Attachment: SOLR-14485-01.patch > Fix or suppress 11 resource leak warnings in apache/solr/clou

[jira] [Commented] (SOLR-14485) Fix or suppress 11 resource leak warnings in apache/solr/cloud

2020-05-14 Thread Andras Salamon (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107385#comment-17107385 ] Andras Salamon commented on SOLR-14485: --- Uploaded a new patch (using the same filen

[GitHub] [lucene-solr] uschindler commented on pull request #1477: LUCENE-9321: Port markdown task to Gradle

2020-05-14 Thread GitBox
uschindler commented on pull request #1477: URL: https://github.com/apache/lucene-solr/pull/1477#issuecomment-628742753 Hi, I added a first implemntation of `index.html`: 8dca5bb (Lucene only) It works quite well: - I added a method that collects all sub-projects with a specific pa

[jira] [Created] (LUCENE-9371) Make RegExp internal state more visible to support more rendering formats

2020-05-14 Thread Mark Harwood (Jira)
Mark Harwood created LUCENE-9371: Summary: Make RegExp internal state more visible to support more rendering formats Key: LUCENE-9371 URL: https://issues.apache.org/jira/browse/LUCENE-9371 Project: Lu

[jira] [Commented] (SOLR-14426) forbidden api error during precommit DateMathFunction

2020-05-14 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107452#comment-17107452 ] Houston Putman commented on SOLR-14426: --- I agree that the static inner classes is a

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1477: LUCENE-9321: Port markdown task to Gradle

2020-05-14 Thread GitBox
uschindler commented on a change in pull request #1477: URL: https://github.com/apache/lucene-solr/pull/1477#discussion_r425286729 ## File path: gradle/documentation/documentation.gradle ## @@ -34,4 +36,11 @@ configure(subprojects.findAll { it.path == ':lucene' || it.path == '

[jira] [Commented] (SOLR-14485) Fix or suppress 11 resource leak warnings in apache/solr/cloud

2020-05-14 Thread Lucene/Solr QA (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107467#comment-17107467 ] Lucene/Solr QA commented on SOLR-14485: --- | (/) *{color:green}+1 overall{color}* | \

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1510: SOLR-14473: Improve Overseer Javadoc

2020-05-14 Thread GitBox
murblanc commented on a change in pull request #1510: URL: https://github.com/apache/lucene-solr/pull/1510#discussion_r425332349 ## File path: solr/core/src/java/org/apache/solr/cloud/ZkDistributedQueue.java ## @@ -51,9 +51,16 @@ import org.slf4j.LoggerFactory; /** - * A ZK

[jira] [Commented] (SOLR-14467) inconsistent server errors combining relatedness() with allBuckets:true

2020-05-14 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107525#comment-17107525 ] Chris M. Hostetter commented on SOLR-14467: --- {quote}I noticed that the test pat

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-05-14 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107528#comment-17107528 ] Tomoko Uchida commented on LUCENE-9321: --- It's a bit off-topic... can we apply a mi

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1510: SOLR-14473: Improve Overseer Javadoc

2020-05-14 Thread GitBox
murblanc commented on a change in pull request #1510: URL: https://github.com/apache/lucene-solr/pull/1510#discussion_r425336000 ## File path: solr/core/src/java/org/apache/solr/cloud/ZkDistributedQueue.java ## @@ -51,9 +51,16 @@ import org.slf4j.LoggerFactory; /** - * A ZK

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1510: SOLR-14473: Improve Overseer Javadoc

2020-05-14 Thread GitBox
murblanc commented on a change in pull request #1510: URL: https://github.com/apache/lucene-solr/pull/1510#discussion_r425337695 ## File path: solr/solrj/src/java/org/apache/solr/common/params/CollectionParams.java ## @@ -70,6 +70,19 @@ public boolean isHigherOrEqual(LockLevel

[jira] [Commented] (SOLR-13132) Improve JSON "terms" facet performance when sorted by relatedness

2020-05-14 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107549#comment-17107549 ] Chris M. Hostetter commented on SOLR-13132: --- {quote}I did the work on this bran

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1477: LUCENE-9321: Port markdown task to Gradle

2020-05-14 Thread GitBox
dweiss commented on a change in pull request #1477: URL: https://github.com/apache/lucene-solr/pull/1477#discussion_r425355108 ## File path: gradle/documentation/markdown.gradle ## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [lucene-solr] dweiss commented on pull request #1477: LUCENE-9321: Port markdown task to Gradle

2020-05-14 Thread GitBox
dweiss commented on pull request #1477: URL: https://github.com/apache/lucene-solr/pull/1477#issuecomment-628820984 bq. Should I simple add a project.description to all .gradle files, so it's consistent with Ant? Hmm... What do you mean by adding project.description? We don't need to

[GitHub] [lucene-solr] madrob commented on a change in pull request #1509: SOLR-10810: Examine precommit lint WARNINGs in non-test code

2020-05-14 Thread GitBox
madrob commented on a change in pull request #1509: URL: https://github.com/apache/lucene-solr/pull/1509#discussion_r425360430 ## File path: solr/core/src/java/org/apache/solr/handler/AnalysisRequestHandlerBase.java ## @@ -82,7 +82,7 @@ public void handleRequestBody(SolrQueryR

[GitHub] [lucene-solr] uschindler commented on pull request #1477: LUCENE-9321: Port markdown task to Gradle

2020-05-14 Thread GitBox
uschindler commented on pull request #1477: URL: https://github.com/apache/lucene-solr/pull/1477#issuecomment-628832740 The title and metadata of a project should IMHO be part of project's gradle file. You just add a `description = "..."` next to the dependencies, an done. Is this OK to yo

[GitHub] [lucene-solr] uschindler commented on pull request #1477: LUCENE-9321: Port markdown task to Gradle

2020-05-14 Thread GitBox
uschindler commented on pull request #1477: URL: https://github.com/apache/lucene-solr/pull/1477#issuecomment-628833244 > I guess this description will come in handy for maven artifact (pom) as well. Yes, there it's public and searchable in e.g., search.maven.org --

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-05-14 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107579#comment-17107579 ] Uwe Schindler commented on LUCENE-9321: --- bq. See markdown task. It extracts first

[jira] [Comment Edited] (LUCENE-9321) Port documentation task to gradle

2020-05-14 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107579#comment-17107579 ] Uwe Schindler edited comment on LUCENE-9321 at 5/14/20, 7:11 PM: -

[GitHub] [lucene-solr] dweiss commented on pull request #1477: LUCENE-9321: Port markdown task to Gradle

2020-05-14 Thread GitBox
dweiss commented on pull request #1477: URL: https://github.com/apache/lucene-solr/pull/1477#issuecomment-628834560 I don't mind either way. Can be per-project gradle file. Seems to fit there nicely. This is an automated mes

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1477: LUCENE-9321: Port markdown task to Gradle

2020-05-14 Thread GitBox
uschindler commented on a change in pull request #1477: URL: https://github.com/apache/lucene-solr/pull/1477#discussion_r425371129 ## File path: gradle/documentation/markdown.gradle ## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[jira] [Created] (SOLR-14486) Autoscaling simulation framework should stop using /clusterstate.json

2020-05-14 Thread Andrzej Bialecki (Jira)
Andrzej Bialecki created SOLR-14486: --- Summary: Autoscaling simulation framework should stop using /clusterstate.json Key: SOLR-14486 URL: https://issues.apache.org/jira/browse/SOLR-14486 Project: So

[jira] [Commented] (SOLR-12823) remove clusterstate.json in Lucene/Solr 8.0

2020-05-14 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107591#comment-17107591 ] Andrzej Bialecki commented on SOLR-12823: - [~murblanc] I created SOLR-14486 to fi

[GitHub] [lucene-solr] dweiss commented on a change in pull request #1477: LUCENE-9321: Port markdown task to Gradle

2020-05-14 Thread GitBox
dweiss commented on a change in pull request #1477: URL: https://github.com/apache/lucene-solr/pull/1477#discussion_r425375832 ## File path: gradle/documentation/markdown.gradle ## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [lucene-solr] uschindler commented on a change in pull request #1477: LUCENE-9321: Port markdown task to Gradle

2020-05-14 Thread GitBox
uschindler commented on a change in pull request #1477: URL: https://github.com/apache/lucene-solr/pull/1477#discussion_r425384992 ## File path: gradle/documentation/markdown.gradle ## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[jira] [Commented] (SOLR-13289) Support for BlockMax WAND

2020-05-14 Thread Gregg Donovan (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107615#comment-17107615 ] Gregg Donovan commented on SOLR-13289: -- We've been using [ExternalFileField|https:/

[jira] [Commented] (SOLR-14486) Autoscaling simulation framework should stop using /clusterstate.json

2020-05-14 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107653#comment-17107653 ] Ilan Ginzburg commented on SOLR-14486: -- Thanks [~ab] for creating this. I will keep

[GitHub] [lucene-solr] murblanc commented on a change in pull request #1510: SOLR-14473: Improve Overseer Javadoc

2020-05-14 Thread GitBox
murblanc commented on a change in pull request #1510: URL: https://github.com/apache/lucene-solr/pull/1510#discussion_r425412381 ## File path: solr/core/src/java/org/apache/solr/cloud/ZkDistributedQueue.java ## @@ -51,9 +51,16 @@ import org.slf4j.LoggerFactory; /** - * A ZK

[jira] [Updated] (LUCENE-9328) SortingGroupHead to reuse DocValues

2020-05-14 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev updated LUCENE-9328: - Attachment: LUCENE-9328.patch Status: Patch Available (was: Patch Available) >

[jira] [Commented] (LUCENE-9371) Make RegExp internal state more visible to support more rendering formats

2020-05-14 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107659#comment-17107659 ] Michael McCandless commented on LUCENE-9371: +1 > Make RegExp internal stat

[jira] [Commented] (LUCENE-9365) Fuzzy query has a false negative when prefix length == search term length

2020-05-14 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107662#comment-17107662 ] Michael McCandless commented on LUCENE-9365: If that really fixes this corne

[jira] [Commented] (LUCENE-9328) SortingGroupHead to reuse DocValues

2020-05-14 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107668#comment-17107668 ] Mikhail Khludnev commented on LUCENE-9328: -- Finally, after sneaking [~romseygee

[GitHub] [lucene-solr] tflobbe opened a new pull request #1517: SOLR-13289: Use the final collector's scoreMode

2020-05-14 Thread GitBox
tflobbe opened a new pull request #1517: URL: https://github.com/apache/lucene-solr/pull/1517 Fixes a bug @dsmiley pointed out to in [SOLR-13289](https://issues.apache.org/jira/browse/SOLR-13289?focusedCommentId=17103601&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#

[GitHub] [lucene-solr] ErickErickson opened a new pull request #1518: SOLR-14482: Fix compile-time warnings in solr/core/search/facet

2020-05-14 Thread GitBox
ErickErickson opened a new pull request #1518: URL: https://github.com/apache/lucene-solr/pull/1518 The facet code has a _lot_ of classes declared in a file with a different name. This tries to fix all the warnings in solr/core/search/facet. gradlew check passes. Here for comments.

[jira] [Resolved] (SOLR-14407) Handle shards.purpose in the postlogs tool

2020-05-14 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein resolved SOLR-14407. --- Resolution: Resolved > Handle shards.purpose in the postlogs tool >

[jira] [Resolved] (SOLR-14478) Allow the diff Stream Evaluator to operate on the rows of a matrix

2020-05-14 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein resolved SOLR-14478. --- Resolution: Resolved > Allow the diff Stream Evaluator to operate on the rows of a matrix > -

[GitHub] [lucene-solr] uschindler commented on pull request #1477: LUCENE-9321: Port markdown task to Gradle

2020-05-14 Thread GitBox
uschindler commented on pull request #1477: URL: https://github.com/apache/lucene-solr/pull/1477#issuecomment-628929672 I pushed a first mockup using Groovy's `SimpleTemplateEngine`. This is an automated message from the Apac

[GitHub] [lucene-solr] madrob commented on pull request #1518: SOLR-14482: Fix compile-time warnings in solr/core/search/facet

2020-05-14 Thread GitBox
madrob commented on pull request #1518: URL: https://github.com/apache/lucene-solr/pull/1518#issuecomment-628941414 Uhh... @ErickErickson I think you're missing your changes? There's nothing there under "Files Changed" This

[GitHub] [lucene-solr] megancarey commented on a change in pull request #1504: SOLR-14462: cache more than one autoscaling session

2020-05-14 Thread GitBox
megancarey commented on a change in pull request #1504: URL: https://github.com/apache/lucene-solr/pull/1504#discussion_r425424095 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/PolicyHelper.java ## @@ -382,45 +383,55 @@ static MapWriter loggi

[jira] [Commented] (LUCENE-9321) Port documentation task to gradle

2020-05-14 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107802#comment-17107802 ] Tomoko Uchida commented on LUCENE-9321: --- Yes. I come up with the idea as I saw how

[jira] [Updated] (SOLR-14477) relatedness() values can be wrong when using 'prefix'

2020-05-14 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-14477: -- Attachment: SOLR-14477.patch Status: Open (was: Open) patch updated with TestC

[jira] [Commented] (LUCENE-9328) SortingGroupHead to reuse DocValues

2020-05-14 Thread Lucene/Solr QA (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107817#comment-17107817 ] Lucene/Solr QA commented on LUCENE-9328: | (/) *{color:green}+1 overall{color}*

[GitHub] [lucene-solr] mbwaheed commented on a change in pull request #1430: SOLR-13101: SHARED replica's distributed indexing

2020-05-14 Thread GitBox
mbwaheed commented on a change in pull request #1430: URL: https://github.com/apache/lucene-solr/pull/1430#discussion_r425514283 ## File path: solr/core/src/java/org/apache/solr/update/processor/DistributedZkUpdateProcessor.java ## @@ -114,16 +104,29 @@ private RollupReques

[GitHub] [lucene-solr] mbwaheed commented on a change in pull request #1430: SOLR-13101: SHARED replica's distributed indexing

2020-05-14 Thread GitBox
mbwaheed commented on a change in pull request #1430: URL: https://github.com/apache/lucene-solr/pull/1430#discussion_r425514716 ## File path: solr/core/src/java/org/apache/solr/update/processor/DistributedZkUpdateProcessor.java ## @@ -114,16 +104,29 @@ private RollupReques

[GitHub] [lucene-solr] mbwaheed commented on a change in pull request #1430: SOLR-13101: SHARED replica's distributed indexing

2020-05-14 Thread GitBox
mbwaheed commented on a change in pull request #1430: URL: https://github.com/apache/lucene-solr/pull/1430#discussion_r425517306 ## File path: solr/core/src/java/org/apache/solr/update/processor/DistributedZkUpdateProcessor.java ## @@ -184,6 +186,30 @@ public void processCommi

[GitHub] [lucene-solr] mbwaheed commented on a change in pull request #1430: SOLR-13101: SHARED replica's distributed indexing

2020-05-14 Thread GitBox
mbwaheed commented on a change in pull request #1430: URL: https://github.com/apache/lucene-solr/pull/1430#discussion_r425522694 ## File path: solr/core/src/java/org/apache/solr/update/processor/DistributedZkUpdateProcessor.java ## @@ -184,6 +186,30 @@ public void processCommi

  1   2   >