Andras Salamon created SOLR-14485:
-------------------------------------
Summary: Fix or suppress 11 resource leak warnings in
apache/solr/cloud
Key: SOLR-14485
URL: https://issues.apache.org/jira/browse/SOLR-14485
Project: Solr
Issue Type: Sub-task
Reporter: Andras Salamon
There are 11 warnings in apache/solr/cloud:
{noformat}
[ecj-lint] 2. WARNING in
/Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/RecoveryStrategy.java
(at line 644)
[ecj-lint] PeerSyncWithLeader peerSyncWithLeader = new
PeerSyncWithLeader(core,
[ecj-lint] ^^^^^^^^^^^^^^^^^^
[ecj-lint] Resource leak: 'peerSyncWithLeader' is never closed
--
[ecj-lint] 3. WARNING in
/Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/SyncStrategy.java
(at line 182)
[ecj-lint] PeerSync peerSync = new PeerSync(core, syncWith,
core.getUpdateHandler().getUpdateLog().getNumRecordsToKeep(), true,
peerSyncOnlyWithActive, false);
[ecj-lint] ^^^^^^^^
[ecj-lint] Resource leak: 'peerSync' is never closed
--
[ecj-lint] 4. WARNING in
/Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimCloudManager.java
(at line 793)
[ecj-lint] throw new UnsupportedOperationException("must add at least 1
node first");
[ecj-lint]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ecj-lint] Resource leak: 'queryRequest' is not closed at this location
--
[ecj-lint] 5. WARNING in
/Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimCloudManager.java
(at line 799)
[ecj-lint] throw new UnsupportedOperationException("must add at least 1
node first");
[ecj-lint]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ecj-lint] Resource leak: 'queryRequest' is not closed at this location
--
[ecj-lint] 6. WARNING in
/Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimScenario.java
(at line 408)
[ecj-lint] SnapshotCloudManager snapshotCloudManager = new
SnapshotCloudManager(scenario.cluster, null);
[ecj-lint] ^^^^^^^^^^^^^^^^^^^^
[ecj-lint] Resource leak: 'snapshotCloudManager' is never closed
--
[ecj-lint] 7. WARNING in
/Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimScenario.java
(at line 743)
[ecj-lint] throw new IOException("currently only one listener can be set
per trigger. Trigger name: " + trigger);
[ecj-lint]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ecj-lint] Resource leak: 'listener' is not closed at this location
--
[ecj-lint] 8. WARNING in
/Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimScenario.java
(at line 952)
[ecj-lint] SnapshotCloudManager snapshotCloudManager = new
SnapshotCloudManager(scenario.cluster, null);
[ecj-lint] ^^^^^^^^^^^^^^^^^^^^
[ecj-lint] Resource leak: 'snapshotCloudManager' is never closed
--
[ecj-lint] 9. WARNING in
/Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/java/org/apache/solr/cloud/autoscaling/sim/SimScenario.java
(at line 991)
[ecj-lint] SimScenario scenario = new SimScenario();
[ecj-lint] ^^^^^^^^
[ecj-lint] Resource leak: 'scenario' is never closed
--
[ecj-lint] 1. WARNING in
/Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/test/org/apache/solr/cloud/ChaosMonkeyShardSplitTest.java
(at line 264)
[ecj-lint] Overseer overseer = new Overseer((HttpShardHandler) new
HttpShardHandlerFactory().getShardHandler(), updateShardHandler, "/admin/cores",
[ecj-lint]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ecj-lint] Resource leak: '<unassigned Closeable value>' is never closed
--
[ecj-lint] 2. WARNING in
/Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/test/org/apache/solr/cloud/ZkNodePropsTest.java
(at line 48)
[ecj-lint] new JavaBinCodec().marshal(zkProps.getProperties(), baos);
[ecj-lint] ^^^^^^^^^^^^^^^^^^
[ecj-lint] Resource leak: '<unassigned Closeable value>' is never closed
--
[ecj-lint] 3. WARNING in
/Users/andrassalamon/src/lucene-solr-upstream/solr/core/src/test/org/apache/solr/cloud/autoscaling/sim/TestSnapshotCloudManager.java
(at line 124)
[ecj-lint] SnapshotCloudManager snapshotCloudManager = new
SnapshotCloudManager(realManager, null);
[ecj-lint] ^^^^^^^^^^^^^^^^^^^^
[ecj-lint] Resource leak: 'snapshotCloudManager' is never closed
{noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
