uschindler commented on pull request #1488: URL: https://github.com/apache/lucene-solr/pull/1488#issuecomment-628550661
After comparing outputs I found out that the whole thing only worked with direct dependencies. Of course we rely only on render tasks of directly referenced projects. So `:solr:core` depends on lots of Lucene stuff and all this is rendered before. This setup works perfectly. But when we add the `-link` the previous code only searched for renderJavadoc tasks that were direct dependenencies. So Solr contribs were not adding all of lucene, because most Solr contribs nly depend on Solr core. Of course the Javadocs were created before, but we missed them. I added a new method to the task, that finds all previous render tasks (recursively). The code in the main logic is now also more readable (we just sort the retun value and add links). Now everything works as expected, I will merge this PR soon. Thanks @dweiss and @mocobeta for help! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
