[
https://issues.apache.org/jira/browse/SOLR-14467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17107321#comment-17107321
]
Michael Gibney commented on SOLR-14467:
---------------------------------------
Hi Hoss, I've been looking into this (over at SOLR-13132), but I noticed that
the test patch attached here only removes the {{TestCloudJSONFacetSKG.java}}
file from master, and doesn't add any tests?
I also have a more general question about the semantics of {{allBuckets}}.
>From the ref guide:
{quote}A boolean. If true, adds an “allBuckets” bucket to the response,
representing the union of all of the buckets. For multi-valued fields, this is
different than a bucket for all of the documents in the domain since a single
document can belong to multiple buckets. Defaults to false.
{quote}
The ref guide docs for {{allBuckets}} seem ambiguous to me wrt whether
{{allBuckets}} represents the union of all buckets across the full domain, or
the union of all _returned_ buckets. For the latter, {{allBuckets}} stats would
be inconsistent across different settings of {{limit}} for deferred stats, but
consistent for non-deferred ({{collectAcc}}) stats. My initial intuition is
that having stats for {{allBuckets}} represent the union across all buckets
(whether returned or not) would be preferable, but I think that would mean
preventing _any_ deferral of stats when {{allBuckets==true}}, which is not
currently done. But I think that approach (if chosen) would be pretty
straightforward: if {{allBuckets==true}}, instead of creating any
{{otherAccs}}, simply add all accs to {{collectAcc}} using {{MultiAcc}}?
> inconsistent server errors combining relatedness() with allBuckets:true
> -----------------------------------------------------------------------
>
> Key: SOLR-14467
> URL: https://issues.apache.org/jira/browse/SOLR-14467
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Facet Module
> Reporter: Chris M. Hostetter
> Priority: Major
> Attachments: SOLR-14467_test.patch
>
>
> While working on randomized testing for SOLR-13132 i discovered a variety of
> different ways that JSON Faceting's "allBuckets" option can fail when
> combined with the "relatedness()" function.
> I haven't found a trivial way to manual reproduce this, but i have been able
> to trigger the failures with a trivial patch to {{TestCloudJSONFacetSKG}}
> which i will attach.
> Based on the nature of the failures it looks like it may have something to do
> with multiple segments of different sizes, and or resizing the SlotAccs ?
> The relatedness() function doesn't have much (any?) existing tests in place
> that leverage "allBuckets" so this is probably a bug that has always existed
> -- it's possible it may be excessively cumbersome to fix and we might
> nee/wnat to just document that incompatibility and add some code to try and
> detect if the user combines these options and if so fail with a 400 error?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
