mbwaheed commented on a change in pull request #1430:
URL: https://github.com/apache/lucene-solr/pull/1430#discussion_r425522694
##########
File path:
solr/core/src/java/org/apache/solr/update/processor/DistributedZkUpdateProcessor.java
##########
@@ -184,6 +186,30 @@ public void processCommit(CommitUpdateCommand cmd) throws
IOException {
updateCommand = cmd;
+ // 1. SHARED replica has a hard requirement of processing each indexing
batch with a hard commit(either explicit or
+ // implicit, HttpSolrCall#addCommitIfAbsent) because that is how, at the
end of an indexing batch, synchronous push
+ // to shared store gets hold of the segment files on local disk. SHARED
replica also does not support the notion of soft commit.
+ // Therefore unlike NRT replica type we do not need to broadcast commit to
the leaders of all the shards of a collection.
Review comment:
Correct. Former is not needed because isolated commit is a no-op for
SHARED replica and later is not supported because SHARED replica has a
different plan around opening of searchers
https://issues.apache.org/jira/browse/SOLR-14339
I have updated the comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
