javanna commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1760911695
##
lucene/facet/src/java/org/apache/lucene/facet/FacetsCollector.java:
##
@@ -97,12 +97,12 @@ public List getMatchingDocs() {
public void collect(int doc) throws IO
javanna commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1760803091
##
lucene/core/src/java/org/apache/lucene/search/BulkScorer.java:
##
@@ -27,18 +27,6 @@
*/
public abstract class BulkScorer {
- /**
- * Scores and collects all
javanna commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1759746984
##
lucene/core/src/java/org/apache/lucene/search/BulkScorer.java:
##
@@ -27,18 +27,6 @@
*/
public abstract class BulkScorer {
- /**
- * Scores and collects all
jpountz commented on PR #13542:
URL: https://github.com/apache/lucene/pull/13542#issuecomment-2344646930
> have we marked these APIs as @lucene.internal?
No indeed, but we have been effectively treating them as unstable API for as
long as I've been a committer on this project. Would b
gsmiller commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1754432439
##
lucene/facet/src/java/org/apache/lucene/facet/FacetsCollector.java:
##
@@ -97,12 +97,12 @@ public List getMatchingDocs() {
public void collect(int doc) throws I
javanna merged PR #13542:
URL: https://github.com/apache/lucene/pull/13542
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
javanna commented on PR #13542:
URL: https://github.com/apache/lucene/pull/13542#issuecomment-2342018120
Thanks all for the feedback and reviews! The journey only begins as this PR
is getting merged, looking forward to making intra-segment concurrency support
shine soon :)
--
This is an
reta commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1752702414
##
lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java:
##
@@ -233,7 +235,13 @@ public IndexSearcher(IndexReaderContext context, Executor
executor) {
javanna commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1752702691
##
lucene/facet/src/test/org/apache/lucene/facet/TestDrillSideways.java:
##
@@ -142,7 +142,7 @@ protected Facets buildFacetsResult(
private IndexSearcher getNewSear
reta commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1752230454
##
lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java:
##
@@ -233,7 +235,13 @@ public IndexSearcher(IndexReaderContext context, Executor
executor) {
mikemccand commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1751974584
##
lucene/core/src/java/org/apache/lucene/search/TotalHitCountCollectorManager.java:
##
@@ -28,17 +36,114 @@
*/
public class TotalHitCountCollectorManager
i
javanna commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1750743766
##
lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java:
##
@@ -363,7 +374,88 @@ public static LeafSlice[] slices(
LeafSlice[] slices = new LeafSlice[
javanna commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1750711025
##
lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java:
##
@@ -363,7 +374,88 @@ public static LeafSlice[] slices(
LeafSlice[] slices = new LeafSlice[
javanna commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1750502348
##
lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java:
##
@@ -363,7 +374,88 @@ public static LeafSlice[] slices(
LeafSlice[] slices = new LeafSlice[
javanna commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1750500023
##
lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java:
##
@@ -363,7 +374,88 @@ public static LeafSlice[] slices(
LeafSlice[] slices = new LeafSlice[
mikemccand commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1750413448
##
lucene/MIGRATE.md:
##
@@ -802,5 +802,35 @@ both `TopDocs` as well as facets results included in a
reduced `FacetsCollector`
### `SearchWithCollectorTask` no
javanna commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1749979372
##
lucene/core/src/test/org/apache/lucene/index/TestForTooMuchCloning.java:
##
@@ -80,7 +80,7 @@ public void test() throws Exception {
// System.out.println("quer
javanna commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1749750973
##
lucene/core/src/java/org/apache/lucene/search/BulkScorer.java:
##
@@ -27,18 +27,6 @@
*/
public abstract class BulkScorer {
- /**
- * Scores and collects all
msokolov commented on PR #13542:
URL: https://github.com/apache/lucene/pull/13542#issuecomment-2334328695
Adding a new optional constructor makes sense to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
javanna commented on PR #13542:
URL: https://github.com/apache/lucene/pull/13542#issuecomment-2332571178
> I think we could keep it simple and provide a separate collector manager
perhaps that supports intra-segment concurrency for now
Having thought a little more, I am not sure this
msokolov commented on PR #13542:
URL: https://github.com/apache/lucene/pull/13542#issuecomment-2332479198
Thanks for the testing, @javanna! Indeed it is clear that this change does
*something* and could be useful as-is for some query loads. I'm also encouraged
by Adrien's comments. Although
javanna commented on PR #13542:
URL: https://github.com/apache/lucene/pull/13542#issuecomment-2332114836
Hey all, I have done some benchmarking with two main goals:
1) ensure there are no regressions introduced by the proposed change
2) ensure there is some performance gain when i
msokolov commented on PR #13542:
URL: https://github.com/apache/lucene/pull/13542#issuecomment-2329642279
> I don't entirely follow how we may have painted ourselves in a corner and
how running benchmarks relates to this.
They're not related; perhaps I should have broken my comment i
javanna commented on PR #13542:
URL: https://github.com/apache/lucene/pull/13542#issuecomment-2329387884
Perhaps one thing to add is that the main focus/direction of this change is
to set the foundations to be able to finally decouple the index geometry from
how the search is run and can be
javanna commented on PR #13542:
URL: https://github.com/apache/lucene/pull/13542#issuecomment-2329360505
> I think it's important at least to ensure that we "do no harm" to the
existing use cases.
Intra-segment is not enabled by default and requires additional work. The
scope of this
javanna commented on PR #13542:
URL: https://github.com/apache/lucene/pull/13542#issuecomment-2329216197
> Do we have any benchmark results? I'm curious to see what's gotten faster.
No. I focused on functionality. I wonder if it makes sense to run benchmarks
before we address the dupl
stefanvodita commented on PR #13542:
URL: https://github.com/apache/lucene/pull/13542#issuecomment-2329194920
Do we have any benchmark results? I'm curious to see what's gotten faster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
javanna commented on PR #13542:
URL: https://github.com/apache/lucene/pull/13542#issuecomment-2328473802
This is ready for a final review. I have no further outstanding items to
look into. I added some entries to the migrate file, changes entry and updated
description above to be aligned wi
javanna commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1743463027
##
lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java:
##
@@ -890,11 +945,70 @@ public static class LeafSlice {
*
* @lucene.experimental
javanna commented on PR #13542:
URL: https://github.com/apache/lucene/pull/13542#issuecomment-2326200273
I have lowered the number of partitions we may end up creating in tests per
segment to `5`, as we could end up with thousands of those. That improves GC
issues with `TestBoolean2`, but o
javanna commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1741835108
##
lucene/core/src/java/org/apache/lucene/search/TotalHitCountCollectorManager.java:
##
@@ -28,17 +31,77 @@
*/
public class TotalHitCountCollectorManager
imple
javanna commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1741216982
##
lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java:
##
@@ -732,7 +842,11 @@ private void search(
* @param collector to receive hits
* @throws
javanna commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1741216647
##
lucene/core/src/java/org/apache/lucene/search/BulkScorer.java:
##
@@ -27,18 +27,6 @@
*/
public abstract class BulkScorer {
- /**
- * Scores and collects all
javanna commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1741216330
##
lucene/test-framework/src/java/org/apache/lucene/tests/search/ScorerIndexSearcher.java:
##
@@ -76,4 +77,14 @@ protected void search(List leaves, Weight
weight, Col
javanna commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1741215790
##
lucene/core/src/java/org/apache/lucene/search/TotalHitCountCollectorManager.java:
##
@@ -28,17 +31,77 @@
*/
public class TotalHitCountCollectorManager
imple
javanna commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1740601737
##
lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java:
##
@@ -890,11 +945,70 @@ public static class LeafSlice {
*
* @lucene.experimental
javanna commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1732759669
##
lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java:
##
@@ -890,11 +945,70 @@ public static class LeafSlice {
*
* @lucene.experimental
javanna commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1731284306
##
lucene/core/src/test/org/apache/lucene/search/TestIndexSearcher.java:
##
@@ -293,4 +297,33 @@ public void testNullExecutorNonNullTaskExecutor() {
IndexSearcher
javanna commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1731282471
##
lucene/core/src/test/org/apache/lucene/index/TestForTooMuchCloning.java:
##
@@ -80,7 +80,7 @@ public void test() throws Exception {
// System.out.println("quer
javanna commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1731280867
##
lucene/core/src/java/org/apache/lucene/search/TotalHitCountCollectorManager.java:
##
@@ -28,17 +31,77 @@
*/
public class TotalHitCountCollectorManager
imple
javanna commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1731275591
##
lucene/core/src/java/org/apache/lucene/search/TotalHitCountCollectorManager.java:
##
@@ -28,17 +31,77 @@
*/
public class TotalHitCountCollectorManager
imple
javanna commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1731273966
##
lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java:
##
@@ -1024,10 +1138,50 @@ public LeafSlice[] get() {
leafSlices =
O
javanna commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1731271557
##
lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java:
##
@@ -890,11 +945,70 @@ public static class LeafSlice {
*
* @lucene.experimental
javanna commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1731253793
##
lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java:
##
@@ -890,11 +945,70 @@ public static class LeafSlice {
*
* @lucene.experimental
javanna commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1731251488
##
lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java:
##
@@ -890,11 +945,70 @@ public static class LeafSlice {
*
* @lucene.experimental
javanna commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1731244280
##
lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java:
##
@@ -890,11 +945,70 @@ public static class LeafSlice {
*
Review Comment:
I mostly had
original-brownbear commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1731131293
##
lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java:
##
@@ -890,11 +945,70 @@ public static class LeafSlice {
*
* @lucene.experi
original-brownbear commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1731119841
##
lucene/core/src/java/org/apache/lucene/search/TotalHitCountCollectorManager.java:
##
@@ -28,17 +31,77 @@
*/
public class TotalHitCountCollectorManager
github-actions[bot] commented on PR #13542:
URL: https://github.com/apache/lucene/pull/13542#issuecomment-2295040060
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
zhaih commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1702166806
##
lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java:
##
@@ -890,11 +945,70 @@ public static class LeafSlice {
*
* @lucene.experimental
msokolov commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1698819127
##
lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java:
##
@@ -328,42 +336,65 @@ protected LeafSlice[] slices(List
leaves) {
/** Static method to seg
msokolov commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1698819127
##
lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java:
##
@@ -328,42 +336,65 @@ protected LeafSlice[] slices(List
leaves) {
/** Static method to seg
stefanvodita commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1698485404
##
lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java:
##
@@ -328,42 +336,65 @@ protected LeafSlice[] slices(List
leaves) {
/** Static method to
jpountz commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1698394566
##
lucene/core/src/test/org/apache/lucene/search/TestIndexSearcher.java:
##
@@ -293,4 +297,33 @@ public void testNullExecutorNonNullTaskExecutor() {
IndexSearcher
javanna commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1697317194
##
lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java:
##
@@ -328,42 +336,65 @@ protected LeafSlice[] slices(List
leaves) {
/** Static method to segr
55 matches
Mail list logo
