javanna commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1741216330
##########
lucene/test-framework/src/java/org/apache/lucene/tests/search/ScorerIndexSearcher.java:
##########
@@ -76,4 +77,14 @@ protected void search(List<LeafReaderContext> leaves, Weight
weight, Collector c
}
}
}
+
+ @Override
+ protected void search(LeafReaderContextPartition[] leaves, Weight weight,
Collector collector)
+ throws IOException {
+ // TODO we should probably update this
+ search(
+ Arrays.stream(leaves).map(leafReaderContextSlice ->
leafReaderContextSlice.ctx).toList(),
+ weight,
+ collector);
Review Comment:
I added a check that verifies that only entire segments are scored using
this search subclass. This is to cover potential existing subclasses of it. We
have no such scenario in our own codebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
