reta commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1752230454
##########
lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java:
##########
@@ -233,7 +235,13 @@ public IndexSearcher(IndexReaderContext context, Executor
executor) {
? leaves ->
leaves.isEmpty()
? new LeafSlice[0]
- : new LeafSlice[] {new LeafSlice(new ArrayList<>(leaves))}
+ : new LeafSlice[] {
+ new LeafSlice(
+ new ArrayList<>(
Review Comment:
We probably could use the immutable list without allocating `new ArrayList`?
```suggestion
leaves.stream()
.map(LeafReaderContextPartition::createForEntireSegment)
.toList())
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
