javanna commented on PR #13542: URL: https://github.com/apache/lucene/pull/13542#issuecomment-2332571178
> I think we could keep it simple and provide a separate collector manager perhaps that supports intra-segment concurrency for now Having thought a little more, I am not sure this is a good idea. The first problem I have with it is naming, what would we call this other collector manager? :) We could otherwise add a constructor to the existing collector manager that takes the slices as an argument. Not very clean, but would allow the manager to go through the slices and determine what collector impl to return once `newCollector `is called later. We could make this new constructor optional, and leave the default constructor untouched for now (when created through it the manager won't support intra-segment concurrency), so we don't break existing usages. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
