javanna commented on code in PR #13542:
URL: https://github.com/apache/lucene/pull/13542#discussion_r1759746984
##########
lucene/core/src/java/org/apache/lucene/search/BulkScorer.java:
##########
@@ -27,18 +27,6 @@
*/
public abstract class BulkScorer {
- /**
- * Scores and collects all matching documents.
- *
- * @param collector The collector to which all matching documents are passed.
- * @param acceptDocs {@link Bits} that represents the allowed documents to
match, or {@code null}
- * if they are all allowed to match.
- */
- public void score(LeafCollector collector, Bits acceptDocs) throws
IOException {
Review Comment:
@jpountz I've been going back and forth on this a few times. Ideally we
would deprecate the method in 9x and give users some notice. It is rather easy
to remove usages and deprecate, I only worry about possible custom
implementations of the method, because it is not final and subclasses can
entirely override its behaviour. Such overrides would be a no-op if we replace
all the usages of the deprecated method in 9x, which feels like it breaks stuff
potentially. Users would need to immediately switch to overriding the other
method instead. If we leave the main usage (IndexSearcher#searchLeaf) behind
though, it feels odd that we use a deprecated method in such a core part of
search.
I am a bit torn on how to proceed, do you have an opinion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
