msokolov commented on PR #13542: URL: https://github.com/apache/lucene/pull/13542#issuecomment-2332479198
Thanks for the testing, @javanna! Indeed it is clear that this change does *something* and could be useful as-is for some query loads. I'm also encouraged by Adrien's comments. Although ideally I would have preferred to see us get to a really good place, I get the PNP argument, and appreciate that we don't want to do everything all at once. Regarding the small regression due to the collector overhead, I wonder if it would be possible to create some kind of coupling between Collector and IndexSearcher such that the Collector can assert that it is to be used with an IndexSearcher that "enables cross-segment concurrency". Then it would be up to the user to select the proper Collector (or collector option) to use with the IndexSearcher they have configured. Or perhaps IndexSearcher could be a Collector factory? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
