dweiss commented on PR #11971:
URL: https://github.com/apache/lucene/pull/11971#issuecomment-1326008603
Excellent improvement, btw.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
dweiss commented on PR #11971:
URL: https://github.com/apache/lucene/pull/11971#issuecomment-1326008327
From that link:
> There are a couple of checks that -XepDisableAllChecks doesn't disable
LOL. Of course, why would it work as the name suggests... ;)
--
This is an automated me
jtibshirani commented on issue #11963:
URL: https://github.com/apache/lucene/issues/11963#issuecomment-1325838116
For context, we also have this issue suggesting refactors to the 8-bit
quantization change: https://github.com/apache/lucene/issues/11758. I'm +1 on
revising the API and hope it
jtibshirani commented on PR #11860:
URL: https://github.com/apache/lucene/pull/11860#issuecomment-1325834769
I'm not formally reviewing since this has moved outside my expertise, but
just wanted to say this looks great!
I'm also happily surprised to see such big savings, maybe we inde
rmuir commented on PR #11971:
URL: https://github.com/apache/lucene/pull/11971#issuecomment-1325808194
Only about 2x as costly as `javac` now:
```
129.49 sec. compileJava
122.41 sec. compileTestJava
```
I need to take another pass thru each check. Many of these checks h
rmuir commented on PR #11971:
URL: https://github.com/apache/lucene/pull/11971#issuecomment-1325748060
Still working thru these, but the execution time is getting better:
```
144.97 sec. compileJava
136.46 sec. compileTestJava
```
Big improvement since around a week
rmuir commented on code in PR #11971:
URL: https://github.com/apache/lucene/pull/11971#discussion_r1030875807
##
gradle/validation/error-prone.gradle:
##
@@ -161,65 +161,65 @@ allprojects { prj ->
'-Xep:IsInstanceIncompatibleType:ERROR',
'-Xep:IsInstanc
rmuir commented on code in PR #11971:
URL: https://github.com/apache/lucene/pull/11971#discussion_r1030867074
##
gradle/validation/error-prone.gradle:
##
@@ -161,65 +161,65 @@ allprojects { prj ->
'-Xep:IsInstanceIncompatibleType:ERROR',
'-Xep:IsInstanc
rmuir commented on code in PR #11971:
URL: https://github.com/apache/lucene/pull/11971#discussion_r1030865002
##
gradle/validation/error-prone.gradle:
##
@@ -476,11 +476,11 @@ allprojects { prj ->
'-Xep:UnusedNestedClass:WARN',
// '-Xep:UnusedTypeParame
rmuir commented on code in PR #11971:
URL: https://github.com/apache/lucene/pull/11971#discussion_r1030863322
##
gradle/validation/error-prone.gradle:
##
@@ -417,21 +417,21 @@ allprojects { prj ->
'-Xep:OutlineNone:WARN',
Review Comment:
This check is looking fo
rmuir commented on code in PR #11971:
URL: https://github.com/apache/lucene/pull/11971#discussion_r1030860624
##
gradle/validation/error-prone.gradle:
##
@@ -123,36 +123,36 @@ allprojects { prj ->
'-Xep:EqualsNull:ERROR',
'-Xep:EqualsReference:ERROR',
rmuir commented on PR #11971:
URL: https://github.com/apache/lucene/pull/11971#issuecomment-1325636764
thanks @madrob for taking a look. ill look deeper into the ones you brought
up here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
rmuir commented on code in PR #11971:
URL: https://github.com/apache/lucene/pull/11971#discussion_r103084
##
gradle/validation/error-prone.gradle:
##
@@ -442,18 +442,18 @@ allprojects { prj ->
// '-Xep:StreamResourceLeak:OFF',
'-Xep:StreamToIterable
rmuir commented on code in PR #11971:
URL: https://github.com/apache/lucene/pull/11971#discussion_r1030854141
##
gradle/validation/error-prone.gradle:
##
@@ -417,21 +417,21 @@ allprojects { prj ->
'-Xep:OutlineNone:WARN',
Review Comment:
LOL will take a look aga
rmuir commented on code in PR #11971:
URL: https://github.com/apache/lucene/pull/11971#discussion_r1030853472
##
gradle/validation/error-prone.gradle:
##
@@ -362,33 +362,33 @@ allprojects { prj ->
'-Xep:JavaPeriodGetDays:WARN',
'-Xep:JavaTimeDefaultTime
rmuir commented on code in PR #11971:
URL: https://github.com/apache/lucene/pull/11971#discussion_r1030853110
##
gradle/validation/error-prone.gradle:
##
@@ -161,65 +161,65 @@ allprojects { prj ->
'-Xep:IsInstanceIncompatibleType:ERROR',
'-Xep:IsInstanc
madrob commented on PR #11971:
URL: https://github.com/apache/lucene/pull/11971#issuecomment-1325631190
I'm going on holiday starting in 5 minutes, so please don't wait on me for
further input! Thanks for putting this together, it's also going to be a good
starting point for Solr as well.
rmuir commented on code in PR #11971:
URL: https://github.com/apache/lucene/pull/11971#discussion_r1030851408
##
gradle/validation/error-prone.gradle:
##
@@ -476,11 +476,11 @@ allprojects { prj ->
'-Xep:UnusedNestedClass:WARN',
// '-Xep:UnusedTypeParame
madrob commented on PR #11971:
URL: https://github.com/apache/lucene/pull/11971#issuecomment-1325628423
> > Github won't let me comment on the line but we don't use theory library
>
> Do you refer to this check?
https://errorprone.info/bugpattern/TheoryButNoTheories
>
> I didn'
rmuir commented on PR #11971:
URL: https://github.com/apache/lucene/pull/11971#issuecomment-1325627280
confirmed with `git grep`. We can always turn such checks on if we start
using the functionality. But currently it is my opinion that we have a bunch of
useless error-prone checks enabled,
madrob commented on code in PR #11971:
URL: https://github.com/apache/lucene/pull/11971#discussion_r1030845580
##
gradle/validation/error-prone.gradle:
##
@@ -161,65 +161,65 @@ allprojects { prj ->
'-Xep:IsInstanceIncompatibleType:ERROR',
'-Xep:IsInstan
rmuir commented on PR #11971:
URL: https://github.com/apache/lucene/pull/11971#issuecomment-1325624917
> Github won't let me comment on the line but we don't use theory library
Do you refer to this check?
https://errorprone.info/bugpattern/TheoryButNoTheories
I didn't touch it
rmuir commented on code in PR #11971:
URL: https://github.com/apache/lucene/pull/11971#discussion_r1030846932
##
gradle/validation/error-prone.gradle:
##
@@ -123,36 +123,36 @@ allprojects { prj ->
'-Xep:EqualsNull:ERROR',
'-Xep:EqualsReference:ERROR',
madrob commented on code in PR #11971:
URL: https://github.com/apache/lucene/pull/11971#discussion_r1030844053
##
gradle/validation/error-prone.gradle:
##
@@ -123,36 +123,36 @@ allprojects { prj ->
'-Xep:EqualsNull:ERROR',
'-Xep:EqualsReference:ERROR',
rmuir commented on PR #11971:
URL: https://github.com/apache/lucene/pull/11971#issuecomment-1325598401
I've at least checked the disabled ones includes the ones @madrob pointed
out in #11970 . But like I said, I went thru the checks so fast that i'm sure i
missed a few we don't need.
rmuir commented on PR #11971:
URL: https://github.com/apache/lucene/pull/11971#issuecomment-1325594159
Before:
```
225.22 sec. compileTestJava
223.56 sec. compileJava
```
After:
```
158.53 sec. compileJava
153.20 sec. compileTestJava
```
--
This is an
rmuir commented on PR #11971:
URL: https://github.com/apache/lucene/pull/11971#issuecomment-1325589481
i blasted through these very very quickly, so if you see other useless ones,
please point them out.
--
This is an automated message from the Apache Git Service.
To respond to the message
rmuir opened a new pull request, #11971:
URL: https://github.com/apache/lucene/pull/11971
These are easy/obvious ones to disable since we don't use the functionality
at all: the checks are literally useless.
This gives some performance boost to the error-prone, although it is still
p
rmuir commented on PR #11970:
URL: https://github.com/apache/lucene/pull/11970#issuecomment-1325589076
see https://github.com/apache/lucene/pull/11971
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
rmuir merged PR #11970:
URL: https://github.com/apache/lucene/pull/11970
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
rmuir closed issue #11969: invert error-prone configuration to be allow-list vs
deny-list
URL: https://github.com/apache/lucene/issues/11969
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
rmuir commented on PR #11970:
URL: https://github.com/apache/lucene/pull/11970#issuecomment-1325583560
@madrob i will check your suggestions against "disable useless PR" coming
soon. I just want to merge this no-op first so that we can actually review it
easier. don't worry, they won't be l
rmuir commented on PR #11970:
URL: https://github.com/apache/lucene/pull/11970#issuecomment-1325581405
i have a followup PR for disabling useless stuff. This change is a no-op as
described.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
madrob commented on code in PR #11970:
URL: https://github.com/apache/lucene/pull/11970#discussion_r1030816917
##
gradle/validation/error-prone.gradle:
##
@@ -68,119 +68,420 @@ allprojects { prj ->
options.errorprone.disableWarningsInGeneratedCode = true
opti
rmuir opened a new pull request, #11970:
URL: https://github.com/apache/lucene/pull/11970
This does not change the semantics or performance of our setup.
Instead, it explicitly enables checks that we want vs disabling checks that
we don't want.
Also reordered checks to match th
agorlenko commented on PR #11946:
URL: https://github.com/apache/lucene/pull/11946#issuecomment-1325269770
@msokolov looking forward to your decision
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
thecoop commented on PR #11942:
URL: https://github.com/apache/lucene/pull/11942#issuecomment-1325260207
Comments all addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
thecoop commented on code in PR #11942:
URL: https://github.com/apache/lucene/pull/11942#discussion_r1030556441
##
lucene/analysis/common/src/java/org/apache/lucene/analysis/custom/CustomAnalyzer.java:
##
@@ -594,11 +589,9 @@ public CustomAnalyzer build() {
}
private
rmuir opened a new issue, #11969:
URL: https://github.com/apache/lucene/issues/11969
### Description
Currently the error-prone is a long list of disabled checks. The problem is
that on upgrade, more checks get enabled and slip into our configuration.
Because of this, our error-prone
mcimadamore commented on PR #912:
URL: https://github.com/apache/lucene/pull/912#issuecomment-1325173861
> > More investigation is required to understand where the difference comes
from.
>
> After playing a bit more with the benchmark, it looks like 1ns is coming
from the various ali
jpountz commented on code in PR #11942:
URL: https://github.com/apache/lucene/pull/11942#discussion_r1030516381
##
lucene/analysis/common/src/java/org/apache/lucene/analysis/custom/CustomAnalyzer.java:
##
@@ -594,11 +589,9 @@ public CustomAnalyzer build() {
}
private
thecoop commented on PR #11942:
URL: https://github.com/apache/lucene/pull/11942#issuecomment-1325111034
I've added a comment for that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
mcimadamore commented on PR #912:
URL: https://github.com/apache/lucene/pull/912#issuecomment-1325104378
> More investigation is required to understand where the difference comes
from.
After playing a bit more with the benchmark, it looks like 1ns is coming
from the various alignment
jpountz commented on PR #11942:
URL: https://github.com/apache/lucene/pull/11942#issuecomment-1325093360
In most these cases I would guess that getting the initial size right is not
as important as avoiding largely oversizing the hash map, so it's not really an
issue that callers are passin
mcimadamore commented on PR #912:
URL: https://github.com/apache/lucene/pull/912#issuecomment-1324996036
> Code similar like this:
https://github.com/openjdk/jdk/blob/37848a9ca2ab3021e7b3b2e112bab4631fbe1d99/src/java.base/share/classes/java/nio/X-Buffer.java.template#L929
>
> The of s
sherman commented on PR #912:
URL: https://github.com/apache/lucene/pull/912#issuecomment-1324961786
@mcimadamore Thank you for the detailed explanation. I've got the point. I
need to upgrade to JDK 19.
--
This is an automated message from the Apache Git Service.
To respond to the message
mcimadamore commented on PR #912:
URL: https://github.com/apache/lucene/pull/912#issuecomment-1324947263
@sherman I believe there is a big difference in performance between Java 19
and Java 17. Java 19 is the first release of the API where loop optimizations
and range check elimination are
sherman commented on PR #912:
URL: https://github.com/apache/lucene/pull/912#issuecomment-1324918186
Hi, @uschindler!
I'm experimenting with various improvements of I/O in Lucene.
For a base-line, I use the old implementation of MMapDirectory.
The first idea, when I see t
dweiss merged PR #11966:
URL: https://github.com/apache/lucene/pull/11966
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
jpountz commented on issue #11963:
URL: https://github.com/apache/lucene/issues/11963#issuecomment-1324845550
> the types should be distinguished in fieldinfos today as well (not sure if
that is currently the case)
They are, `FieldInfo#vectorEncoding`.
Trying to list what the c
jpountz merged PR #11962:
URL: https://github.com/apache/lucene/pull/11962
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
jpountz merged PR #11967:
URL: https://github.com/apache/lucene/pull/11967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
jpountz merged PR #11961:
URL: https://github.com/apache/lucene/pull/11961
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
jpountz opened a new pull request, #11967:
URL: https://github.com/apache/lucene/pull/11967
This mailing-list is deprecated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
dweiss opened a new pull request, #11966:
URL: https://github.com/apache/lucene/pull/11966
With errorprone running on the CI only, gradlew check is not a "complete"
check anymore. I think it'd be good to make this explicit in the help.
--
This is an automated message from the Apache Git S
dweiss commented on issue #11965:
URL: https://github.com/apache/lucene/issues/11965#issuecomment-1324699141
Aggregate merge commit in 49c8a75917610.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dweiss opened a new issue, #11965:
URL: https://github.com/apache/lucene/issues/11965
### Description
(proxying for kwright)
A major restructuring and massive performance improvement for spatial3d:
basically the path pieces are now in a balanced b-tree and thus isWithin()
ope
dweiss closed issue #11956: spatial3d tests are failing (TestGeo3DPoint,
TestGeo3dShapeSphereModelRectRelation)
URL: https://github.com/apache/lucene/issues/11956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
dweiss commented on issue #11956:
URL: https://github.com/apache/lucene/issues/11956#issuecomment-1324694196
Karl is locked out of github so by request - this issue is fixed on main,
closing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
59 matches
Mail list logo
