madrob commented on code in PR #11971:
URL: https://github.com/apache/lucene/pull/11971#discussion_r1030845580
##########
gradle/validation/error-prone.gradle:
##########
@@ -161,65 +161,65 @@ allprojects { prj ->
'-Xep:IsInstanceIncompatibleType:ERROR',
'-Xep:IsInstanceOfClass:ERROR',
'-Xep:IsLoggableTagLength:ERROR',
- '-Xep:JUnit3TestNotRun:ERROR',
+ // '-Xep:JUnit3TestNotRun:OFF', // we don't use junit3
'-Xep:JUnit4ClassAnnotationNonStatic:ERROR',
'-Xep:JUnit4SetUpNotRun:ERROR',
'-Xep:JUnit4TearDownNotRun:ERROR',
//'-Xep:JUnit4TestNotRun:OFF',
'-Xep:JUnit4TestsNotRunWithinEnclosed:ERROR',
'-Xep:JUnitAssertSameCheck:ERROR',
'-Xep:JUnitParameterMethodNotFound:ERROR',
- '-Xep:JavaxInjectOnAbstractMethod:ERROR',
- '-Xep:JodaToSelf:ERROR',
- '-Xep:LiteByteStringUtf8:ERROR',
+ // '-Xep:JavaxInjectOnAbstractMethod:OFF', // we don't this
annotation
+ // '-Xep:JodaToSelf:OFF', // we don't use joda-time
+ // '-Xep:LiteByteStringUtf8:OFF', // we don't use protobuf
'-Xep:LocalDateTemporalAmount:ERROR',
'-Xep:LockOnBoxedPrimitive:ERROR',
'-Xep:LoopConditionChecker:ERROR',
'-Xep:LossyPrimitiveCompare:ERROR',
'-Xep:MathRoundIntLong:ERROR',
- '-Xep:MislabeledAndroidString:ERROR',
+ // '-Xep:MislabeledAndroidString:OFF', // we don't use android
'-Xep:MisplacedScopeAnnotations:ERROR',
- '-Xep:MissingSuperCall:ERROR',
- '-Xep:MissingTestCall:ERROR',
+ // '-Xep:MissingSuperCall:OFF', // we don't use this annotation
+ // '-Xep:MissingTestCall:OFF', // we don't use guava
// '-Xep:MisusedDayOfYear:OFF',
'-Xep:MisusedWeekYear:ERROR',
- '-Xep:MixedDescriptors:ERROR',
- '-Xep:MockitoUsage:ERROR',
+ // '-Xep:MixedDescriptors:OFF', // we don't use protobuf
+ // '-Xep:MockitoUsage:OFF', // we don't use mockito
'-Xep:ModifyingCollectionWithItself:ERROR',
- '-Xep:MoreThanOneInjectableConstructor:ERROR',
- '-Xep:MustBeClosedChecker:ERROR',
+ // '-Xep:MoreThanOneInjectableConstructor:OFF', // we don't use
this annotation
+ // '-Xep:MustBeClosedChecker:OFF', // we don't use this annotation
'-Xep:NCopiesOfChar:ERROR',
- '-Xep:NoCanIgnoreReturnValueOnClasses:ERROR',
+ // '-Xep:NoCanIgnoreReturnValueOnClasses:OFF', // we don't use
this annotation
'-Xep:NonCanonicalStaticImport:ERROR',
Review Comment:
I don't think this is a worthwhile check regardless, but that's just my
opinion
##########
gradle/validation/error-prone.gradle:
##########
@@ -161,65 +161,65 @@ allprojects { prj ->
'-Xep:IsInstanceIncompatibleType:ERROR',
'-Xep:IsInstanceOfClass:ERROR',
'-Xep:IsLoggableTagLength:ERROR',
Review Comment:
This should be forbidden APIs to prevent logging with arbitrary tags anyway.
##########
gradle/validation/error-prone.gradle:
##########
@@ -476,11 +476,11 @@ allprojects { prj ->
'-Xep:UnusedNestedClass:WARN',
// '-Xep:UnusedTypeParameter:OFF',
// '-Xep:UnusedVariable:OFF',
- '-Xep:UseBinds:WARN',
+ // '-Xep:UseBinds:OFF', // we don't use this annotation
// '-Xep:UseCorrectAssertInTests:OFF',
'-Xep:VariableNameSameAsType:WARN',
// '-Xep:WaitNotInLoop:OFF',
- '-Xep:WakelockReleasedDangerously:WARN',
+ // '-Xep:WakelockReleasedDangerously:OFF', // we don't use android
'-Xep:WithSignatureDiscouraged:WARN',
Review Comment:
I have no idea what this applies to but it's probably useless
##########
gradle/validation/error-prone.gradle:
##########
@@ -442,18 +442,18 @@ allprojects { prj ->
// '-Xep:StreamResourceLeak:OFF',
'-Xep:StreamToIterable:WARN',
'-Xep:StringSplitter:OFF',
Review Comment:
needs a comment
##########
gradle/validation/error-prone.gradle:
##########
@@ -256,30 +256,30 @@ allprojects { prj ->
// '-Xep:AlmostJavadoc:OFF',
// '-Xep:AlreadyChecked:OFF',
// '-Xep:AmbiguousMethodReference:OFF',
- '-Xep:AnnotateFormatMethod:WARN',
+ // '-Xep:AnnotateFormatMethod:OFF', // we don't use this annotation
// '-Xep:ArgumentSelectionDefectChecker:OFF',
// '-Xep:ArrayAsKeyOfSetOrMap:OFF',
'-Xep:AssertEqualsArgumentOrderChecker:WARN',
'-Xep:AssertThrowsMultipleStatements:WARN',
// '-Xep:AssertionFailureIgnored:OFF',
- '-Xep:AssistedInjectAndInjectOnSameConstructor:WARN',
- '-Xep:AutoValueFinalMethods:WARN',
- '-Xep:AutoValueImmutableFields:WARN',
- '-Xep:AutoValueSubclassLeaked:WARN',
+ // '-Xep:AssistedInjectAndInjectOnSameConstructor:OFF', // we
don't use this annotation
+ // '-Xep:AutoValueFinalMethods:OFF', // we don't use autovalue
+ // '-Xep:AutoValueImmutableFields:OFF', // we don't use autovalue
+ // '-Xep:AutoValueSubclassLeaked:OFF', // we don't use autovalue
'-Xep:BadComparable:WARN',
// '-Xep:BadImport:OFF',
// '-Xep:BadInstanceof:OFF',
'-Xep:BareDotMetacharacter:WARN',
Review Comment:
I remember this coming up before. I don't remember if forbidden API or
something else found it for us. Maybe it was error prone. I feel like Uwe was
the one to fix it though...
##########
gradle/validation/error-prone.gradle:
##########
@@ -417,21 +417,21 @@ allprojects { prj ->
'-Xep:OutlineNone:WARN',
Review Comment:
This is for CSS web styles?
##########
gradle/validation/error-prone.gradle:
##########
@@ -362,33 +362,33 @@ allprojects { prj ->
'-Xep:JavaPeriodGetDays:WARN',
'-Xep:JavaTimeDefaultTimeZone:WARN',
// '-Xep:JavaUtilDate:OFF',
- '-Xep:JavaxInjectOnFinalField:WARN',
+ // '-Xep:JavaxInjectOnFinalField:OFF', // we don't use this
annotation
// '-Xep:JdkObsolete:OFF',
- '-Xep:JodaConstructors:WARN',
- '-Xep:JodaDateTimeConstants:WARN',
- '-Xep:JodaDurationWithMillis:WARN',
- '-Xep:JodaInstantWithMillis:WARN',
- '-Xep:JodaNewPeriod:WARN',
- '-Xep:JodaPlusMinusLong:WARN',
- '-Xep:JodaTimeConverterManager:WARN',
- '-Xep:JodaWithDurationAddedLong:WARN',
- '-Xep:LiteEnumValueOf:WARN',
- '-Xep:LiteProtoToString:WARN',
+ // '-Xep:JodaConstructors:OFF', // we don't use joda-time
+ // '-Xep:JodaDateTimeConstants:OFF', // we don't use joda-time
+ // '-Xep:JodaDurationWithMillis:OFF', // we don't use joda-time
+ // '-Xep:JodaInstantWithMillis:OFF', // we don't use joda-time
+ // '-Xep:JodaNewPeriod:OFF', // we don't use joda-time
+ // '-Xep:JodaPlusMinusLong:OFF', // we don't use joda-time
+ // '-Xep:JodaTimeConverterManager:OFF', // we don't use joda-time
+ // '-Xep:JodaWithDurationAddedLong:OFF', // we don't use joda-time
+ // '-Xep:LiteEnumValueOf:OFF', // we don't use protobuf
+ // '-Xep:LiteProtoToString:OFF', // we don't use protobuf
// '-Xep:LockNotBeforeTry:OFF',
// '-Xep:LogicalAssignment:OFF',
// '-Xep:LongDoubleConversion:OFF',
'-Xep:LongFloatConversion:WARN',
'-Xep:LoopOverCharArray:WARN',
'-Xep:MalformedInlineTag:WARN',
// '-Xep:MathAbsoluteRandom:OFF',
- '-Xep:MemoizeConstantVisitorStateLookups:WARN',
+ // '-Xep:MemoizeConstantVisitorStateLookups:OFF', // we don't use
this class
'-Xep:MissingCasesInEnumSwitch:WARN',
Review Comment:
Does javac do this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
