rmuir commented on code in PR #11971:
URL: https://github.com/apache/lucene/pull/11971#discussion_r1030853472
##########
gradle/validation/error-prone.gradle:
##########
@@ -362,33 +362,33 @@ allprojects { prj ->
'-Xep:JavaPeriodGetDays:WARN',
'-Xep:JavaTimeDefaultTimeZone:WARN',
// '-Xep:JavaUtilDate:OFF',
- '-Xep:JavaxInjectOnFinalField:WARN',
+ // '-Xep:JavaxInjectOnFinalField:OFF', // we don't use this
annotation
// '-Xep:JdkObsolete:OFF',
- '-Xep:JodaConstructors:WARN',
- '-Xep:JodaDateTimeConstants:WARN',
- '-Xep:JodaDurationWithMillis:WARN',
- '-Xep:JodaInstantWithMillis:WARN',
- '-Xep:JodaNewPeriod:WARN',
- '-Xep:JodaPlusMinusLong:WARN',
- '-Xep:JodaTimeConverterManager:WARN',
- '-Xep:JodaWithDurationAddedLong:WARN',
- '-Xep:LiteEnumValueOf:WARN',
- '-Xep:LiteProtoToString:WARN',
+ // '-Xep:JodaConstructors:OFF', // we don't use joda-time
+ // '-Xep:JodaDateTimeConstants:OFF', // we don't use joda-time
+ // '-Xep:JodaDurationWithMillis:OFF', // we don't use joda-time
+ // '-Xep:JodaInstantWithMillis:OFF', // we don't use joda-time
+ // '-Xep:JodaNewPeriod:OFF', // we don't use joda-time
+ // '-Xep:JodaPlusMinusLong:OFF', // we don't use joda-time
+ // '-Xep:JodaTimeConverterManager:OFF', // we don't use joda-time
+ // '-Xep:JodaWithDurationAddedLong:OFF', // we don't use joda-time
+ // '-Xep:LiteEnumValueOf:OFF', // we don't use protobuf
+ // '-Xep:LiteProtoToString:OFF', // we don't use protobuf
// '-Xep:LockNotBeforeTry:OFF',
// '-Xep:LogicalAssignment:OFF',
// '-Xep:LongDoubleConversion:OFF',
'-Xep:LongFloatConversion:WARN',
'-Xep:LoopOverCharArray:WARN',
'-Xep:MalformedInlineTag:WARN',
// '-Xep:MathAbsoluteRandom:OFF',
- '-Xep:MemoizeConstantVisitorStateLookups:WARN',
+ // '-Xep:MemoizeConstantVisitorStateLookups:OFF', // we don't use
this class
'-Xep:MissingCasesInEnumSwitch:WARN',
Review Comment:
we turn this on in `ECJ` linter already, let's nuke it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
