rmuir commented on code in PR #11971:
URL: https://github.com/apache/lucene/pull/11971#discussion_r1030851408
##########
gradle/validation/error-prone.gradle:
##########
@@ -476,11 +476,11 @@ allprojects { prj ->
'-Xep:UnusedNestedClass:WARN',
// '-Xep:UnusedTypeParameter:OFF',
// '-Xep:UnusedVariable:OFF',
- '-Xep:UseBinds:WARN',
+ // '-Xep:UseBinds:OFF', // we don't use this annotation
// '-Xep:UseCorrectAssertInTests:OFF',
'-Xep:VariableNameSameAsType:WARN',
// '-Xep:WaitNotInLoop:OFF',
- '-Xep:WakelockReleasedDangerously:WARN',
+ // '-Xep:WakelockReleasedDangerously:OFF', // we don't use android
'-Xep:WithSignatureDiscouraged:WARN',
Review Comment:
i tried to find out what `withSignature` referred to, googled around, i
think it might only apply to internal javac apis? for a lot of these, i just
moved along when i couldnt figure it out, was trying to be conservative and not
disable anything actually useful. I'll take another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
