rmuir commented on code in PR #11971:
URL: https://github.com/apache/lucene/pull/11971#discussion_r1030875807
##########
gradle/validation/error-prone.gradle:
##########
@@ -161,65 +161,65 @@ allprojects { prj ->
'-Xep:IsInstanceIncompatibleType:ERROR',
'-Xep:IsInstanceOfClass:ERROR',
'-Xep:IsLoggableTagLength:ERROR',
- '-Xep:JUnit3TestNotRun:ERROR',
+ // '-Xep:JUnit3TestNotRun:OFF', // we don't use junit3
'-Xep:JUnit4ClassAnnotationNonStatic:ERROR',
'-Xep:JUnit4SetUpNotRun:ERROR',
'-Xep:JUnit4TearDownNotRun:ERROR',
//'-Xep:JUnit4TestNotRun:OFF',
'-Xep:JUnit4TestsNotRunWithinEnclosed:ERROR',
'-Xep:JUnitAssertSameCheck:ERROR',
'-Xep:JUnitParameterMethodNotFound:ERROR',
- '-Xep:JavaxInjectOnAbstractMethod:ERROR',
- '-Xep:JodaToSelf:ERROR',
- '-Xep:LiteByteStringUtf8:ERROR',
+ // '-Xep:JavaxInjectOnAbstractMethod:OFF', // we don't this
annotation
+ // '-Xep:JodaToSelf:OFF', // we don't use joda-time
+ // '-Xep:LiteByteStringUtf8:OFF', // we don't use protobuf
'-Xep:LocalDateTemporalAmount:ERROR',
'-Xep:LockOnBoxedPrimitive:ERROR',
'-Xep:LoopConditionChecker:ERROR',
'-Xep:LossyPrimitiveCompare:ERROR',
'-Xep:MathRoundIntLong:ERROR',
- '-Xep:MislabeledAndroidString:ERROR',
+ // '-Xep:MislabeledAndroidString:OFF', // we don't use android
'-Xep:MisplacedScopeAnnotations:ERROR',
- '-Xep:MissingSuperCall:ERROR',
- '-Xep:MissingTestCall:ERROR',
+ // '-Xep:MissingSuperCall:OFF', // we don't use this annotation
+ // '-Xep:MissingTestCall:OFF', // we don't use guava
// '-Xep:MisusedDayOfYear:OFF',
'-Xep:MisusedWeekYear:ERROR',
- '-Xep:MixedDescriptors:ERROR',
- '-Xep:MockitoUsage:ERROR',
+ // '-Xep:MixedDescriptors:OFF', // we don't use protobuf
+ // '-Xep:MockitoUsage:OFF', // we don't use mockito
'-Xep:ModifyingCollectionWithItself:ERROR',
- '-Xep:MoreThanOneInjectableConstructor:ERROR',
- '-Xep:MustBeClosedChecker:ERROR',
+ // '-Xep:MoreThanOneInjectableConstructor:OFF', // we don't use
this annotation
+ // '-Xep:MustBeClosedChecker:OFF', // we don't use this annotation
'-Xep:NCopiesOfChar:ERROR',
- '-Xep:NoCanIgnoreReturnValueOnClasses:ERROR',
+ // '-Xep:NoCanIgnoreReturnValueOnClasses:OFF', // we don't use
this annotation
'-Xep:NonCanonicalStaticImport:ERROR',
Review Comment:
Yeah, a lot of checks like these maybe got "implicitly" enabled when we
upgraded error-prone. All the new checks got enabled even though we didn't
opt-in. Thats the problem with the old blocklist approach. So really we need to
do a pass over all the checks and figure out which ones we want/don't want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
