rmuir commented on code in PR #11971:
URL: https://github.com/apache/lucene/pull/11971#discussion_r1030846932
##########
gradle/validation/error-prone.gradle:
##########
@@ -123,36 +123,36 @@ allprojects { prj ->
'-Xep:EqualsNull:ERROR',
'-Xep:EqualsReference:ERROR',
'-Xep:EqualsWrongThing:ERROR',
- '-Xep:FloggerFormatString:ERROR',
- '-Xep:FloggerLogVarargs:ERROR',
- '-Xep:FloggerSplitLogStatement:ERROR',
- '-Xep:ForOverride:ERROR',
+ // '-Xep:FloggerFormatString:OFF', // we don't use flogger
+ // '-Xep:FloggerLogVarargs:OFF', // we don't use flogger
+ // '-Xep:FloggerSplitLogStatement:OFF', // we don't use flogger
+ // '-Xep:ForOverride:OFF', // we don't use this annotation
// '-Xep:FormatString:OFF',
- '-Xep:FormatStringAnnotation:ERROR',
+ // '-Xep:FormatStringAnnotation:OFF', // we don't use this
annotation
'-Xep:FromTemporalAccessor:ERROR',
'-Xep:FunctionalInterfaceMethodChanged:ERROR',
'-Xep:FuturesGetCheckedIllegalExceptionType:ERROR',
'-Xep:FuzzyEqualsShouldNotBeUsedInEqualsMethod:ERROR',
'-Xep:GetClassOnAnnotation:ERROR',
'-Xep:GetClassOnClass:ERROR',
- '-Xep:GuardedBy:ERROR',
- '-Xep:GuiceAssistedInjectScoping:ERROR',
- '-Xep:GuiceAssistedParameters:ERROR',
- '-Xep:GuiceInjectOnFinalField:ERROR',
+ // '-Xep:GuardedBy:OFF', // we don't use this annotation
+ // '-Xep:GuiceAssistedInjectScoping:OFF', // we don't use guice
+ // '-Xep:GuiceAssistedParameters:OFF', // we don't use guice
+ // '-Xep:GuiceInjectOnFinalField:OFF', // we don't use guice
'-Xep:HashtableContains:ERROR',
// '-Xep:IdentityBinaryExpression:OFF',
'-Xep:IdentityHashMapBoxing:ERROR',
- '-Xep:IgnoredPureGetter:ERROR',
- '-Xep:Immutable:ERROR',
+ // '-Xep:IgnoredPureGetter:OFF', // we don't use these annotations
+ // '-Xep:Immutable:OFF', // we don't use this annotation
'-Xep:Incomparable:ERROR',
- '-Xep:IncompatibleArgumentType:ERROR',
- '-Xep:IncompatibleModifiers:ERROR',
+ // '-Xep:IncompatibleArgumentType:OFF', // we don't use this
annotation
+ // '-Xep:IncompatibleModifiers:OFF', // we don't use this
annotation
'-Xep:IndexOfChar:ERROR',
Review Comment:
my understanding is check will be triggered if you pass `char` to second
argument to `indexOf(int, int)`. It is likely not what you want, even though
java will promote your `char` to `int` and compile happily. Forbidden apis
can't detect this as it can only block method calls...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
