dweiss commented on a change in pull request #521:
URL: https://github.com/apache/lucene/pull/521#discussion_r763712209
##
File path:
lucene/highlighter/src/test/org/apache/lucene/search/matchhighlight/TestMatchRegionRetriever.java
##
@@ -379,17 +379,17 @@ public void testInte
[
https://issues.apache.org/jira/browse/LUCENE-10289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignacio Vera resolved LUCENE-10289.
---
Fix Version/s: 9.1
Assignee: Ignacio Vera
Resolution: Fixed
> DocIdSetBuild
[
https://issues.apache.org/jira/browse/LUCENE-10289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454410#comment-17454410
]
ASF subversion and git services commented on LUCENE-10289:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454409#comment-17454409
]
ASF subversion and git services commented on LUCENE-10289:
--
Co
iverase merged pull request #520:
URL: https://github.com/apache/lucene/pull/520
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr..
[
https://issues.apache.org/jira/browse/LUCENE-10287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454405#comment-17454405
]
ASF subversion and git services commented on LUCENE-10287:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454404#comment-17454404
]
ASF subversion and git services commented on LUCENE-10287:
--
Co
mocobeta merged pull request #522:
URL: https://github.com/apache/lucene/pull/522
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr.
[
https://issues.apache.org/jira/browse/LUCENE-10280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignacio Vera resolved LUCENE-10280.
---
Fix Version/s: 9.1
Assignee: Ignacio Vera
Resolution: Fixed
> Store BKD blo
[
https://issues.apache.org/jira/browse/LUCENE-10280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454402#comment-17454402
]
ASF subversion and git services commented on LUCENE-10280:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454399#comment-17454399
]
ASF subversion and git services commented on LUCENE-10280:
--
Co
iverase merged pull request #510:
URL: https://github.com/apache/lucene/pull/510
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr..
mocobeta opened a new pull request #522:
URL: https://github.com/apache/lucene/pull/522
https://issues.apache.org/jira/browse/LUCENE-10287
Having abstract `FSDirectory` in the supported directory seems to be useful
to detect problems when it starts as module mode.
--
This is an au
rmuir merged pull request #516:
URL: https://github.com/apache/lucene/pull/516
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
rmuir merged pull request #515:
URL: https://github.com/apache/lucene/pull/515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@
[
https://issues.apache.org/jira/browse/LUCENE-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454334#comment-17454334
]
Haoyu Zhai commented on LUCENE-10229:
-
Here's the PR: https://github.com/apache/luc
zhaih commented on a change in pull request #521:
URL: https://github.com/apache/lucene/pull/521#discussion_r763579212
##
File path:
lucene/queries/src/java/org/apache/lucene/queries/intervals/Intervals.java
##
@@ -275,7 +275,10 @@ public static IntervalsSource ordered(Interva
zhaih commented on a change in pull request #521:
URL: https://github.com/apache/lucene/pull/521#discussion_r763577418
##
File path:
lucene/queries/src/java/org/apache/lucene/queries/intervals/MinimumShouldMatchIntervalsSource.java
##
@@ -215,6 +215,7 @@ public int gaps() {
zhaih opened a new pull request #521:
URL: https://github.com/apache/lucene/pull/521
https://issues.apache.org/jira/browse/LUCENE-10229
# Description
The problem is mostly that all the subclasses of
`ConjunctionIntervalsSource` delegate the super class to handle fo
[
https://issues.apache.org/jira/browse/LUCENE-10292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454288#comment-17454288
]
Chris M. Hostetter commented on LUCENE-10292:
-
It seems like at a minimum w
Chris M. Hostetter created LUCENE-10292:
---
Summary: AnalyzingInfixSuggester thread safety: lookup() fails
during (re)build()
Key: LUCENE-10292
URL: https://issues.apache.org/jira/browse/LUCENE-10292
dweiss commented on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-987195789
I still have a gut feeling that if we defined explicit dependency
configurations for modules, they'd fit right in. Something like:
moduleApi
moduleImplementation
moduleCompi
dweiss commented on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-987190443
I merged in the changes from @mocobeta and everything compiles. I was
wondering what would happen if we enabled the module path for all subprojects,
including those that are not mod
dsmiley commented on pull request #519:
URL: https://github.com/apache/lucene/pull/519#issuecomment-987119983
There aren't any tests for the "scorer" in this map, surprisingly enough (I
mentioned this in the JIRA). I should add one.
--
This is an automated message from the Apache Git Se
[
https://issues.apache.org/jira/browse/LUCENE-10287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454208#comment-17454208
]
ASF subversion and git services commented on LUCENE-10287:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454207#comment-17454207
]
ASF subversion and git services commented on LUCENE-10287:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler resolved LUCENE-10287.
Resolution: Fixed
> Add jdk.unsupported module to Luke startup script
> -
[
https://issues.apache.org/jira/browse/LUCENE-10287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454204#comment-17454204
]
ASF subversion and git services commented on LUCENE-10287:
--
Co
uschindler merged pull request #517:
URL: https://github.com/apache/lucene/pull/517
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubsc
[
https://issues.apache.org/jira/browse/LUCENE-10287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454202#comment-17454202
]
ASF subversion and git services commented on LUCENE-10287:
--
Co
dsmiley commented on a change in pull request #519:
URL: https://github.com/apache/lucene/pull/519#discussion_r763308138
##
File path:
lucene/queries/src/test/org/apache/lucene/queries/function/TestValueSources.java
##
@@ -36,19 +36,60 @@
import org.apache.lucene.index.Random
iverase commented on pull request #510:
URL: https://github.com/apache/lucene/pull/510#issuecomment-987036814
I will merge soon if Adrien does not beat me up.
I worked on the PR about using #readLELongs but never get a meaningful speed
up that justify the added complexity. Maybe now
gf2121 edited a comment on pull request #510:
URL: https://github.com/apache/lucene/pull/510#issuecomment-986952205
Hi @jpountz ! Just to remind, maybe we can merge this now? :)
By the way, I found that there is a PR about using readLELongs in BKD
https://github.com/apache/lucene-sol
gf2121 edited a comment on pull request #510:
URL: https://github.com/apache/lucene/pull/510#issuecomment-986952205
Hi @jpountz ! Just to remind, maybe we can merge this now? :)
By the way, I found that there is a PR about using readLELongs in BKD
https://github.com/apache/lucene-sol
gf2121 edited a comment on pull request #510:
URL: https://github.com/apache/lucene/pull/510#issuecomment-986952205
Hi @jpountz @iverase ! Just to remind, maybe we can merge this now? :)
By the way, I found that there is a PR about using readLELongs in BKD
https://github.com/apache/
gf2121 commented on pull request #510:
URL: https://github.com/apache/lucene/pull/510#issuecomment-986952205
Hi @jpountz ! Just to remind, maybe we can merge this now? :)
By the way, I found that there is a PR about using readLELongs in BKD
https://github.com/apache/lucene-solr/pull/
dweiss commented on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-986909873
> If I interpret your comment above correctly, then when walking the
dependency graph once a module-info.java, or module-info.class in a project is
encountered, that node and all ch
ChrisHegarty edited a comment on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-986867695
I'm noting this here, since the scenario may be applicable to Lucene, but
I'm not yet sure.
As you know, I'm prototyping the modularization of Elasticsearch, an
ChrisHegarty edited a comment on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-986901824
@dweiss You might well be right. One thing that is frustrating about
Gradle's built-in module support is that it seems to be triggered by the
presence of a module-info.
ChrisHegarty commented on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-986901824
@dweiss You might well be right. One thing that is frustrating about
Gradle's built-in module support is that it seems to be triggered by the
presence of a module-info.java in
[
https://issues.apache.org/jira/browse/LUCENE-10281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454083#comment-17454083
]
Lu Xugang edited comment on LUCENE-10281 at 12/6/21, 3:41 PM:
---
[
https://issues.apache.org/jira/browse/LUCENE-10281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454083#comment-17454083
]
Lu Xugang edited comment on LUCENE-10281 at 12/6/21, 3:40 PM:
---
[
https://issues.apache.org/jira/browse/LUCENE-10281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454083#comment-17454083
]
Lu Xugang edited comment on LUCENE-10281 at 12/6/21, 3:39 PM:
---
[
https://issues.apache.org/jira/browse/LUCENE-10281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lu Xugang updated LUCENE-10281:
---
Attachment: (was: 1.jpg)
> Error condition used to judge whether hits are sparse in
> StringVa
[
https://issues.apache.org/jira/browse/LUCENE-10281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lu Xugang updated LUCENE-10281:
---
Attachment: (was: 1.png)
> Error condition used to judge whether hits are sparse in
> StringVa
[
https://issues.apache.org/jira/browse/LUCENE-10281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lu Xugang updated LUCENE-10281:
---
Attachment: 1.jpg
> Error condition used to judge whether hits are sparse in
> StringValueFacetCou
[
https://issues.apache.org/jira/browse/LUCENE-10291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454089#comment-17454089
]
Robert Muir commented on LUCENE-10291:
--
Also, test should make sure a merge happen
dweiss commented on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-986890293
I wonder if the dual behavior of compiling with classpath/ module path is
needed at all (the detection of module-info.java in my patch) - maybe we should
just always extract module
[
https://issues.apache.org/jira/browse/LUCENE-10281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454083#comment-17454083
]
Lu Xugang commented on LUCENE-10281:
Hi, [~sokolov] , I did test via *python src/py
[
https://issues.apache.org/jira/browse/LUCENE-10281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lu Xugang updated LUCENE-10281:
---
Attachment: 1.png
> Error condition used to judge whether hits are sparse in
> StringValueFacetCou
[
https://issues.apache.org/jira/browse/LUCENE-10281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lu Xugang updated LUCENE-10281:
---
Attachment: (was: 面试问题.md)
> Error condition used to judge whether hits are sparse in
> String
[
https://issues.apache.org/jira/browse/LUCENE-10281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lu Xugang updated LUCENE-10281:
---
Attachment: 面试问题.md
> Error condition used to judge whether hits are sparse in
> StringValueFacetC
[
https://issues.apache.org/jira/browse/LUCENE-10291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454078#comment-17454078
]
Robert Muir commented on LUCENE-10291:
--
There are problems with stored fields/vect
dweiss commented on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-986880672
You're right, @ChrisHegarty - I didn't consider such a scenario. A similar
trick can be used to what I suggested: disable the built-in module path
resolver, use a custom one... but
ChrisHegarty commented on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-986867695
I'm noting this here, since the scenario may be applicable to Lucene, but
I'm not yet sure.
As you know, I'm prototyping the modularization of Elasticsearch, and there
[
https://issues.apache.org/jira/browse/LUCENE-10291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454068#comment-17454068
]
Robert Muir commented on LUCENE-10291:
--
+1
> Only read/write postings when there
iverase commented on a change in pull request #520:
URL: https://github.com/apache/lucene/pull/520#discussion_r763060170
##
File path: lucene/core/src/java/org/apache/lucene/util/DocIdSetBuilder.java
##
@@ -184,10 +184,11 @@ public void add(DocIdSetIterator iter) throws IOExcep
iverase commented on a change in pull request #520:
URL: https://github.com/apache/lucene/pull/520#discussion_r763060400
##
File path: lucene/CHANGES.txt
##
@@ -100,6 +100,8 @@ Other
* LUCENE-10284: Upgrade morfologik-stemming to 2.1.8. (Dawid Weiss)
+LUCENE-10289: DocIdSe
iverase commented on a change in pull request #520:
URL: https://github.com/apache/lucene/pull/520#discussion_r763060170
##
File path: lucene/core/src/java/org/apache/lucene/util/DocIdSetBuilder.java
##
@@ -184,10 +184,11 @@ public void add(DocIdSetIterator iter) throws IOExcep
[
https://issues.apache.org/jira/browse/LUCENE-10291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454045#comment-17454045
]
Adrien Grand commented on LUCENE-10291:
---
+1 Indexing empty documents with a codec
jpountz commented on a change in pull request #520:
URL: https://github.com/apache/lucene/pull/520#discussion_r763049319
##
File path: lucene/CHANGES.txt
##
@@ -100,6 +100,8 @@ Other
* LUCENE-10284: Upgrade morfologik-stemming to 2.1.8. (Dawid Weiss)
+LUCENE-10289: DocIdSe
[
https://issues.apache.org/jira/browse/LUCENE-10291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454041#comment-17454041
]
Robert Muir commented on LUCENE-10291:
--
I agree, it would be good to have simple t
Adrien Grand created LUCENE-10291:
-
Summary: Only read/write postings when there is at least one
indexed field
Key: LUCENE-10291
URL: https://issues.apache.org/jira/browse/LUCENE-10291
Project: Lucene
[
https://issues.apache.org/jira/browse/LUCENE-10252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454023#comment-17454023
]
David Smiley commented on LUCENE-10252:
---
I think this could reasonably be qualifi
Dominik created LUCENE-10290:
Summary: analysis-stempel incorrect tokens generation for numbers
Key: LUCENE-10290
URL: https://issues.apache.org/jira/browse/LUCENE-10290
Project: Lucene - Core
Is
rmuir commented on a change in pull request #513:
URL: https://github.com/apache/lucene/pull/513#discussion_r763022968
##
File path: lucene/core/src/java/org/apache/lucene/util/automaton/RegExp.java
##
@@ -556,165 +538,84 @@ static RegExp newLeafNode(
* toAutomaton(null) (e
janhoy merged pull request #2622:
URL: https://github.com/apache/lucene-solr/pull/2622
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsu
[
https://issues.apache.org/jira/browse/LUCENE-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454010#comment-17454010
]
David Smiley commented on LUCENE-10197:
---
I think a single JIRA is fine. I suppos
uschindler commented on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-986748534
> > I am not sure what's the right choice. If we don't pass it, it would be
needed on startup explicit. This would be a trap for users of Lucene.
>
> `requires jdk.unsuppo
[
https://issues.apache.org/jira/browse/LUCENE-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453972#comment-17453972
]
Animesh Pandey commented on LUCENE-10197:
-
[~dsmiley] Can we specify that this
gf2121 commented on a change in pull request #510:
URL: https://github.com/apache/lucene/pull/510#discussion_r762940276
##
File path: lucene/core/src/java/org/apache/lucene/util/bkd/DocIdsWriter.java
##
@@ -44,13 +44,21 @@ static void writeDocIds(int[] docIds, int start, int co
gf2121 commented on a change in pull request #510:
URL: https://github.com/apache/lucene/pull/510#discussion_r762940276
##
File path: lucene/core/src/java/org/apache/lucene/util/bkd/DocIdsWriter.java
##
@@ -44,13 +44,21 @@ static void writeDocIds(int[] docIds, int start, int co
iverase commented on a change in pull request #486:
URL: https://github.com/apache/lucene/pull/486#discussion_r762936377
##
File path: lucene/core/src/java/org/apache/lucene/index/PointValues.java
##
@@ -361,14 +405,29 @@ private void intersect(IntersectVisitor visitor,
PointT
iverase opened a new pull request #520:
URL: https://github.com/apache/lucene/pull/520
It makes sense as it is possible to bulk add more than Integer.MAX_VALUE
docs as there can be duplicates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
Ignacio Vera created LUCENE-10289:
-
Summary: DocIdSetBuilder#grow() should take a long instead of int
Key: LUCENE-10289
URL: https://issues.apache.org/jira/browse/LUCENE-10289
Project: Lucene - Core
ChrisHegarty commented on pull request #470:
URL: https://github.com/apache/lucene/pull/470#issuecomment-98222
> I am not sure what's the right choice. If we don't pass it, it would be
needed on startup explicit. This would be a trap for users of Lucene.
`requires jdk.unsupported
jpountz commented on a change in pull request #486:
URL: https://github.com/apache/lucene/pull/486#discussion_r762885177
##
File path: lucene/core/src/java/org/apache/lucene/index/PointValues.java
##
@@ -361,14 +405,29 @@ private void intersect(IntersectVisitor visitor,
PointT
jpountz commented on a change in pull request #486:
URL: https://github.com/apache/lucene/pull/486#discussion_r762884878
##
File path: lucene/core/src/java/org/apache/lucene/index/PointValues.java
##
@@ -361,14 +405,29 @@ private void intersect(IntersectVisitor visitor,
PointT
iverase commented on a change in pull request #486:
URL: https://github.com/apache/lucene/pull/486#discussion_r762861748
##
File path: lucene/core/src/java/org/apache/lucene/index/PointValues.java
##
@@ -361,14 +405,29 @@ private void intersect(IntersectVisitor visitor,
PointT
jpountz commented on a change in pull request #486:
URL: https://github.com/apache/lucene/pull/486#discussion_r762833932
##
File path: lucene/core/src/java/org/apache/lucene/index/PointValues.java
##
@@ -361,14 +405,29 @@ private void intersect(IntersectVisitor visitor,
PointT
[
https://issues.apache.org/jira/browse/LUCENE-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17453877#comment-17453877
]
Ignacio Vera commented on LUCENE-10288:
---
First inspection of the code shows that
Ignacio Vera created LUCENE-10288:
-
Summary: Are 1-dimensional kd trees in pre-86 indices always
unbalanced trees?
Key: LUCENE-10288
URL: https://issues.apache.org/jira/browse/LUCENE-10288
Project: Lu
82 matches
Mail list logo
