dweiss commented on pull request #470: URL: https://github.com/apache/lucene/pull/470#issuecomment-986890293
I wonder if the dual behavior of compiling with classpath/ module path is needed at all (the detection of module-info.java in my patch) - maybe we should just always extract module path and classpath entries. Then the next logical step would be indeed to traverse the dependency graph and see which dependencies are reachable through modular nodes - all these dependencies would end up on the module path, the rest would end up on classpath in the unnamed module. Parsing the dependency graph out of a configuration may be frustratingly complex [1] but it can be done. [1] https://github.com/apache/lucene/blob/main/gradle/validation/jar-checks.gradle#L86-L142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
