uschindler commented on pull request #470: URL: https://github.com/apache/lucene/pull/470#issuecomment-986748534
> > I am not sure what's the right choice. If we don't pass it, it would be needed on startup explicit. This would be a trap for users of Lucene. > > `requires jdk.unsupported` is the right choice. It's not a problem to require this module. Yes, sun.misc.Unsafe is unsupported, but as you observe it has always been the case. Hopefully, at some future point the code can migrate to whatever new Java API offers replacement functionality to Unsafe, e.g. Panama off-heap memory access, etc. For now, jdk.unsupported is the way to go. We're on #518 to use Panama. Works quite well now. If it comes out of f.cki.g incubator and also preview phase (not even there!) at some point, we will add an alternative to `MMapDirectory` 😉🤠-- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
