dweiss commented on pull request #470: URL: https://github.com/apache/lucene/pull/470#issuecomment-987190443
I merged in the changes from @mocobeta and everything compiles. I was wondering what would happen if we enabled the module path for all subprojects, including those that are not modules (like the test-framework). Predictably, things broke down. Even though we add dependencies (modules) to the module path, they're not included in the resolved graph for those non-modular subprojects. So we'd also need to add those modules manually (via add-modules) in addition to setting up the modular path. I ended up using the ALL-MODULE-PATH and it worked... almost because the test-framework has split packages with Lucene and it can't be compiled against Lucene as a module. But it shows that it's possible. If we had those split modular-non-modular configurations then in fact even graph traversal wouldn't be needed - configurations form a graph of dependencies already so a dependency and all its transitive dependencies placed in, say, "apiModule" would end up on modul-path. Perhaps it's worth revisiting... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
