ChrisHegarty edited a comment on pull request #470: URL: https://github.com/apache/lucene/pull/470#issuecomment-986867695
I'm noting this here, since the scenario may be applicable to Lucene, but I'm not yet sure. As you know, I'm prototyping the modularization of Elasticsearch, and there are many commonalities with the efforts here. One scenario that I've run into when trying to apply customization to Gradle for shuffling things from the class path to the module path, is that we still have large sections of the code base that will not yet be modularized, but themselves depend on project source that is modularized. (The reason for this is that we want to start modularizing the core of Elasticsearch, but not yet the plugins, which are loaded at runtime by custom class loaders ) This scenario is quite a conundrum, since we kinda need to follow the dependency graph to determine which path things should be on. For a plugin, if a dependent Elasticsearch project has a module-info, then it AND its dependencies should go on the module path, otherwise leave it on the class path. Everything else should just go on the class path - since the plugin in question is not loaded as a module, but rather running on a modularized Elasticsearch core. Note, it is important to have the core ES modules on the module path so that when developing plugin code the IDE and build correctly see the exported packages (rather than everything appearing fine until later deployed ). This pushing me in the direction of a solution that just has an explicit list of dependencies, and which path they should be on, rather than more fancy inference. Does Lucene have such a scenario? ( if so, it may hint at a similar more crude solution, as above. OR maybe something more fancy if we can get dependency graph traversal to do the shuffling? ). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
