jpountz commented on a change in pull request #486:
URL: https://github.com/apache/lucene/pull/486#discussion_r762833932
##########
File path: lucene/core/src/java/org/apache/lucene/index/PointValues.java
##########
@@ -361,14 +405,29 @@ private void intersect(IntersectVisitor visitor,
PointTree pointTree) throws IOE
// TODO: we can assert that the first value here in fact matches
what the pointTree
// claimed?
// Leaf node; scan and filter all points in this block:
- pointTree.visitDocValues(visitor);
+ visitor.grow((int) pointTree.size());
Review comment:
The contract that we really care about for `grow()` is the number of
times `visit(int docID)` might be called since we use it to resize the `int[]`
array that stores matching doc IDs. Making `grow` about the number of unique
documents would make it more challenging to deal with the `int[]` in case a
leaf has more doc/value pairs than unique docs, since we wouldn't be able to
safely grow the array up-front and would have to check upon every doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
