[GitHub] [lucene] magibney commented on pull request #15: LUCENE-8972: Add ICUTransformCharFilter, to support pre-tokenizer ICU text transformation

magibney commented on pull request #15: URL: https://github.com/apache/lucene/pull/15#issuecomment-800749558 Right; the normalization optimizations are not conceived of as a general-purpose type thing. I think [this comment](https://github.com/apache/lucene-solr/pull/892#issuecomment-56329

[GitHub] [lucene] rmuir commented on pull request #15: LUCENE-8972: Add ICUTransformCharFilter, to support pre-tokenizer ICU text transformation

rmuir commented on pull request #15: URL: https://github.com/apache/lucene/pull/15#issuecomment-800745487 I looked, I don't think the normalization optimizations here are safe. Many rulesets assume a certain form for a reason, because the rules work that way. For example, Hangul-Latin work

[GitHub] [lucene-solr] mayya-sharipova commented on pull request #2186: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on pull request #2186: URL: https://github.com/apache/lucene-solr/pull/2186#issuecomment-800641040 @jpountz Thanks a lot for the second round of review. I've addressed these comments in the [new repo](https://github.com/apache/lucene/pull/11/commits/0fe3493110ac2a

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #2186: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #2186: URL: https://github.com/apache/lucene-solr/pull/2186#discussion_r595569375 ## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfos.java ## @@ -796,167 +565,97 @@ public void add(FieldInfos other) {

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #2186: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #2186: URL: https://github.com/apache/lucene-solr/pull/2186#discussion_r595568938 ## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfos.java ## @@ -481,205 +433,102 @@ synchronized int addOrGet(

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #2186: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #2186: URL: https://github.com/apache/lucene-solr/pull/2186#discussion_r595568561 ## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfos.java ## @@ -481,205 +433,102 @@ synchronized int addOrGet(

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #2186: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #2186: URL: https://github.com/apache/lucene-solr/pull/2186#discussion_r595565982 ## File path: lucene/test-framework/src/java/org/apache/lucene/index/BasePointsFormatTestCase.java ## @@ -1174,8 +1174,11 @@ public void test

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #2186: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #2186: URL: https://github.com/apache/lucene-solr/pull/2186#discussion_r595565552 ## File path: lucene/test-framework/src/java/org/apache/lucene/index/BaseVectorFormatTestCase.java ## @@ -131,7 +115,8 @@ public void testIll

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #2186: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #2186: URL: https://github.com/apache/lucene-solr/pull/2186#discussion_r595564525 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexingChain.java ## @@ -399,7 +401,8 @@ private void writeDocValues(SegmentWriteS

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #2186: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #2186: URL: https://github.com/apache/lucene-solr/pull/2186#discussion_r595564366 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexingChain.java ## @@ -349,7 +350,8 @@ private void writePoints(SegmentWriteStat

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #2186: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #2186: URL: https://github.com/apache/lucene-solr/pull/2186#discussion_r595562263 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexingChain.java ## @@ -581,37 +584,59 @@ private void finishStoredFields() throw

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #2186: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #2186: URL: https://github.com/apache/lucene-solr/pull/2186#discussion_r595561419 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexingChain.java ## @@ -581,37 +584,59 @@ private void finishStoredFields() throw

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #2186: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #2186: URL: https://github.com/apache/lucene-solr/pull/2186#discussion_r595561232 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexingChain.java ## @@ -79,6 +79,7 @@ // Holds fields seen in each document

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #2186: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #2186: URL: https://github.com/apache/lucene-solr/pull/2186#discussion_r595560368 ## File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java ## @@ -1860,8 +1862,8 @@ public long softUpdateDocument( */

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #2186: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #2186: URL: https://github.com/apache/lucene-solr/pull/2186#discussion_r595559633 ## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfos.java ## @@ -972,6 +671,64 @@ private boolean assertNotFinished() {

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #2186: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #2186: URL: https://github.com/apache/lucene-solr/pull/2186#discussion_r595558802 ## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfos.java ## @@ -481,205 +433,102 @@ synchronized int addOrGet(

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #2186: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #2186: URL: https://github.com/apache/lucene-solr/pull/2186#discussion_r595558410 ## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfos.java ## @@ -455,8 +373,42 @@ synchronized int addOrGet( field

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #2186: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #2186: URL: https://github.com/apache/lucene-solr/pull/2186#discussion_r595557957 ## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfo.java ## @@ -130,127 +167,252 @@ public boolean checkConsistency() {

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #2186: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #2186: URL: https://github.com/apache/lucene-solr/pull/2186#discussion_r595557642 ## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfo.java ## @@ -130,127 +167,252 @@ public boolean checkConsistency() {

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #2186: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #2186: URL: https://github.com/apache/lucene-solr/pull/2186#discussion_r595557219 ## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfo.java ## @@ -130,127 +167,252 @@ public boolean checkConsistency() {

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #2186: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on a change in pull request #2186: URL: https://github.com/apache/lucene-solr/pull/2186#discussion_r595556762 ## File path: lucene/core/src/java/org/apache/lucene/index/FieldInfo.java ## @@ -111,6 +111,43 @@ public FieldInfo( /** Performs internal

[GitHub] [lucene] mayya-sharipova commented on pull request #11: LUCENE-9334 Consistency of field data structures

mayya-sharipova commented on pull request #11: URL: https://github.com/apache/lucene/pull/11#issuecomment-800620410 @s1monw Thank you for your review. I will go through your comments, and will address them. This is an auto

[GitHub] [lucene-solr] atris commented on pull request #2403: SOLR-15164: Implement Task Management Interface

atris commented on pull request #2403: URL: https://github.com/apache/lucene-solr/pull/2403#issuecomment-800495022 @madrob Fixed, please see This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [lucene-solr] atris commented on a change in pull request #2403: SOLR-15164: Implement Task Management Interface

atris commented on a change in pull request #2403: URL: https://github.com/apache/lucene-solr/pull/2403#discussion_r595401010 ## File path: solr/solr-ref-guide/src/task-management.adoc ## @@ -0,0 +1,66 @@ += Task Management +// Licensed to the Apache Software Foundation (ASF) u

[GitHub] [lucene-solr] bruno-roustant commented on pull request #2162: SOLR-15051 Blob, DRAFT WIP

bruno-roustant commented on pull request #2162: URL: https://github.com/apache/lucene-solr/pull/2162#issuecomment-800453622 Replaced by same PR https://github.com/apache/solr/pull/20 on apache/solr. This is an automated messa

[GitHub] [lucene-solr] bruno-roustant closed pull request #2162: SOLR-15051 Blob, DRAFT WIP

bruno-roustant closed pull request #2162: URL: https://github.com/apache/lucene-solr/pull/2162 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Commented] (LUCENE-9836) Fix 8.x Maven Validation and publication to work with Maven Central and HTTPS again; remove pure Maven build (did not work anymore)

[ https://issues.apache.org/jira/browse/LUCENE-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302703#comment-17302703 ] Uwe Schindler commented on LUCENE-9836: --- I will keep this issue open to investiage

[jira] [Updated] (LUCENE-9431) UnifiedHighlighter: Make WEIGHT_MATCHES the default

[ https://issues.apache.org/jira/browse/LUCENE-9431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated LUCENE-9431: - Labels: newdev (was: ) Priority: Minor (was: Blocker) > UnifiedHighlighter: Make WEIGHT_

[jira] [Commented] (LUCENE-9431) UnifiedHighlighter: Make WEIGHT_MATCHES the default

[ https://issues.apache.org/jira/browse/LUCENE-9431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302692#comment-17302692 ] Adrien Grand commented on LUCENE-9431: -- [~dsmiley] Your above comment suggests that

[jira] [Commented] (LUCENE-9615) Expose HnswGraphBuilder index-time hyperparameters

[ https://issues.apache.org/jira/browse/LUCENE-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302669#comment-17302669 ] Michael Sokolov commented on LUCENE-9615: - Thanks [~shubhambeniwal]! > Expose H

[jira] [Resolved] (LUCENE-9639) Add unit tests for SImpleTextVector format

[ https://issues.apache.org/jira/browse/LUCENE-9639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Sokolov resolved LUCENE-9639. - Resolution: Fixed Thanks, [~zacharymorn]! > Add unit tests for SImpleTextVector format

[jira] [Resolved] (LUCENE-9615) Expose HnswGraphBuilder index-time hyperparameters

[ https://issues.apache.org/jira/browse/LUCENE-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Sokolov resolved LUCENE-9615. - Resolution: Fixed > Expose HnswGraphBuilder index-time hyperparameters > ---

[jira] [Resolved] (LUCENE-9679) Try using Math.fma to speed up vector computations

[ https://issues.apache.org/jira/browse/LUCENE-9679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Sokolov resolved LUCENE-9679. - Resolution: Won't Fix this was never a great idea, and now we have other patches achievi

[jira] [Commented] (LUCENE-9836) Fix 8.x Maven Validation and publication to work with Maven Central and HTTPS again; remove pure Maven build (did not work anymore)

[ https://issues.apache.org/jira/browse/LUCENE-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302659#comment-17302659 ] ASF subversion and git services commented on LUCENE-9836: - Commi

[jira] [Commented] (LUCENE-9836) Fix 8.x Maven Validation and publication to work with Maven Central and HTTPS again; remove pure Maven build (did not work anymore)

[ https://issues.apache.org/jira/browse/LUCENE-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302655#comment-17302655 ] ASF subversion and git services commented on LUCENE-9836: - Commi

[GitHub] [lucene-solr] uschindler merged pull request #2469: LUCENE-9836: Fix 8.x Maven Validation and publication to work with Maven Central and HTTPS again; remove pure Maven build (did not work any

uschindler merged pull request #2469: URL: https://github.com/apache/lucene-solr/pull/2469 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (LUCENE-9845) Improve encoding of HNSW graph offsets

[ https://issues.apache.org/jira/browse/LUCENE-9845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302649#comment-17302649 ] Robert Muir commented on LUCENE-9845: - {quote} So, IndexedDISI would work OK if it p

[jira] [Commented] (LUCENE-9845) Improve encoding of HNSW graph offsets

[ https://issues.apache.org/jira/browse/LUCENE-9845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302645#comment-17302645 ] Robert Muir commented on LUCENE-9845: - OK, but I don't think that is typical: we sho

[jira] [Commented] (LUCENE-9845) Improve encoding of HNSW graph offsets

[ https://issues.apache.org/jira/browse/LUCENE-9845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302631#comment-17302631 ] Michael Sokolov commented on LUCENE-9845: - It does sound tempting to attack the

[GitHub] [lucene-solr] madrob commented on a change in pull request #2403: SOLR-15164: Implement Task Management Interface

madrob commented on a change in pull request #2403: URL: https://github.com/apache/lucene-solr/pull/2403#discussion_r595245360 ## File path: solr/core/src/java/org/apache/solr/handler/component/QueryCancellationComponent.java ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache

[jira] [Commented] (LUCENE-9835) Prune git branches in lucene.git repo

[ https://issues.apache.org/jira/browse/LUCENE-9835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302564#comment-17302564 ] Jan Høydahl commented on LUCENE-9835: - To avoid 600 emails to commits@lucene list we

[jira] [Commented] (LUCENE-9663) Adding compression to terms dict from SortedSet/Sorted DocValues

[ https://issues.apache.org/jira/browse/LUCENE-9663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302487#comment-17302487 ] Adrien Grand commented on LUCENE-9663: -- +1 to backport > Adding compression to ter

[jira] [Commented] (LUCENE-9838) simd version of VectorUtil.dotProduct

[ https://issues.apache.org/jira/browse/LUCENE-9838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302462#comment-17302462 ] Robert Muir commented on LUCENE-9838: - I attached "standalone" patch (no logic chang

[jira] [Updated] (LUCENE-9838) simd version of VectorUtil.dotProduct

[ https://issues.apache.org/jira/browse/LUCENE-9838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-9838: Attachment: LUCENE-9838_standalone.patch > simd version of VectorUtil.dotProduct > ---

[jira] [Commented] (LUCENE-9827) Small segments are slower to merge due to stored fields since 8.7

[ https://issues.apache.org/jira/browse/LUCENE-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302454#comment-17302454 ] Robert Muir commented on LUCENE-9827: - [~dm] Thanks for testing and reporting back!

[jira] [Commented] (LUCENE-9843) Remove compression option on doc values

[ https://issues.apache.org/jira/browse/LUCENE-9843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302450#comment-17302450 ] Michael McCandless commented on LUCENE-9843: {quote}There is a more obvious

[jira] [Commented] (LUCENE-9663) Adding compression to terms dict from SortedSet/Sorted DocValues

[ https://issues.apache.org/jira/browse/LUCENE-9663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302448#comment-17302448 ] Michael McCandless commented on LUCENE-9663: Oh, why not backport this to 8.

[jira] [Commented] (LUCENE-9817) pathological test fixes

[ https://issues.apache.org/jira/browse/LUCENE-9817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302445#comment-17302445 ] Robert Muir commented on LUCENE-9817: - yes, I agree: a single base class with shared

[jira] [Commented] (LUCENE-9817) pathological test fixes

[ https://issues.apache.org/jira/browse/LUCENE-9817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302443#comment-17302443 ] Simon Willnauer commented on LUCENE-9817: - sure we can totally make this a base

[jira] [Commented] (LUCENE-9817) pathological test fixes

[ https://issues.apache.org/jira/browse/LUCENE-9817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302434#comment-17302434 ] Robert Muir commented on LUCENE-9817: - Above I was just referring to the total time

[GitHub] [lucene] rmuir commented on a change in pull request #18: LUCENE-9838: simd version of VectorUtil.dotProduct

rmuir commented on a change in pull request #18: URL: https://github.com/apache/lucene/pull/18#discussion_r595070477 ## File path: lucene/core/src/java/org/apache/lucene/util/VectorUtil.java ## @@ -17,16 +17,123 @@ package org.apache.lucene.util; +import java.lang.invoke.M

[GitHub] [lucene] rmuir commented on a change in pull request #18: LUCENE-9838: simd version of VectorUtil.dotProduct

rmuir commented on a change in pull request #18: URL: https://github.com/apache/lucene/pull/18#discussion_r595068893 ## File path: lucene/core/src/java/org/apache/lucene/util/VectorUtil.java ## @@ -17,16 +17,123 @@ package org.apache.lucene.util; +import java.lang.invoke.M

[jira] [Commented] (LUCENE-9836) Fix 8.x Maven Validation and publication to work with Maven Central and HTTPS again; remove pure Maven build (did not work anymore)

[ https://issues.apache.org/jira/browse/LUCENE-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302425#comment-17302425 ] Dawid Weiss commented on LUCENE-9836: - +1 to commit! > Fix 8.x Maven Validation and

[jira] [Commented] (LUCENE-9836) Fix 8.x Maven Validation and publication to work with Maven Central and HTTPS again; remove pure Maven build (did not work anymore)

[ https://issues.apache.org/jira/browse/LUCENE-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302418#comment-17302418 ] Uwe Schindler commented on LUCENE-9836: --- I did a quick test with some Solr plugin

[jira] [Commented] (LUCENE-9817) pathological test fixes

[ https://issues.apache.org/jira/browse/LUCENE-9817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302410#comment-17302410 ] Simon Willnauer commented on LUCENE-9817: - thanks rob for taking the time to do

[jira] [Commented] (LUCENE-9836) Fix 8.x Maven Validation and publication to work with Maven Central and HTTPS again; remove pure Maven build (did not work anymore)

[ https://issues.apache.org/jira/browse/LUCENE-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302362#comment-17302362 ] Uwe Schindler commented on LUCENE-9836: --- Done. > Fix 8.x Maven Validation and pub

[jira] [Commented] (LUCENE-9836) Fix 8.x Maven Validation and publication to work with Maven Central and HTTPS again; remove pure Maven build (did not work anymore)

[ https://issues.apache.org/jira/browse/LUCENE-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302345#comment-17302345 ] Uwe Schindler commented on LUCENE-9836: --- We should do this, as I figured out that

[jira] [Commented] (LUCENE-9836) Fix 8.x Maven Validation and publication to work with Maven Central and HTTPS again; remove pure Maven build (did not work anymore)

[ https://issues.apache.org/jira/browse/LUCENE-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302344#comment-17302344 ] Dawid Weiss commented on LUCENE-9836: - I believe so. > Fix 8.x Maven Validation and

[jira] [Comment Edited] (LUCENE-9836) Fix 8.x Maven Validation and publication to work with Maven Central and HTTPS again; remove pure Maven build (did not work anymore)

[ https://issues.apache.org/jira/browse/LUCENE-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302337#comment-17302337 ] Uwe Schindler edited comment on LUCENE-9836 at 3/16/21, 8:53 AM: -

[jira] [Commented] (LUCENE-9836) Fix 8.x Maven Validation and publication to work with Maven Central and HTTPS again; remove pure Maven build (did not work anymore)

[ https://issues.apache.org/jira/browse/LUCENE-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302337#comment-17302337 ] Uwe Schindler commented on LUCENE-9836: --- The POM files still contain all test depe

[jira] [Updated] (LUCENE-9836) Fix 8.x Maven Validation and publication to work with Maven Central and HTTPS again; remove pure Maven build (did not work anymore)

[ https://issues.apache.org/jira/browse/LUCENE-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-9836: -- Summary: Fix 8.x Maven Validation and publication to work with Maven Central and HTTPS again;

[GitHub] [lucene] uschindler commented on pull request #18: LUCENE-9838: simd version of VectorUtil.dotProduct

uschindler commented on pull request #18: URL: https://github.com/apache/lucene/pull/18#issuecomment-800070555 We should add a small test that verifies the following: If JDK version is exactly 16 (not 15, not 17 - as we don't know if this works later anymore when incubator releases theclas

[GitHub] [lucene] uschindler edited a comment on pull request #18: LUCENE-9838: simd version of VectorUtil.dotProduct

uschindler edited a comment on pull request #18: URL: https://github.com/apache/lucene/pull/18#issuecomment-800065901 Another idea: We can remove the Methodhandles with the crazy try-catch block, if we'd define a static functional interface in this class, that is implemented by VectorUtil

[GitHub] [lucene] uschindler edited a comment on pull request #18: LUCENE-9838: simd version of VectorUtil.dotProduct

uschindler edited a comment on pull request #18: URL: https://github.com/apache/lucene/pull/18#issuecomment-800065901 Another idea: We can remove the Methodhandles with the crazy try-catch block, if we'd define a static functional interface in this class, that is implemented by VectorUtil

[GitHub] [lucene] uschindler commented on pull request #18: LUCENE-9838: simd version of VectorUtil.dotProduct

uschindler commented on pull request #18: URL: https://github.com/apache/lucene/pull/18#issuecomment-800065901 Another idea: We can remove the Methodhandles with the crazy try-catch block, if we'd define a static functional interface in this class, that is implemented by VectorUtil and als

[GitHub] [lucene] uschindler commented on a change in pull request #18: LUCENE-9838: simd version of VectorUtil.dotProduct

uschindler commented on a change in pull request #18: URL: https://github.com/apache/lucene/pull/18#discussion_r594952973 ## File path: lucene/core/src/java/org/apache/lucene/util/VectorUtil.java ## @@ -17,16 +17,123 @@ package org.apache.lucene.util; +import java.lang.inv

[GitHub] [lucene] uschindler commented on a change in pull request #18: LUCENE-9838: simd version of VectorUtil.dotProduct

uschindler commented on a change in pull request #18: URL: https://github.com/apache/lucene/pull/18#discussion_r594952973 ## File path: lucene/core/src/java/org/apache/lucene/util/VectorUtil.java ## @@ -17,16 +17,123 @@ package org.apache.lucene.util; +import java.lang.inv

[GitHub] [lucene] uschindler commented on a change in pull request #18: LUCENE-9838: simd version of VectorUtil.dotProduct

uschindler commented on a change in pull request #18: URL: https://github.com/apache/lucene/pull/18#discussion_r594941232 ## File path: lucene/core/src/java/org/apache/lucene/util/VectorUtil.java ## @@ -17,16 +17,123 @@ package org.apache.lucene.util; +import java.lang.inv

[GitHub] [lucene] uschindler commented on a change in pull request #18: LUCENE-9838: simd version of VectorUtil.dotProduct

uschindler commented on a change in pull request #18: URL: https://github.com/apache/lucene/pull/18#discussion_r594943346 ## File path: lucene/core/src/java/org/apache/lucene/util/VectorUtil.java ## @@ -17,16 +17,123 @@ package org.apache.lucene.util; +import java.lang.inv

[jira] [Commented] (LUCENE-9827) Small segments are slower to merge due to stored fields since 8.7

[ https://issues.apache.org/jira/browse/LUCENE-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302307#comment-17302307 ] Daniel Mitterdorfer commented on LUCENE-9827: - I ran a benchmark with a logg

[jira] [Updated] (LUCENE-9827) Small segments are slower to merge due to stored fields since 8.7

[ https://issues.apache.org/jira/browse/LUCENE-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Mitterdorfer updated LUCENE-9827: Attachment: log-and-lucene-9827.patch > Small segments are slower to merge due to

[jira] [Updated] (LUCENE-9827) Small segments are slower to merge due to stored fields since 8.7

[ https://issues.apache.org/jira/browse/LUCENE-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Mitterdorfer updated LUCENE-9827: Attachment: merge-type-by-version.png > Small segments are slower to merge due to

[jira] [Updated] (LUCENE-9827) Small segments are slower to merge due to stored fields since 8.7

[ https://issues.apache.org/jira/browse/LUCENE-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Mitterdorfer updated LUCENE-9827: Attachment: total-merge-time-by-num-docs.png > Small segments are slower to merge

[jira] [Updated] (LUCENE-9827) Small segments are slower to merge due to stored fields since 8.7

[ https://issues.apache.org/jira/browse/LUCENE-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Mitterdorfer updated LUCENE-9827: Attachment: merge-count-by-num-docs.png > Small segments are slower to merge due t

[GitHub] [lucene] dweiss commented on a change in pull request #18: LUCENE-9838: simd version of VectorUtil.dotProduct

dweiss commented on a change in pull request #18: URL: https://github.com/apache/lucene/pull/18#discussion_r594923342 ## File path: lucene/core/src/java/org/apache/lucene/util/VectorUtil.java ## @@ -17,16 +17,123 @@ package org.apache.lucene.util; +import java.lang.invoke.

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2469: LUCENE-9836: First stab at rewrite to maven-resolver-ant-tasks

dweiss commented on a change in pull request #2469: URL: https://github.com/apache/lucene-solr/pull/2469#discussion_r594919454 ## File path: dev-tools/maven/pom.xml.template ## @@ -156,317 +130,28 @@ - - - - de.thetaphi - forbid