mayya-sharipova commented on a change in pull request #2186:
URL: https://github.com/apache/lucene-solr/pull/2186#discussion_r595560368



##########
File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
##########
@@ -1860,8 +1862,8 @@ public long softUpdateDocument(
    */
   public long updateNumericDocValue(Term term, String field, long value) 
throws IOException {
     ensureOpen();
-    if (!globalFieldNumberMap.contains(field, DocValuesType.NUMERIC)) {
-      throw new IllegalArgumentException("can only update existing 
numeric-docvalues fields!");
+    if (globalFieldNumberMap.containsDvOnlyField(field, DocValuesType.NUMERIC) 
== false) {
+      throw new IllegalArgumentException("can only update existing numeric 
docvalues only fields!");
     }

Review comment:
       Addressed 
[here](https://github.com/apache/lucene/pull/11/commits/0fe3493110ac2a5f750ad41f732436daff6c69f5#diff-b81932cf39b70347481b9659dd55b9b373427c2992cdacdfbc10ff8f4ea9eec0L482)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to