mayya-sharipova commented on a change in pull request #2186:
URL: https://github.com/apache/lucene-solr/pull/2186#discussion_r595562263
##########
File path: lucene/core/src/java/org/apache/lucene/index/IndexingChain.java
##########
@@ -581,37 +584,59 @@ private void finishStoredFields() throws IOException {
}
void processDocument(int docID, Iterable<? extends IndexableField> document)
throws IOException {
-
- // How many indexed field names we've seen (collapses
- // multiple field instances by the same name):
- int fieldCount = 0;
-
+ int fieldCount =
+ 0; // How many field names we've seen (collapses multiple field
instances by the same name)
+ int indexedFieldCount = 0; // number of unique fields indexed with postings
long fieldGen = nextFieldGen++;
-
- // NOTE: we need two passes here, in case there are
- // multi-valued fields, because we must process all
- // instances of a given field at once, since the
- // analyzer is free to reuse TokenStream across fields
- // (i.e., we cannot have more than one TokenStream
- // running "at once"):
Review comment:
I am not sure, as I did not study deeply of termHash. But just in case,
I've added this comment back
[here](https://github.com/apache/lucene/pull/11/commits/0fe3493110ac2a5f750ad41f732436daff6c69f5#diff-1e11574161aacb332207eea2eb36edbf86bf3518416e4c089561f3c0fbe43e03R593)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
