dweiss commented on a change in pull request #2469:
URL: https://github.com/apache/lucene-solr/pull/2469#discussion_r594919454
##########
File path: dev-tools/maven/pom.xml.template
##########
@@ -156,317 +130,28 @@
</dependency>
</dependencies>
<build>
- <pluginManagement>
- <plugins>
- <plugin>
- <groupId>de.thetaphi</groupId>
- <artifactId>forbiddenapis</artifactId>
- <version>3.1</version>
- <configuration>
- <!--
- This is the default setting, we don't support too new Java
versions.
- The checker simply passes by default and only prints a warning.
- -->
- <failOnUnsupportedJava>false</failOnUnsupportedJava>
- <targetVersion>${java.compat.version}</targetVersion>
- <suppressAnnotations>
- <suppressAnnotation>**.SuppressForbidden</suppressAnnotation>
- </suppressAnnotations>
- </configuration>
- </plugin>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-antrun-plugin</artifactId>
- <version>1.7</version>
- </plugin>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-clean-plugin</artifactId>
- <version>2.5</version>
- </plugin>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-compiler-plugin</artifactId>
- <version>3.1</version>
- <configuration>
- <source>${java.compat.version}</source>
- <target>${java.compat.version}</target>
- <compilerArgs>
- <!-- -proc:none was added because of LOG4J2-1925, JDK-8186647,
https://github.com/apache/zookeeper/pull/317, JDK-8055048 -->
- <arg>-proc:none</arg>
- </compilerArgs>
- </configuration>
- </plugin>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-dependency-plugin</artifactId>
- <version>2.8</version>
- </plugin>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-deploy-plugin</artifactId>
- <version>2.7</version>
- </plugin>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-enforcer-plugin</artifactId>
- <version>1.3</version>
- </plugin>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-install-plugin</artifactId>
- <version>2.4</version>
- </plugin>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-jar-plugin</artifactId>
- <version>2.4</version>
- <configuration>
- <archive>
- <manifest>
-
<addDefaultSpecificationEntries>false</addDefaultSpecificationEntries>
-
<addDefaultImplementationEntries>false</addDefaultImplementationEntries>
- </manifest>
- </archive>
- </configuration>
- </plugin>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-javadoc-plugin</artifactId>
- <version>2.9.1</version>
- <configuration>
- <quiet>true</quiet>
- <additionalparam>-Xdoclint:all</additionalparam>
- <additionalparam>-Xdoclint:-missing</additionalparam>
- </configuration>
- </plugin>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-resources-plugin</artifactId>
- <version>2.6</version>
- </plugin>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-site-plugin</artifactId>
- <version>3.3</version>
- </plugin>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-surefire-plugin</artifactId>
- <version>2.17</version>
- <configuration>
- <runOrder>random</runOrder>
- <reportFormat>plain</reportFormat>
-
<workingDirectory>${project.build.directory}/test</workingDirectory>
- <redirectTestOutputToFile>true</redirectTestOutputToFile>
- <argLine>-Xmx512M</argLine>
- <systemPropertyVariables>
- <tempDir>.</tempDir>
- <java.awt.headless>true</java.awt.headless>
-
- <!-- See
<https://cwiki.apache.org/confluence/display/lucene/RunningTests>
- for a description of the tests.* system properties. -->
-
- <!-- RandomizedTesting library system properties -->
- <tests.iters>${tests.iters}</tests.iters>
- <tests.seed>${tests.seed}</tests.seed>
- <tests.nightly>${tests.nightly}</tests.nightly>
- <tests.weekly>${tests.weekly}</tests.weekly>
- <tests.awaitsfix>${tests.awaitsfix}</tests.awaitsfix>
- <tests.slow>${tests.slow}</tests.slow>
-
- <!-- Lucene/Solr-specific test system properties -->
- <jetty.testMode>1</jetty.testMode>
- <tests.codec>${tests.codec}</tests.codec>
- <tests.directory>${tests.directory}</tests.directory>
- <tests.infostream>${tests.infostream}</tests.infostream>
- <tests.locale>${tests.locale}</tests.locale>
-
<tests.luceneMatchVersion>${tests.luceneMatchVersion}</tests.luceneMatchVersion>
- <tests.multiplier>${tests.multiplier}</tests.multiplier>
-
<tests.postingsformat>${tests.postingsformat}</tests.postingsformat>
- <tests.timezone>${tests.timezone}</tests.timezone>
- <tests.verbose>${tests.verbose}</tests.verbose>
- <java.security.egd>file:/dev/./urandom</java.security.egd>
- </systemPropertyVariables>
- </configuration>
- </plugin>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-war-plugin</artifactId>
- <version>2.3</version>
- <configuration>
- <archive>
- <!-- This section should be *exactly* the same under -->
- <!-- maven-bundle-plugin and maven-war-plugin. -->
- <!-- If you make changes here, make the same changes -->
- <!-- in the other location as well. -->
- <manifestEntries>
- <Extension-Name>${project.groupId}</Extension-Name>
- <Implementation-Title>${project.groupId}</Implementation-Title>
- <Specification-Title>${project.name}</Specification-Title>
-
<Specification-Version>${specification.version}</Specification-Version>
- <Specification-Vendor>The Apache Software
Foundation</Specification-Vendor>
- <!-- impl version can be any string -->
- <Implementation-Version>${project.version} ${checkoutid} -
${user.name} - ${now.timestamp}</Implementation-Version>
- <Implementation-Vendor>The Apache Software
Foundation</Implementation-Vendor>
-
<Implementation-Vendor-Id>${project.groupId}</Implementation-Vendor-Id>
-
<X-Compile-Source-JDK>${java.compat.version}</X-Compile-Source-JDK>
-
<X-Compile-Target-JDK>${java.compat.version}</X-Compile-Target-JDK>
- </manifestEntries>
- </archive>
- </configuration>
- </plugin>
- <plugin>
- <groupId>org.codehaus.mojo</groupId>
- <artifactId>build-helper-maven-plugin</artifactId>
- <version>1.8</version>
- </plugin>
- <plugin>
- <groupId>org.codehaus.mojo</groupId>
- <artifactId>buildnumber-maven-plugin</artifactId>
- <version>1.2</version>
- </plugin>
- <plugin>
- <groupId>org.mortbay.jetty</groupId>
- <artifactId>jetty-maven-plugin</artifactId>
- <version>${jetty.version}</version>
- </plugin>
- <plugin>
- <groupId>org.codehaus.gmaven</groupId>
- <artifactId>gmaven-plugin</artifactId>
- <version>1.5</version>
- </plugin>
- </plugins>
- </pluginManagement>
<plugins>
- <plugin>
- <groupId>org.codehaus.gmaven</groupId>
- <artifactId>gmaven-plugin</artifactId>
- <executions>
- <execution>
- <id>generate-timestamps-and-get-top-level-basedir</id>
- <phase>validate</phase>
- <goals>
- <goal>execute</goal>
- </goals>
- <configuration>
- <source>
- project.properties['now.timestamp'] =
"${maven.build.timestamp}"
- project.properties['now.version'] =
("${maven.build.timestamp}" =~ /[- :]/).replaceAll(".")
- project.properties['now.year'] =
"${maven.build.timestamp}".substring(0, 4)
- project.properties['top-level'] =
(project.basedir.getAbsolutePath() =~ /[\\\\\/]maven-build.*/).replaceAll("")
- </source>
- </configuration>
- </execution>
- </executions>
- </plugin>
- <plugin>
- <groupId>org.codehaus.mojo</groupId>
- <artifactId>buildnumber-maven-plugin</artifactId>
- <executions>
- <execution>
- <phase>validate</phase>
- <goals>
- <goal>create</goal>
- </goals>
- </execution>
- </executions>
- <configuration>
- <doCheck>false</doCheck>
- <doUpdate>false</doUpdate>
- <getRevisionOnlyOnce>true</getRevisionOnlyOnce>
- <revisionOnScmFailure>NO-REVISION-AVAILABLE</revisionOnScmFailure>
- <buildNumberPropertyName>checkoutid</buildNumberPropertyName>
- <scmDirectory>${top-level}</scmDirectory>
- </configuration>
- </plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
+ <version>3.0.0-M3</version>
<executions>
<execution>
- <id>enforce-java-compat-version-and-maven-2.2.1</id>
+ <id>enforce</id>
<goals>
<goal>enforce</goal>
</goals>
<configuration>
<rules>
- <requireJavaVersion>
- <message>Java ${java.compat.version}+ is required.</message>
- <version>[${java.legacy-compat.version},)</version>
- </requireJavaVersion>
- <requireMavenVersion>
- <message>Maven 2.2.1+ is required.</message>
- <version>[2.2.1,)</version>
- </requireMavenVersion>
- <requirePluginVersions/>
+ <AlwaysFail>
Review comment:
Thanks for adding this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
