uschindler commented on a change in pull request #18:
URL: https://github.com/apache/lucene/pull/18#discussion_r594941232
##########
File path: lucene/core/src/java/org/apache/lucene/util/VectorUtil.java
##########
@@ -17,16 +17,123 @@
package org.apache.lucene.util;
+import java.lang.invoke.MethodHandle;
+import java.lang.invoke.MethodHandles;
+import java.lang.invoke.MethodType;
+import java.util.Base64;
+
/** Utilities for computations with numeric arrays */
public final class VectorUtil {
private VectorUtil() {}
+ // org.apache.lucene.util.VectorUtilSIMD#dotProduct(float[], float[])
+ private static final String SIMD_BASE64 =
+
"yv66vgAAADwAbQoAAgADBwAEDAAFAAYBABBqYXZhL2xhbmcvT2JqZWN0AQAGPGluaXQ+AQADKClW\n"
Review comment:
I think we should have the source code of this class file available for
regeneration. So anybody can compile with Java 11, but regeneration is only
possible with exact Java 16 version.
As it currently looks like I would not be sure if we can release this.
If we don't add the original source code as a java file for regeneration, we
should add source code here (as comment).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
