mayya-sharipova commented on a change in pull request #2186:
URL: https://github.com/apache/lucene-solr/pull/2186#discussion_r595564366
##########
File path: lucene/core/src/java/org/apache/lucene/index/IndexingChain.java
##########
@@ -349,7 +350,8 @@ private void writePoints(SegmentWriteState state,
Sorter.DocMap sortMap) throws
perField.pointValuesWriter.flush(state, sortMap, pointsWriter);
perField.pointValuesWriter = null;
- } else if (perField.fieldInfo.getPointDimensionCount() != 0) {
+ } else if (perField.fieldInfo != null
Review comment:
Not, always.
We first create PerField: `PerField pf = getOrAddPerField(field.name(),
fieldType);` and then initialize its FieldInfo `initializeFieldInfo(pf)`.
Initialization of FieldInfo may fail, if there is already a global field with
the same name but a different schema. So we may end up with `PerField` with a
null `fieldInfo`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]