[
https://issues.apache.org/jira/browse/SOLR-15154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296463#comment-17296463
]
ASF subversion and git services commented on SOLR-15154:
Commit d
[
https://issues.apache.org/jira/browse/SOLR-15154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296446#comment-17296446
]
ASF subversion and git services commented on SOLR-15154:
Commit 0
[
https://issues.apache.org/jira/browse/SOLR-14788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296407#comment-17296407
]
Mark Robert Miller commented on SOLR-14788:
---
A final update:
https://www.dropb
[
https://issues.apache.org/jira/browse/SOLR-15154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296388#comment-17296388
]
ASF subversion and git services commented on SOLR-15154:
Commit a
[
https://issues.apache.org/jira/browse/SOLR-15154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296389#comment-17296389
]
ASF subversion and git services commented on SOLR-15154:
Commit f
HoustonPutman merged pull request #2463:
URL: https://github.com/apache/lucene-solr/pull/2463
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
HoustonPutman commented on a change in pull request #231:
URL:
https://github.com/apache/lucene-solr-operator/pull/231#discussion_r588764883
##
File path: helm/solr-operator/Chart.yaml
##
@@ -95,4 +95,10 @@ annotations:
name: "example"
numThreads: 4
[
https://issues.apache.org/jira/browse/SOLR-15045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296373#comment-17296373
]
Michael Gibney commented on SOLR-15045:
---
fwiw, a more descriptive title for this is
[
https://issues.apache.org/jira/browse/SOLR-15223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-15223:
Fix Version/s: master (9.0)
Summary: Deprecate HttpSolrClient, mark httpcomponents dep as
David Smiley created SOLR-15223:
---
Summary: Deprecate HttpSolrClient, mark httpclient as "optional"
in SolrJ
Key: SOLR-15223
URL: https://issues.apache.org/jira/browse/SOLR-15223
Project: Solr
[
https://issues.apache.org/jira/browse/SOLR-15215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296348#comment-17296348
]
Jan Høydahl commented on SOLR-15215:
Ok, if you're leaving netty in solr-core then ZK
HoustonPutman opened a new pull request #2463:
URL: https://github.com/apache/lucene-solr/pull/2463
There is currently an issue on the Ubuntu 20.04 github runner, with
incorrect ownership being set for the `/var/solr` directory in the docker image.
HoustonPutman closed pull request #2454:
URL: https://github.com/apache/lucene-solr/pull/2454
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
David Smiley created SOLR-15222:
---
Summary: Solr should not auto-create the "userfiles" dir
Key: SOLR-15222
URL: https://issues.apache.org/jira/browse/SOLR-15222
Project: Solr
Issue Type: Improv
[
https://issues.apache.org/jira/browse/SOLR-15221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296329#comment-17296329
]
Michael Gibney commented on SOLR-15221:
---
I was initially (and still am) inclined to
[
https://issues.apache.org/jira/browse/SOLR-15221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Gibney updated SOLR-15221:
--
Attachment: SOLR-15221-initial-tests.patch
> Distributed commit errors are not propagated to th
Michael Gibney created SOLR-15221:
-
Summary: Distributed commit errors are not propagated to the
initiating client
Key: SOLR-15221
URL: https://issues.apache.org/jira/browse/SOLR-15221
Project: Solr
[
https://issues.apache.org/jira/browse/SOLR-15215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley reassigned SOLR-15215:
---
Assignee: (was: David Smiley)
While I think that'd be a fine thing, we don't have that t
[
https://issues.apache.org/jira/browse/LUCENE-9793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296308#comment-17296308
]
Dawid Weiss edited comment on LUCENE-9793 at 3/5/21, 7:59 PM:
[
https://issues.apache.org/jira/browse/LUCENE-9793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296308#comment-17296308
]
Dawid Weiss commented on LUCENE-9793:
-
!screenshot-1.png!
> Measure check/precomm
madrob opened a new pull request #2462:
URL: https://github.com/apache/lucene-solr/pull/2462
Rewrite one, ignore the other two.
This is an automated message from the Apache Git Service.
To respond to the message, please log o
[
https://issues.apache.org/jira/browse/SOLR-15215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296305#comment-17296305
]
Jan Høydahl commented on SOLR-15215:
Let’s make a plug-in/package to wrap those jars,
[
https://issues.apache.org/jira/browse/LUCENE-9793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-9793:
Attachment: screenshot-1.png
> Measure check/precommit aggregate task wall time
>
cpoerschke commented on pull request #1693:
URL: https://github.com/apache/lucene-solr/pull/1693#issuecomment-791639415
> @cpoerschke Please help to look at this PR.
Hello @limingnihao, thanks for this pull request and the 'ping' on it! Just
wanted to let you know that I spent some t
[
https://issues.apache.org/jira/browse/SOLR-15205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christine Poerschke resolved SOLR-15205.
Resolution: Won't Do
Based on https://github.com/apache/lucene-solr/pull/2442 attem
[
https://issues.apache.org/jira/browse/SOLR-15206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christine Poerschke resolved SOLR-15206.
Fix Version/s: 8.9
master (9.0)
Resolution: Fixed
> impro
cpoerschke closed pull request #2442:
URL: https://github.com/apache/lucene-solr/pull/2442
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
cpoerschke commented on a change in pull request #2442:
URL: https://github.com/apache/lucene-solr/pull/2442#discussion_r588621150
##
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseCloudSolrClient.java
##
@@ -91,6 +91,12 @@
import static org.apache.solr.
rmuir commented on pull request #2459:
URL: https://github.com/apache/lucene-solr/pull/2459#issuecomment-791621851
we can definitely do this stuff in another PR! I'm just throwing out wacky
ideas to try to help out.
This is
donnerpeter commented on pull request #2459:
URL: https://github.com/apache/lucene-solr/pull/2459#issuecomment-791614662
I've found a regression not covered by unit tests, will fix it (probably on
Monday), please don't merge yet :)
-
[
https://issues.apache.org/jira/browse/SOLR-15154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296283#comment-17296283
]
ASF subversion and git services commented on SOLR-15154:
Commit f
tflobbe merged pull request #2445:
URL: https://github.com/apache/lucene-solr/pull/2445
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
madrob merged pull request #232:
URL: https://github.com/apache/lucene-solr-operator/pull/232
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
[
https://issues.apache.org/jira/browse/SOLR-15219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296278#comment-17296278
]
ASF subversion and git services commented on SOLR-15219:
Commit 2
[
https://issues.apache.org/jira/browse/SOLR-15219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-15219.
-
Fix Version/s: 8.9
Resolution: Fixed
> TestPointFields.testIntPointFieldMultiValuedRangeFa
[
https://issues.apache.org/jira/browse/SOLR-15219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296275#comment-17296275
]
ASF subversion and git services commented on SOLR-15219:
Commit f
dsmiley merged pull request #2460:
URL: https://github.com/apache/lucene-solr/pull/2460
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/SOLR-14660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296274#comment-17296274
]
David Smiley commented on SOLR-14660:
-
Correction: Netty will stay in Solr-core for t
[
https://issues.apache.org/jira/browse/SOLR-15215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296270#comment-17296270
]
Mike Drob commented on SOLR-15215:
--
Agree with Jan, I'd like to see this available as a
[
https://issues.apache.org/jira/browse/SOLR-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296269#comment-17296269
]
David Smiley commented on SOLR-2852:
It does *not* mean that. The JDK has had an XML
donnerpeter commented on pull request #2459:
URL: https://github.com/apache/lucene-solr/pull/2459#issuecomment-791605098
A great idea about the base char! It's much simpler than what I had in mind
if Greek becomes a problem :) Should I do this in this PR or in another one?
---
HoustonPutman commented on pull request #232:
URL:
https://github.com/apache/lucene-solr-operator/pull/232#issuecomment-791603218
I think it's good to go!
This is an automated message from the Apache Git Service.
To respond
HoustonPutman commented on issue #228:
URL:
https://github.com/apache/lucene-solr-operator/issues/228#issuecomment-791601700
Reached out to legal, asking for guidance here.
[LEGAL-562](https://issues.apache.org/jira/browse/LEGAL-562)
I explained that we planned to use https://github
[
https://issues.apache.org/jira/browse/SOLR-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296253#comment-17296253
]
Mike Drob commented on SOLR-2852:
-
Does this mean that SolrJ clients will not be able to r
rmuir commented on pull request #2459:
URL: https://github.com/apache/lucene-solr/pull/2459#issuecomment-791593379
a lot of these dictionaries are encoded in legacy charsets which explains
why they conform so well to their unicode block, e.g. zero stray ASCII or
chinese or whatever in the
rmuir commented on pull request #2459:
URL: https://github.com/apache/lucene-solr/pull/2459#issuecomment-791585657
For greek, if you analyze the distribution of dictionary (I use
https://scripts.sil.org/UnicodeCharacterCount ), you can see that smallest
character in the whole dictionary is
[
https://issues.apache.org/jira/browse/SOLR-15215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296241#comment-17296241
]
David Smiley commented on SOLR-15215:
-
See [~janhoy] comment on the PR --
https://gi
rmuir commented on pull request #2459:
URL: https://github.com/apache/lucene-solr/pull/2459#issuecomment-791574562
greek dictionary has `828806` words, so the hash table alone is 3.2MB, right?
as far as encoding of actual words (`n * VINT: the word form data`), maybe
it is possible t
dsmiley commented on a change in pull request #2442:
URL: https://github.com/apache/lucene-solr/pull/2442#discussion_r588505022
##
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseCloudSolrClient.java
##
@@ -91,6 +91,12 @@
import static org.apache.solr.com
[
https://issues.apache.org/jira/browse/SOLR-15220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296185#comment-17296185
]
Tim Owen commented on SOLR-15220:
-
Example in a non-distributed search
{noformat}
{ facet
Tim Owen created SOLR-15220:
---
Summary: Json faceting allows val and count as stat/subfacet names
Key: SOLR-15220
URL: https://issues.apache.org/jira/browse/SOLR-15220
Project: Solr
Issue Type: Bug
donnerpeter edited a comment on pull request #2459:
URL: https://github.com/apache/lucene-solr/pull/2459#issuecomment-791543521
The largest dictionaries in my collection:
el_GR: 1.7 MB -> 11.1 MB
gd: 14.5 MB -> 18.3 MB
fy: 36.7 MB -> 39.3 MB
rw: remains 18.8 MB (because it's all
donnerpeter commented on pull request #2459:
URL: https://github.com/apache/lucene-solr/pull/2459#issuecomment-791543521
The largest dictionaries in my collection:
el_GR: 1.7 MB -> 11.1 MB
gd: 14.5 MB -> 18.3 MB
fy: 36.7 MB -> 39.3 MB
rw: remains 18.8 MB (because it's all affixes
rmuir commented on pull request #2459:
URL: https://github.com/apache/lucene-solr/pull/2459#issuecomment-791536656
I like the idea, optimize for the operations hunspell needs to do. do you
happen to have any more details on the memory usage increase (e.g. by
language)? I imagine things are
cpoerschke commented on a change in pull request #2442:
URL: https://github.com/apache/lucene-solr/pull/2442#discussion_r588447559
##
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseCloudSolrClient.java
##
@@ -91,6 +91,12 @@
import static org.apache.solr.
dsmiley commented on pull request #2460:
URL: https://github.com/apache/lucene-solr/pull/2460#issuecomment-791524076
I hear you but the test method that was broken didn't use that particular
method, so it didn't matter. I temporarily inserted an "assert false;" to
assure myself of this th
dsmiley opened a new pull request #2461:
URL: https://github.com/apache/lucene-solr/pull/2461
It was never truly required there.
Pervasive use of "javabin" reduces the need to care about client-side XML
speed. Better to reduce dependencies and let clients use the libs they want.
madrob commented on pull request #2460:
URL: https://github.com/apache/lucene-solr/pull/2460#issuecomment-791515684
I suspect that my change should have masked the bug that you found here, so
I'm not exactly sure how you encountered this now, but this change looks fine.
--
janhoy commented on pull request #2458:
URL: https://github.com/apache/lucene-solr/pull/2458#issuecomment-791505707
I put them in https://issues.apache.org/jira/browse/SOLR-13665. And the
reason was to enable secure connections with Zookeeper.
* To be able to use secure solr-zk communica
dsmiley opened a new pull request #2460:
URL: https://github.com/apache/lucene-solr/pull/2460
And also restore it's getRandomInts(..,..,bound) semantics to what it was --
positive or negative random values.
https://issues.apache.org/jira/browse/SOLR-15219
@madrob about a year
donnerpeter commented on a change in pull request #2459:
URL: https://github.com/apache/lucene-solr/pull/2459#discussion_r588374683
##
File path:
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/ModifyingSuggester.java
##
@@ -234,6 +234,8 @@ private void try
donnerpeter commented on a change in pull request #2459:
URL: https://github.com/apache/lucene-solr/pull/2459#discussion_r588371507
##
File path:
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java
##
@@ -272,36 +264,27 @@ int formStep() {
donnerpeter commented on a change in pull request #2459:
URL: https://github.com/apache/lucene-solr/pull/2459#discussion_r588372773
##
File path:
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java
##
@@ -1275,76 +1258,6 @@ boolean isDotICaseCha
donnerpeter commented on a change in pull request #2459:
URL: https://github.com/apache/lucene-solr/pull/2459#discussion_r588370160
##
File path:
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java
##
@@ -91,14 +90,8 @@
*/
ArrayList patte
donnerpeter opened a new pull request #2459:
URL: https://github.com/apache/lucene-solr/pull/2459
# Description
FST lookup and especially traversal are too slow
# Solution
Replace FST with a same-shaped data structure, but with nodes referring to
their paren
dsmiley opened a new pull request #2458:
URL: https://github.com/apache/lucene-solr/pull/2458
Netty is an *optional* dependency of Zookeeper; one must opt-in to use it.
Netty remains a solr-core dependency transitively via Hadoop/HDFS.
https://issues.apache.org/jira/browse/SOLR-152
[
https://issues.apache.org/jira/browse/LUCENE-9824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296071#comment-17296071
]
ASF subversion and git services commented on LUCENE-9824:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir resolved LUCENE-9824.
-
Fix Version/s: master (9.0)
Resolution: Fixed
> Hunspell suggestions: speed up ngram sco
rmuir merged pull request #2457:
URL: https://github.com/apache/lucene-solr/pull/2457
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
rmuir commented on pull request #2457:
URL: https://github.com/apache/lucene-solr/pull/2457#issuecomment-791471797
> The latter is ~10% faster, so there's some difference. `RunAutomaton.step`
has a constant-time array access branch, and it's taken quite often, it seems.
good, thanks
donnerpeter commented on pull request #2457:
URL: https://github.com/apache/lucene-solr/pull/2457#issuecomment-791466479
Thanks for the suggestion, but it works on code points as well, which I'd
prefer to leave out for now.
On Fri, 5 Mar 2021 at 15:35, Robert Muir wrote:
>
David Smiley created SOLR-15219:
---
Summary: TestPointFields.testIntPointFieldMultiValuedRangeFacet
fails for seed
Key: SOLR-15219
URL: https://issues.apache.org/jira/browse/SOLR-15219
Project: Solr
rmuir commented on a change in pull request #2457:
URL: https://github.com/apache/lucene-solr/pull/2457#discussion_r588339682
##
File path:
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/TrigramAutomaton.java
##
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the Ap
[
https://issues.apache.org/jira/browse/SOLR-15193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296043#comment-17296043
]
ASF subversion and git services commented on SOLR-15193:
Commit a
[
https://issues.apache.org/jira/browse/SOLR-15193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296042#comment-17296042
]
ASF subversion and git services commented on SOLR-15193:
Commit 1
[
https://issues.apache.org/jira/browse/SOLR-15193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296041#comment-17296041
]
ASF subversion and git services commented on SOLR-15193:
Commit b
donnerpeter commented on pull request #2457:
URL: https://github.com/apache/lucene-solr/pull/2457#issuecomment-791448721
The latter is ~10% faster, so there's some difference. `RunAutomaton.step`
has a constant-time array access branch, and it's taken quite often, it
seems.
On F
[
https://issues.apache.org/jira/browse/SOLR-15193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296039#comment-17296039
]
ASF subversion and git services commented on SOLR-15193:
Commit 6
[
https://issues.apache.org/jira/browse/SOLR-15193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296036#comment-17296036
]
ASF subversion and git services commented on SOLR-15193:
Commit 3
[
https://issues.apache.org/jira/browse/SOLR-15193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296033#comment-17296033
]
ASF subversion and git services commented on SOLR-15193:
Commit e
rmuir commented on a change in pull request #2457:
URL: https://github.com/apache/lucene-solr/pull/2457#discussion_r588317811
##
File path:
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/TrigramAutomaton.java
##
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the Ap
Lutz Weischer created SOLR-15218:
Summary: check failed on AArch64, Fedora 33
Key: SOLR-15218
URL: https://issues.apache.org/jira/browse/SOLR-15218
Project: Solr
Issue Type: Bug
Securi
[
https://issues.apache.org/jira/browse/SOLR-15189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296015#comment-17296015
]
Alexandre Rafalovitch commented on SOLR-15189:
--
I'll try to dig into this ov
[
https://issues.apache.org/jira/browse/SOLR-15189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexandre Rafalovitch reassigned SOLR-15189:
Assignee: Alexandre Rafalovitch
> Tracking downloads on new Solr site
> --
donnerpeter commented on a change in pull request #2457:
URL: https://github.com/apache/lucene-solr/pull/2457#discussion_r588288024
##
File path:
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/TrigramAutomaton.java
##
@@ -0,0 +1,122 @@
+/*
+ * Licensed to
Peter Gromov created LUCENE-9825:
Summary: Hunspell: reverse the "words" trie for faster word
lookup/suggestions
Key: LUCENE-9825
URL: https://issues.apache.org/jira/browse/LUCENE-9825
Project: Lucene
rmuir commented on a change in pull request #2457:
URL: https://github.com/apache/lucene-solr/pull/2457#discussion_r588280433
##
File path:
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/TrigramAutomaton.java
##
@@ -0,0 +1,122 @@
+/*
+ * Licensed to the Ap
[
https://issues.apache.org/jira/browse/SOLR-15217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295944#comment-17295944
]
Jan Høydahl commented on SOLR-15217:
+1.
Please consider adding a simple code somewh
janhoy commented on pull request #42:
URL: https://github.com/apache/lucene-site/pull/42#issuecomment-791250939
Actually when using venv, the `env/bin/activate` command will make `pip` an
alias to `pip3` for you, so the end result is the same. But if you have chosen
to work with your globa
donnerpeter commented on a change in pull request #2457:
URL: https://github.com/apache/lucene-solr/pull/2457#discussion_r588105332
##
File path:
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/TrigramAutomaton.java
##
@@ -0,0 +1,122 @@
+/*
+ * Licensed to
donnerpeter commented on a change in pull request #2457:
URL: https://github.com/apache/lucene-solr/pull/2457#discussion_r588101697
##
File path:
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/GeneratingSuggester.java
##
@@ -374,14 +373,9 @@ private static
donnerpeter commented on a change in pull request #2457:
URL: https://github.com/apache/lucene-solr/pull/2457#discussion_r588101236
##
File path:
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/GeneratingSuggester.java
##
@@ -152,7 +153,7 @@ private void fi
donnerpeter commented on a change in pull request #2457:
URL: https://github.com/apache/lucene-solr/pull/2457#discussion_r588100894
##
File path:
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/GeneratingSuggester.java
##
@@ -89,7 +89,8 @@
}
donnerpeter commented on a change in pull request #2457:
URL: https://github.com/apache/lucene-solr/pull/2457#discussion_r588100517
##
File path:
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/GeneratingSuggester.java
##
@@ -67,14 +66,15 @@
PriorityQu
donnerpeter commented on a change in pull request #2457:
URL: https://github.com/apache/lucene-solr/pull/2457#discussion_r588100307
##
File path:
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/GeneratingSuggester.java
##
@@ -67,14 +66,15 @@
PriorityQu
donnerpeter commented on a change in pull request #2457:
URL: https://github.com/apache/lucene-solr/pull/2457#discussion_r588099915
##
File path:
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java
##
@@ -1025,6 +1025,7 @@ private int writeNorma
donnerpeter opened a new pull request #2457:
URL: https://github.com/apache/lucene-solr/pull/2457
# Description
`ngram` is expensive (O(N*M*M)) but we can make it O(N) by precompiling some
automatons, specialized for the case `n=3` and `weighted=false`
# Solution
97 matches
Mail list logo
