donnerpeter commented on a change in pull request #2457:
URL: https://github.com/apache/lucene-solr/pull/2457#discussion_r588101697
##########
File path:
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/GeneratingSuggester.java
##########
@@ -374,14 +373,9 @@ private static int commonPrefix(String s1, String s2) {
}
// generate an n-gram score comparing s1 and s2
- private static int ngram(int n, String s1, String s2, EnumSet<NGramOptions>
opt) {
- int score = 0;
+ static int ngramScore(int n, String s1, String s2, boolean weighted) {
int l1 = s1.length();
- int l2 = s2.length();
- if (l2 == 0) {
Review comment:
Some special logic for empty dictionary entries, which we now don't have
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
