cpoerschke commented on a change in pull request #2442:
URL: https://github.com/apache/lucene-solr/pull/2442#discussion_r588447559
##########
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseCloudSolrClient.java
##########
@@ -91,6 +91,12 @@
import static org.apache.solr.common.params.CommonParams.ADMIN_PATHS;
import static org.apache.solr.common.params.CommonParams.ID;
+/**
+ * If you don't call the {@link #setIdField(String)} method and
+ * if your collection's document router has no route field then
+ * this class assumes the id field for your documents is called
+ * 'id'.
+ */
Review comment:
This is relocated (to avoid duplication) from the two deriving classes
and then reworded to try and make the context for the deprecated `setIdField`
method clearer. Other than this usage I was unable to identify anywhere else
where the cloud solr client assumes that the id field is called `"id"`. What do
you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
