donnerpeter commented on a change in pull request #2459:
URL: https://github.com/apache/lucene-solr/pull/2459#discussion_r588371507
##########
File path:
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java
##########
@@ -272,36 +264,27 @@ int formStep() {
/** Looks up Hunspell word forms from the dictionary */
IntsRef lookupWord(char[] word, int offset, int length) {
- int hash = CharsRef.stringHashCode(word, offset, length);
- if (!wordHashes.get(Math.abs(hash) % wordHashes.length())) {
- return null;
- }
-
- return lookup(words, word, offset, length);
+ return words.lookupWord(word, offset, length);
}
// only for testing
IntsRef lookupPrefix(char[] word) {
- return lookup(prefixes, word, 0, word.length);
+ return lookup(prefixes, word);
}
// only for testing
IntsRef lookupSuffix(char[] word) {
- return lookup(suffixes, word, 0, word.length);
+ return lookup(suffixes, word);
}
- IntsRef lookup(FST<IntsRef> fst, char[] word, int offset, int length) {
- if (fst == null) {
- return null;
- }
+ private IntsRef lookup(FST<IntsRef> fst, char[] word) {
Review comment:
Now queries are always on the entire array, and the fst is not-null.
This code is called only from a single test class and might deserve moving
there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
