dsmiley opened a new pull request #2460: URL: https://github.com/apache/lucene-solr/pull/2460
And also restore it's getRandomInts(..,..,bound) semantics to what it was -- positive or negative random values. https://issues.apache.org/jira/browse/SOLR-15219 @madrob about a year ago you added a static analysis checker and made various changes to comply with its recommendations. That did not introduce the bug I'm fixing here but nonetheless I can tell that the change recommended by "errorprone" (that you performed) was not the intention of the original code. The original code wanted random integers within a "bound" that is positive *or negative*. To make this clearer, I changed the parameter name to `boundPosNeg` and I changed the code to reflect "errorprone" recommendation if you intended the original semantics. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
