donnerpeter commented on a change in pull request #2457: URL: https://github.com/apache/lucene-solr/pull/2457#discussion_r588100894
########## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/GeneratingSuggester.java ########## @@ -89,7 +89,8 @@ } String lower = dictionary.toLowerCase(root); - int sc = ngram(3, word, lower, options) + commonPrefix(word, root); + int sc = + automaton.ngramScore(lower) - longerWorsePenalty(word, lower) + commonPrefix(word, root); Review comment: `ngram` has been split into `ngramScore` and penalties based on previously passed flags. The former is replaced with the automaton. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org