codaitya commented on a change in pull request #2214:
URL: https://github.com/apache/lucene-solr/pull/2214#discussion_r560716737
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90VectorReader.java
##
@@ -386,9 +387,18 @@ public int nextDoc() {
}
codaitya commented on a change in pull request #2214:
URL: https://github.com/apache/lucene-solr/pull/2214#discussion_r560719085
##
File path: lucene/core/src/test/org/apache/lucene/index/TestVectorValues.java
##
@@ -815,4 +816,47 @@ public void testSearchStrategyIdentifiers()
codaitya commented on a change in pull request #2214:
URL: https://github.com/apache/lucene-solr/pull/2214#discussion_r560718642
##
File path: lucene/core/src/test/org/apache/lucene/index/TestVectorValues.java
##
@@ -815,4 +816,47 @@ public void testSearchStrategyIdentifiers()
codaitya commented on a change in pull request #2214:
URL: https://github.com/apache/lucene-solr/pull/2214#discussion_r560718708
##
File path: lucene/core/src/test/org/apache/lucene/index/TestVectorValues.java
##
@@ -815,4 +816,47 @@ public void testSearchStrategyIdentifiers()
codaitya commented on a change in pull request #2214:
URL: https://github.com/apache/lucene-solr/pull/2214#discussion_r560718485
##
File path: lucene/core/src/test/org/apache/lucene/index/TestVectorValues.java
##
@@ -815,4 +816,47 @@ public void testSearchStrategyIdentifiers()
codaitya commented on a change in pull request #2214:
URL: https://github.com/apache/lucene-solr/pull/2214#discussion_r560718191
##
File path: lucene/core/src/test/org/apache/lucene/index/TestVectorValues.java
##
@@ -815,4 +816,47 @@ public void testSearchStrategyIdentifiers()
codaitya commented on a change in pull request #2214:
URL: https://github.com/apache/lucene-solr/pull/2214#discussion_r560716737
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90VectorReader.java
##
@@ -386,9 +387,18 @@ public int nextDoc() {
}
[
https://issues.apache.org/jira/browse/LUCENE-9679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17268316#comment-17268316
]
Robert Muir commented on LUCENE-9679:
-
I don't think its a good idea: to my knowledg
[
https://issues.apache.org/jira/browse/LUCENE-9673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17268315#comment-17268315
]
mashudong commented on LUCENE-9673:
---
I'm trying to create a patch, would upload when r
Oren Ovadia created LUCENE-9680:
---
Summary: Re-add IndexWriter.getFieldNames
Key: LUCENE-9680
URL: https://issues.apache.org/jira/browse/LUCENE-9680
Project: Lucene - Core
Issue Type: Improvemen
madrob commented on a change in pull request #2216:
URL: https://github.com/apache/lucene-solr/pull/2216#discussion_r560589531
##
File path:
solr/core/src/java/org/apache/solr/client/solrj/embedded/EmbeddedSolrServer.java
##
@@ -71,6 +71,7 @@
protected final String coreName
[
https://issues.apache.org/jira/browse/SOLR-15052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17268281#comment-17268281
]
Ilan Ginzburg commented on SOLR-15052:
--
Thanks [~noble.paul], that's perfect!
> Red
thelabdude commented on pull request #189:
URL:
https://github.com/apache/lucene-solr-operator/pull/189#issuecomment-763202577
Still need an explicit unit test for the user-provided config before this
one is ready to merge.
msokolov commented on a change in pull request #2214:
URL: https://github.com/apache/lucene-solr/pull/2214#discussion_r560546645
##
File path: lucene/core/src/test/org/apache/lucene/index/TestVectorValues.java
##
@@ -815,4 +816,47 @@ public void testSearchStrategyIdentifiers()
dsmiley commented on a change in pull request #2197:
URL: https://github.com/apache/lucene-solr/pull/2197#discussion_r560544831
##
File path: solr/docker/build.gradle
##
@@ -18,106 +18,192 @@
import com.google.common.base.Preconditions
import com.google.common.base.Strings
HoustonPutman commented on a change in pull request #2197:
URL: https://github.com/apache/lucene-solr/pull/2197#discussion_r560536332
##
File path: solr/docker/build.gradle
##
@@ -18,106 +18,192 @@
import com.google.common.base.Preconditions
import com.google.common.base.Stri
dsmiley commented on a change in pull request #2197:
URL: https://github.com/apache/lucene-solr/pull/2197#discussion_r560534771
##
File path: solr/docker/build.gradle
##
@@ -18,106 +18,192 @@
import com.google.common.base.Preconditions
import com.google.common.base.Strings
[
https://issues.apache.org/jira/browse/SOLR-15081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-15081.
-
Fix Version/s: 8.9
Assignee: David Smiley
Resolution: Fixed
> Metrics per core: r
[
https://issues.apache.org/jira/browse/SOLR-15081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17268260#comment-17268260
]
ASF subversion and git services commented on SOLR-15081:
Commit 3
HoustonPutman merged pull request #160:
URL: https://github.com/apache/lucene-solr-operator/pull/160
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
[
https://issues.apache.org/jira/browse/SOLR-15081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-15081:
Description:
The core level metrics hold some interesting information, but I don't see
information
[
https://issues.apache.org/jira/browse/SOLR-15081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17268249#comment-17268249
]
ASF subversion and git services commented on SOLR-15081:
Commit a
dsmiley merged pull request #2198:
URL: https://github.com/apache/lucene-solr/pull/2198
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/SOLR-13105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17268241#comment-17268241
]
David Eric Pugh commented on SOLR-13105:
[~ctargett]while I don't have any specia
thelabdude commented on a change in pull request #189:
URL:
https://github.com/apache/lucene-solr-operator/pull/189#discussion_r560505507
##
File path: controllers/solrprometheusexporter_controller.go
##
@@ -92,10 +124,18 @@ func (r *SolrPrometheusExporterReconciler) Reconcile
HoustonPutman commented on a change in pull request #189:
URL:
https://github.com/apache/lucene-solr-operator/pull/189#discussion_r560492756
##
File path: controllers/solrprometheusexporter_controller.go
##
@@ -92,10 +124,18 @@ func (r *SolrPrometheusExporterReconciler) Reconc
[
https://issues.apache.org/jira/browse/SOLR-13105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17268218#comment-17268218
]
Joel Bernstein commented on SOLR-13105:
---
Yeah, I think the branch you created might
[
https://issues.apache.org/jira/browse/SOLR-14608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17268207#comment-17268207
]
ASF subversion and git services commented on SOLR-14608:
Commit 6
[
https://issues.apache.org/jira/browse/SOLR-14608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17268208#comment-17268208
]
ASF subversion and git services commented on SOLR-14608:
Commit 5
[
https://issues.apache.org/jira/browse/LUCENE-9669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17268193#comment-17268193
]
ASF subversion and git services commented on LUCENE-9669:
-
Commi
s1monw merged pull request #2221:
URL: https://github.com/apache/lucene-solr/pull/2221
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
thelabdude opened a new pull request #189:
URL: https://github.com/apache/lucene-solr-operator/pull/189
Allow users to override the Prometheus exporter config (XML) via a
user-provided ConfigMap supplied via the existing
`prometheusExporter.Spec.CustomKubeOptions.ConfigMapOptions.ProvidedC
[
https://issues.apache.org/jira/browse/SOLR-15079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris M. Hostetter resolved SOLR-15079.
---
Fix Version/s: 8.9
master (9.0)
Resolution: Fixed
> Block C
[
https://issues.apache.org/jira/browse/SOLR-15079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17268180#comment-17268180
]
ASF subversion and git services commented on SOLR-15079:
Commit a
[
https://issues.apache.org/jira/browse/SOLR-13105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17268169#comment-17268169
]
Cassandra Targett commented on SOLR-13105:
--
So what are the suggestions here the
s1monw commented on a change in pull request #2214:
URL: https://github.com/apache/lucene-solr/pull/2214#discussion_r560412822
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90VectorReader.java
##
@@ -386,9 +387,18 @@ public int nextDoc() {
}
HoustonPutman edited a comment on pull request #:
URL: https://github.com/apache/lucene-solr/pull/#issuecomment-762977652
Since Base64.Encoder and Base64.Decoder are thread-safe, it might be better
to have static instantiations of each for each class here, instead of
generating one
[
https://issues.apache.org/jira/browse/SOLR-15079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17268133#comment-17268133
]
ASF subversion and git services commented on SOLR-15079:
Commit a
[
https://issues.apache.org/jira/browse/SOLR-14608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17268132#comment-17268132
]
ASF subversion and git services commented on SOLR-14608:
Commit 9
HoustonPutman opened a new pull request #188:
URL: https://github.com/apache/lucene-solr-operator/pull/188
Fixes: #185
This includes the following CRD deprecations:
- `SolrCloud.spec.solrPodPolicy`
- `SolrCloud.spec.dataPvcSpec`
- `SolrCloud.spec.backupRestoreVolume`
- `S
[
https://issues.apache.org/jira/browse/SOLR-15087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski reassigned SOLR-15087:
--
Assignee: Jason Gerlowski
> Allow backup restoration to existing collections
> ---
[
https://issues.apache.org/jira/browse/SOLR-15080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17268083#comment-17268083
]
Jason Gerlowski edited comment on SOLR-15080 at 1/19/21, 5:47 PM:
-
[
https://issues.apache.org/jira/browse/SOLR-15080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17268083#comment-17268083
]
Jason Gerlowski edited comment on SOLR-15080 at 1/19/21, 5:47 PM:
-
[
https://issues.apache.org/jira/browse/SOLR-15080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17268083#comment-17268083
]
Jason Gerlowski edited comment on SOLR-15080 at 1/19/21, 5:47 PM:
-
[
https://issues.apache.org/jira/browse/SOLR-15080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17268083#comment-17268083
]
Jason Gerlowski edited comment on SOLR-15080 at 1/19/21, 5:46 PM:
-
[
https://issues.apache.org/jira/browse/SOLR-15080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17268083#comment-17268083
]
Jason Gerlowski commented on SOLR-15080:
bq. I know some of these issues belong
HoustonPutman commented on pull request #:
URL: https://github.com/apache/lucene-solr/pull/#issuecomment-762977652
Since Base64.Encoder and Base64.Decoder are thread-safe, it might be better
to have static implementations of each for each class here, instead of
generating one per r
Michael Sokolov created LUCENE-9679:
---
Summary: Try using Math.fma to speed up vector computations
Key: LUCENE-9679
URL: https://issues.apache.org/jira/browse/LUCENE-9679
Project: Lucene - Core
codaitya commented on a change in pull request #2214:
URL: https://github.com/apache/lucene-solr/pull/2214#discussion_r560315821
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90VectorReader.java
##
@@ -386,9 +387,18 @@ public int nextDoc() {
}
[
https://issues.apache.org/jira/browse/SOLR-12613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17268017#comment-17268017
]
Houston Putman commented on SOLR-12613:
---
Yeah, definitely misinterpreted the scope
[
https://issues.apache.org/jira/browse/LUCENE-9670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17268007#comment-17268007
]
Dawid Weiss commented on LUCENE-9670:
-
Based on the inspection of gradle's code I th
[
https://issues.apache.org/jira/browse/SOLR-13608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17268005#comment-17268005
]
Jason Gerlowski commented on SOLR-13608:
I'm going to take on this issue as a par
codaitya commented on a change in pull request #2214:
URL: https://github.com/apache/lucene-solr/pull/2214#discussion_r560295398
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90VectorReader.java
##
@@ -387,8 +387,40 @@ public int nextDoc() {
[
https://issues.apache.org/jira/browse/SOLR-13608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski reassigned SOLR-13608:
--
Assignee: Jason Gerlowski (was: Cao Manh Dat)
> Incremental backup for Solr
> ---
[
https://issues.apache.org/jira/browse/SOLR-13608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-13608:
---
Parent: SOLR-15086
Issue Type: Sub-task (was: Improvement)
> Incremental backup for
Jason Gerlowski created SOLR-15091:
--
Summary: Allow backup/restoration to Microsoft's ABS blobstore
Key: SOLR-15091
URL: https://issues.apache.org/jira/browse/SOLR-15091
Project: Solr
Issue
Jason Gerlowski created SOLR-15090:
--
Summary: Allow backups to GCS (Google Cloud Storage)
Key: SOLR-15090
URL: https://issues.apache.org/jira/browse/SOLR-15090
Project: Solr
Issue Type: Sub-
Jason Gerlowski created SOLR-15089:
--
Summary: Allow backup/restoration to Amazon's S3 blobstore
Key: SOLR-15089
URL: https://issues.apache.org/jira/browse/SOLR-15089
Project: Solr
Issue Typ
Jason Gerlowski created SOLR-15088:
--
Summary: Backups should detect corruption during file upload
Key: SOLR-15088
URL: https://issues.apache.org/jira/browse/SOLR-15088
Project: Solr
Issue Ty
Jason Gerlowski created SOLR-15087:
--
Summary: Allow backup restoration to existing collections
Key: SOLR-15087
URL: https://issues.apache.org/jira/browse/SOLR-15087
Project: Solr
Issue Type:
[
https://issues.apache.org/jira/browse/LUCENE-9670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17267993#comment-17267993
]
Dawid Weiss commented on LUCENE-9670:
-
I don't think it'll work. Something closes th
Jason Gerlowski created SOLR-15086:
--
Summary: SIP-12 Implementation Umbrella
Key: SOLR-15086
URL: https://issues.apache.org/jira/browse/SOLR-15086
Project: Solr
Issue Type: New Feature
[
https://issues.apache.org/jira/browse/LUCENE-9670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17267979#comment-17267979
]
Dawid Weiss commented on LUCENE-9670:
-
Hi Mike. I think I see a potential cause of t
HoustonPutman commented on a change in pull request #2197:
URL: https://github.com/apache/lucene-solr/pull/2197#discussion_r560269157
##
File path: solr/docker/build.gradle
##
@@ -18,106 +18,192 @@
import com.google.common.base.Preconditions
import com.google.common.base.Stri
[
https://issues.apache.org/jira/browse/LUCENE-9661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17267970#comment-17267970
]
Michael McCandless commented on LUCENE-9661:
Thank you [~danmuzi]! I'm glad
dweiss commented on a change in pull request #2207:
URL: https://github.com/apache/lucene-solr/pull/2207#discussion_r560255360
##
File path:
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/SpellChecker.java
##
@@ -24,22 +24,24 @@
*/
public class SpellChe
[
https://issues.apache.org/jira/browse/LUCENE-9670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17267958#comment-17267958
]
Michael McCandless commented on LUCENE-9670:
{quote}Well, you could try wipi
donnerpeter commented on a change in pull request #2207:
URL: https://github.com/apache/lucene-solr/pull/2207#discussion_r560253805
##
File path:
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/SpellChecker.java
##
@@ -24,22 +24,24 @@
*/
public class Spe
[
https://issues.apache.org/jira/browse/LUCENE-9670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17267957#comment-17267957
]
Dawid Weiss commented on LUCENE-9670:
-
Well, you could try wiping that global gradle
[
https://issues.apache.org/jira/browse/LUCENE-9670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17267953#comment-17267953
]
Michael McCandless commented on LUCENE-9670:
Thanks [~dweiss] – maybe it is
[
https://issues.apache.org/jira/browse/LUCENE-9670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17267948#comment-17267948
]
Dawid Weiss commented on LUCENE-9670:
-
I'll take a look at gradle code later on, Mik
msokolov commented on a change in pull request #2214:
URL: https://github.com/apache/lucene-solr/pull/2214#discussion_r560234117
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90VectorReader.java
##
@@ -387,8 +387,40 @@ public int nextDoc() {
[
https://issues.apache.org/jira/browse/LUCENE-9670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17267946#comment-17267946
]
Dawid Weiss commented on LUCENE-9670:
-
Looks like a concurrency issue to me. Deep do
[
https://issues.apache.org/jira/browse/LUCENE-9670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17267937#comment-17267937
]
Michael McCandless commented on LUCENE-9670:
It is especially odd how someti
[
https://issues.apache.org/jira/browse/LUCENE-9670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17267935#comment-17267935
]
Michael McCandless commented on LUCENE-9670:
{quote}Does it happen on comman
dweiss commented on a change in pull request #2207:
URL: https://github.com/apache/lucene-solr/pull/2207#discussion_r56084
##
File path:
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/SpellChecker.java
##
@@ -24,22 +24,24 @@
*/
public class SpellChe
[
https://issues.apache.org/jira/browse/LUCENE-9670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17267918#comment-17267918
]
Dawid Weiss commented on LUCENE-9670:
-
Does it happen on command-line for you? Maybe
[
https://issues.apache.org/jira/browse/LUCENE-9670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17267902#comment-17267902
]
Michael McCandless commented on LUCENE-9670:
Well, it failed with {{--debug}
[
https://issues.apache.org/jira/browse/LUCENE-9670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17267899#comment-17267899
]
Dawid Weiss commented on LUCENE-9670:
-
I don't know. Do you get the same behavior fr
donnerpeter commented on a change in pull request #2207:
URL: https://github.com/apache/lucene-solr/pull/2207#discussion_r560195271
##
File path:
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/SpellChecker.java
##
@@ -24,22 +24,24 @@
*/
public class Spe
[
https://issues.apache.org/jira/browse/LUCENE-9670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17267898#comment-17267898
]
Michael McCandless commented on LUCENE-9670:
And it prints this fun warning,
s1monw commented on a change in pull request #2214:
URL: https://github.com/apache/lucene-solr/pull/2214#discussion_r560189606
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90VectorReader.java
##
@@ -387,8 +387,40 @@ public int nextDoc() {
@
s1monw commented on a change in pull request #2214:
URL: https://github.com/apache/lucene-solr/pull/2214#discussion_r560189755
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90VectorReader.java
##
@@ -387,8 +387,40 @@ public int nextDoc() {
@
[
https://issues.apache.org/jira/browse/LUCENE-9670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17267897#comment-17267897
]
Michael McCandless commented on LUCENE-9670:
{quote}I will next try adding {
[
https://issues.apache.org/jira/browse/LUCENE-9670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17267896#comment-17267896
]
Michael McCandless commented on LUCENE-9670:
Well, last night's run failed a
MarcusSorealheis commented on pull request #2220:
URL: https://github.com/apache/lucene-solr/pull/2220#issuecomment-762850831
I'll fix the test failure
This is an automated message from the Apache Git Service.
To respond to t
[
https://issues.apache.org/jira/browse/LUCENE-9673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17267892#comment-17267892
]
Michael McCandless commented on LUCENE-9673:
{quote}IMHO, ByteBlockPool do n
[
https://issues.apache.org/jira/browse/LUCENE-9663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17267890#comment-17267890
]
Michael McCandless commented on LUCENE-9663:
{quote}(I didnot count dvd file
dweiss commented on a change in pull request #2207:
URL: https://github.com/apache/lucene-solr/pull/2207#discussion_r560184335
##
File path:
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/SpellChecker.java
##
@@ -24,22 +24,24 @@
*/
public class SpellChe
donnerpeter commented on a change in pull request #2207:
URL: https://github.com/apache/lucene-solr/pull/2207#discussion_r560179093
##
File path:
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/SpellChecker.java
##
@@ -24,22 +24,24 @@
*/
public class Spe
dweiss commented on a change in pull request #2207:
URL: https://github.com/apache/lucene-solr/pull/2207#discussion_r560161656
##
File path:
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/SpellChecker.java
##
@@ -24,22 +24,24 @@
*/
public class SpellChe
[
https://issues.apache.org/jira/browse/SOLR-15052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17267866#comment-17267866
]
Noble Paul commented on SOLR-15052:
---
I did a very crude test where I assumed that there
dweiss commented on a change in pull request #2207:
URL: https://github.com/apache/lucene-solr/pull/2207#discussion_r560144840
##
File path:
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/SpellChecker.java
##
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apach
donnerpeter commented on a change in pull request #2207:
URL: https://github.com/apache/lucene-solr/pull/2207#discussion_r560143280
##
File path:
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/SpellChecker.java
##
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the
sigram commented on a change in pull request #2199:
URL: https://github.com/apache/lucene-solr/pull/2199#discussion_r560111293
##
File path:
solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementFactory.java
##
@@ -171,14 +174,17 @@ public AffinityPlace
sigram commented on a change in pull request #2199:
URL: https://github.com/apache/lucene-solr/pull/2199#discussion_r560104669
##
File path:
solr/core/src/java/org/apache/solr/cluster/placement/impl/SimpleClusterAbstractionsImpl.java
##
@@ -324,7 +324,7 @@ public int hashCode(
sigram commented on a change in pull request #2199:
URL: https://github.com/apache/lucene-solr/pull/2199#discussion_r560099853
##
File path:
solr/core/src/java/org/apache/solr/cloud/api/collections/DeleteCollectionCmd.java
##
@@ -92,6 +98,19 @@ public void call(ClusterState st
sigram commented on a change in pull request #2199:
URL: https://github.com/apache/lucene-solr/pull/2199#discussion_r560099853
##
File path:
solr/core/src/java/org/apache/solr/cloud/api/collections/DeleteCollectionCmd.java
##
@@ -92,6 +98,19 @@ public void call(ClusterState st
sigram commented on a change in pull request #2199:
URL: https://github.com/apache/lucene-solr/pull/2199#discussion_r560098602
##
File path: solr/core/src/java/org/apache/solr/cloud/ExclusiveSliceProperty.java
##
@@ -74,8 +74,8 @@
ExclusiveSliceProperty(ClusterState clusterS
asalamon74 opened a new pull request #:
URL: https://github.com/apache/lucene-solr/pull/
# Description
Java8 has a builtin Base64 encoder and decoder, there is no need to use
commons-codec for this purpose.
# Solution
Eliminate commons-codec Base64 u
1 - 100 of 123 matches
Mail list logo
