codaitya commented on a change in pull request #2214:
URL: https://github.com/apache/lucene-solr/pull/2214#discussion_r560716737
##########
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90VectorReader.java
##########
@@ -386,9 +387,18 @@ public int nextDoc() {
}
@Override
- public int advance(int target) throws IOException {
- // We could do better by log-binary search in ordToDoc, but this is
never used
- return slowAdvance(target);
+ public int advance(int target) {
+ assert docID() < target;
+ ord = Arrays.binarySearch(fieldEntry.ordToDoc, ord + 1,
fieldEntry.ordToDoc.length, target);
+ if (ord < 0) {
+ ord = -(ord + 1);
+ }
+ if (ord == fieldEntry.ordToDoc.length) {
Review comment:
I think the range of values for `ord` will be
`[0,fieldEntry.ordToDoc.length]`, so we dont need a `>` check ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
