sigram commented on a change in pull request #2199:
URL: https://github.com/apache/lucene-solr/pull/2199#discussion_r560099853
##########
File path:
solr/core/src/java/org/apache/solr/cloud/api/collections/DeleteCollectionCmd.java
##########
@@ -92,6 +98,19 @@ public void call(ClusterState state, ZkNodeProps message,
@SuppressWarnings({"ra
collection = extCollection;
}
+ PlacementPlugin placementPlugin =
ocmh.overseer.getCoreContainer().getPlacementPluginFactory().createPluginInstance();
Review comment:
The check could be simplified in the plugin if it only knew that we're
deleting the whole collection. I guess we could create a
`DeleteCollectionRequest` to let it know the type of modification we want to do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
