sigram commented on a change in pull request #2199:
URL: https://github.com/apache/lucene-solr/pull/2199#discussion_r560111293
##########
File path:
solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementFactory.java
##########
@@ -171,14 +174,17 @@ public AffinityPlacementConfig getConfig() {
private final long prioritizedFreeDiskGB;
+ private final Map<String, String> withCollections;
Review comment:
There's no reason not to extend this to N:1 (N primary collections with
1 secondary), I just followed the model that was present in 8x.
However, the way this co-location is implemented now may degrade the
placements if we allow N:1 or N:N models, because of the pre-filtering approach
we could quickly run out of candidate nodes for placements. So I prefer to
focus on implementing 1:1 now and making sure it works well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
