codaitya commented on a change in pull request #2214:
URL: https://github.com/apache/lucene-solr/pull/2214#discussion_r560295398
##########
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90VectorReader.java
##########
@@ -387,8 +387,40 @@ public int nextDoc() {
@Override
public int advance(int target) throws IOException {
- // We could do better by log-binary search in ordToDoc, but this is
never used
- return slowAdvance(target);
+ assert docID() < target;
+ int idx = binarySearch(target);
Review comment:
Yes I like the idea of not maintaining our own binary search. Updated
the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
