dsmiley commented on a change in pull request #2197:
URL: https://github.com/apache/lucene-solr/pull/2197#discussion_r559091594
##
File path: solr/docker/build.gradle
##
@@ -18,106 +18,192 @@
import com.google.common.base.Preconditions
import com.google.common.base.Strings
dsmiley commented on a change in pull request #2197:
URL: https://github.com/apache/lucene-solr/pull/2197#discussion_r559089095
##
File path: solr/docker/build.gradle
##
@@ -18,106 +18,192 @@
import com.google.common.base.Preconditions
import com.google.common.base.Strings
[
https://issues.apache.org/jira/browse/SOLR-14155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Noble Paul resolved SOLR-14155.
---
Fix Version/s: 8.8
Resolution: Fixed
> Load all other SolrCore plugins from packages
> ---
[
https://issues.apache.org/jira/browse/SOLR-15052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17266681#comment-17266681
]
ASF subversion and git services commented on SOLR-15052:
Commit 4
[
https://issues.apache.org/jira/browse/SOLR-15052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17266680#comment-17266680
]
ASF subversion and git services commented on SOLR-15052:
Commit 6
zacharymorn commented on pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-761700207
> If it returns 0, there may be more to read, just not yet available. This
is important for asynchronous channels!
Oh I see! I guess since it's reading into a buff
zacharymorn commented on a change in pull request #2205:
URL: https://github.com/apache/lucene-solr/pull/2205#discussion_r559052772
##
File path:
lucene/core/src/java/org/apache/lucene/search/DisjunctionMaxScorer.java
##
@@ -50,7 +50,7 @@
if (tieBreakerMultiplier < 0 || t
jpountz commented on a change in pull request #2205:
URL: https://github.com/apache/lucene-solr/pull/2205#discussion_r559043667
##
File path:
lucene/core/src/java/org/apache/lucene/search/DisjunctionMaxScorer.java
##
@@ -50,7 +50,7 @@
if (tieBreakerMultiplier < 0 || tieBr
jpountz commented on a change in pull request #2212:
URL: https://github.com/apache/lucene-solr/pull/2212#discussion_r559039707
##
File path: lucene/core/src/java/org/apache/lucene/index/DirectoryReader.java
##
@@ -104,6 +105,17 @@ public static DirectoryReader open(final Index
zacharymorn commented on a change in pull request #2205:
URL: https://github.com/apache/lucene-solr/pull/2205#discussion_r559041435
##
File path: lucene/core/src/java/org/apache/lucene/search/WANDScorer.java
##
@@ -319,7 +356,10 @@ private void pushBackLeads(int target) throws
zacharymorn commented on a change in pull request #2205:
URL: https://github.com/apache/lucene-solr/pull/2205#discussion_r559041326
##
File path:
lucene/core/src/java/org/apache/lucene/search/DisjunctionMaxScorer.java
##
@@ -50,7 +50,7 @@
if (tieBreakerMultiplier < 0 || t
[
https://issues.apache.org/jira/browse/SOLR-12613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1725#comment-1725
]
Jan Høydahl commented on SOLR-12613:
The scope of this jira was only to rename the UI
uschindler edited a comment on pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-761664193
FileChannel#read is documented to return -1 on EOF. If it returns 0, there
may be more to read, just not yet available. This is important for asynchronous
channels
uschindler commented on pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-761664193
FileChannel#read is documented to return -1 on EOF. If it returns 0, there
may be more to read, just not yet acailable. This is important for asynchronous
channels!
---
zacharymorn commented on pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-761623319
> The issue with seek to filesize is well-known to me, that was also my
first idea I had yesterday in the evening. But I was ready to go to bed and of
course I had a bee
zacharymorn commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r559025722
##
File path:
lucene/misc/src/test/org/apache/lucene/misc/store/TestDirectIODirectory.java
##
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Sof
zacharymorn commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r559025677
##
File path:
lucene/misc/src/test/org/apache/lucene/misc/store/TestDirectIODirectory.java
##
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Sof
janhoy commented on pull request #1435:
URL: https://github.com/apache/lucene-solr/pull/1435#issuecomment-761613514
I have understood it is the “future”, or rather the new normal. If I’m not
mistaken, some people need to install some package before being able to use
Solr’s current unit.d s
s1monw opened a new pull request #2212:
URL: https://github.com/apache/lucene-solr/pull/2212
Today we force indices that were created with N-2 and older versions of
lucene
to fail on open. This check doesn't even check if the codecs are available.
In order
to allow users to open olde
dsmiley commented on pull request #2016:
URL: https://github.com/apache/lucene-solr/pull/2016#issuecomment-761599353
Yes; invest time in learning Git more; it's a prerequisite nowadays. I'm no
Git expert (e.g. not quite Dawid :-) but I know enough, perhaps more than most
as I've done some
jpountz commented on pull request #2186:
URL: https://github.com/apache/lucene-solr/pull/2186#issuecomment-761585358
> This requirement is ensured only per segment basis, thus it is possible
to have a index where two segments have different data structures
for the same field.
Co
[
https://issues.apache.org/jira/browse/SOLR-15080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17266614#comment-17266614
]
David Eric Pugh edited comment on SOLR-15080 at 1/16/21, 3:18 PM:
-
[
https://issues.apache.org/jira/browse/SOLR-15080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17266614#comment-17266614
]
David Eric Pugh commented on SOLR-15080:
Thanks for the pointer, patch applied gr
jpountz commented on a change in pull request #2205:
URL: https://github.com/apache/lucene-solr/pull/2205#discussion_r558902897
##
File path:
lucene/core/src/java/org/apache/lucene/search/Boolean2ScorerSupplier.java
##
@@ -231,10 +231,27 @@ private Scorer opt(
optiona
epugh commented on pull request #2016:
URL: https://github.com/apache/lucene-solr/pull/2016#issuecomment-761568519
I saw the tip in github to add `.diff` and `.patch` to a url to generate
those files. I think I see the issue, in that the `.patch` file generated was
12 MB, and included all
epugh commented on pull request #2016:
URL: https://github.com/apache/lucene-solr/pull/2016#issuecomment-761566739
I am definitly struggling with branches, keeping up with master. Clearly
there is something I don't understand about the workflow with Git. Plus, I'm
very nervous about an
[
https://issues.apache.org/jira/browse/SOLR-12613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17266599#comment-17266599
]
David Eric Pugh commented on SOLR-12613:
not sure I quite get what you mean? Th
epugh commented on pull request #1435:
URL: https://github.com/apache/lucene-solr/pull/1435#issuecomment-761565236
It's encouraging that there doesn't seem to be a lot of change here, reusing
most of what we have.
Does this have any other ramifications on what it touches? I quick
[
https://issues.apache.org/jira/browse/LUCENE-8574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless updated LUCENE-8574:
---
Fix Version/s: 8.7
master (9.0)
> ExpressionFunctionValues should
[
https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless updated LUCENE-9444:
---
Fix Version/s: 8.7
> Need an API to easily fetch facet labels for a field in a docum
[
https://issues.apache.org/jira/browse/LUCENE-8947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless resolved LUCENE-8947.
Resolution: Won't Fix
It turns out we cannot find a safe way to fix this, so, user
[
https://issues.apache.org/jira/browse/LUCENE-9450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless updated LUCENE-9450:
---
Fix Version/s: master (9.0)
Resolution: Fixed
Status: Resolved (wa
uschindler commented on pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-761546591
As I am the assignee, should I merge this?
This is an automated message from the Apache Git Service.
To r
uschindler commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r558840406
##
File path:
lucene/misc/src/test/org/apache/lucene/misc/store/TestDirectIODirectory.java
##
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Soft
phils commented on pull request #1435:
URL: https://github.com/apache/lucene-solr/pull/1435#issuecomment-761544701
is there no way to progress this further?
This is an automated message from the Apache Git Service.
To respond
uschindler commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r558840321
##
File path:
lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java
##
@@ -346,17 +360,21 @@ public byte readByte() throws IOEx
zacharymorn commented on pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-761525653
> > I will try to find the issue tomorrow...! (not sure if I will have time,
so if you can reproduce on Linux feel free to help out)
>
> Hmmm that's strange. On my
37 matches
Mail list logo
