zacharymorn commented on a change in pull request #2205:
URL: https://github.com/apache/lucene-solr/pull/2205#discussion_r559052772
##########
File path:
lucene/core/src/java/org/apache/lucene/search/DisjunctionMaxScorer.java
##########
@@ -50,7 +50,7 @@
if (tieBreakerMultiplier < 0 || tieBreakerMultiplier > 1) {
throw new IllegalArgumentException("tieBreakerMultiplier must be in [0,
1]");
}
- if (scoreMode == ScoreMode.TOP_SCORES) {
+ if (scoreMode.needsScores()) {
Review comment:
Ahhhh I see now I had a wrong assumption / impression before. For some
reason I mistakenly thought since `MinShouldMatchSumScorer` supports
`ScoreMode.COMPLETE`, `WANDScorer` should also allow score computation for that
mode after deprecation. Will push an update soon to check for
`ScoreMode.TOP_SCORES` instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
