uschindler commented on a change in pull request #2052:
URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r558840321
##########
File path:
lucene/misc/src/java/org/apache/lucene/misc/store/DirectIODirectory.java
##########
@@ -346,17 +360,21 @@ public byte readByte() throws IOException {
private void refill() throws IOException {
filePos += buffer.capacity();
-
+
+ // BaseDirectoryTestCase#testSeekPastEOF test for consecutive read past
EOF,
+ // hence throwing EOFException early to maintain buffer state (position
in particular)
+ if(filePos >= channel.size()) {
Review comment:
I think this was exactly the problem. I was yesterday about to change
this to `>` instead of `>=`. It is allowed to seek to exectly the file size,
which was obviously causing the test failures on windows.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
