jpountz commented on a change in pull request #2205:
URL: https://github.com/apache/lucene-solr/pull/2205#discussion_r559043667
##########
File path:
lucene/core/src/java/org/apache/lucene/search/DisjunctionMaxScorer.java
##########
@@ -50,7 +50,7 @@
if (tieBreakerMultiplier < 0 || tieBreakerMultiplier > 1) {
throw new IllegalArgumentException("tieBreakerMultiplier must be in [0,
1]");
}
- if (scoreMode == ScoreMode.TOP_SCORES) {
+ if (scoreMode.needsScores()) {
Review comment:
> so I was assuming we may need to preserve this behavior when we
deprecate MinShouldMatchSumScorer with WANDScorer
Right I'm hoping we can use WANDScorer for minShouldMatch > 1 for all values
of ScoreMode!
I believe that this exception you saw should disappear if you make sure that
`WANDScorer` only calls `advanceShallow`/`getMaxScore` with
`ScoreMode.TOP_SCORES`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
